[payload] Review of draft-spittka-payload-rtp-opus-02

Tina le Grand <tina.legrand@webrtc.org> Tue, 27 November 2012 10:52 UTC

Return-Path: <tlegrand@google.com>
X-Original-To: payload@ietfa.amsl.com
Delivered-To: payload@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AADD921F84D9 for <payload@ietfa.amsl.com>; Tue, 27 Nov 2012 02:52:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.976
X-Spam-Level:
X-Spam-Status: No, score=-102.976 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-1, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SviGGUbqdRE2 for <payload@ietfa.amsl.com>; Tue, 27 Nov 2012 02:52:17 -0800 (PST)
Received: from mail-vb0-f44.google.com (mail-vb0-f44.google.com [209.85.212.44]) by ietfa.amsl.com (Postfix) with ESMTP id F2EAC21F84B5 for <payload@ietf.org>; Tue, 27 Nov 2012 02:52:13 -0800 (PST)
Received: by mail-vb0-f44.google.com with SMTP id fc26so4858546vbb.31 for <payload@ietf.org>; Tue, 27 Nov 2012 02:52:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; bh=PakXh/n27isISkXpiZjyw7fztSw1sJhFTVtr5EDYf54=; b=DlpzA2d/KYXZiuedRuRr6+QUU8yukk+xH6kfOZ/cLpoW1tL+Hm4NQf7TkccpBd630Q nraqIKHUZablihXclfI+UBIZX88mC2knuy6+RudEiUwZ+HhdC/Lvp3o+iimzi83rb9nL 8BbmGrK/7YkYrrG/41gjbXMouR7KZdZWPDwPjfjCdB5YqSIefuKWIfOU+66fi4iLDOLv Y1CHm37Id8QaKiJQM6CYOx5IhuaCckk+dv7lAg2PRTF6PV2RlBVre8vLegwhltXok15N wYz//YGCvgLk0WLTqYg26SH05nOOihAX3BTFsQqtnI7rC49U0iXJBjVOq29vxiXyYLXK 5ouw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type:x-gm-message-state; bh=PakXh/n27isISkXpiZjyw7fztSw1sJhFTVtr5EDYf54=; b=LE2q8xZ2uoVtW7+80D5MifvzObBNMF4SvNG84Pw3JBZME1ePZf2hjm+kiGio1CycHe 45GvdcI0uRSqiCFWPp9VcRWB22sUoSw8BWwcaiGMo8KptaKpv9YgvgCqnU5HfFYjq4d8 mcHHbw1gVdPylG1gDAgFAYabzI9eROJ/ELyesr3QpVGOiw1g27TEJW1dtEO1YG8k2Q3r sg2o2SHsQ3a+jCjG6BlAE8uczeXIfJZ56AZhcfBnH77aQ/PvEsSczJDLqdD+yDk9hif4 6G3gZRG+7Iq75XszRAKkFF5FrszX/a+p4VautidopHriIwrPPc0fmy6IckivVgpIb7w0 DrQA==
MIME-Version: 1.0
Received: by 10.52.22.240 with SMTP id h16mr20876229vdf.82.1354013533200; Tue, 27 Nov 2012 02:52:13 -0800 (PST)
Sender: tlegrand@google.com
Received: by 10.220.116.133 with HTTP; Tue, 27 Nov 2012 02:52:13 -0800 (PST)
Date: Tue, 27 Nov 2012 11:52:13 +0100
X-Google-Sender-Auth: SN3REPqeljfYoPmazYZkOd5Z7-U
Message-ID: <CAKsXFw4Y=qBXJMwgjPdzrijdGjUsMM+r7_od3R6U07yEwKY=ng@mail.gmail.com>
From: Tina le Grand <tina.legrand@webrtc.org>
To: payload@ietf.org
Content-Type: multipart/alternative; boundary="20cf3079bb0aaae09904cf77d70a"
X-Gm-Message-State: ALoCoQmdQ6HKJZ/Dp6yUdMWxoFQV6kBJq5uDmEFK5rqhri5EFW6O4SCqnDMUPlc9O8GxYdBxaQR0st0L0VMqiKFrb8JgT2g+mtNj6th+TDefkPLqw24rRJe0WMQbMBdi0SNG4XqPFNnTBrDDrVJ2HW0pdnil0PTj5tXlZhh2aPBsTSp1djEbnVjHtrz0bgSri/FUWcC83YbE
Subject: [payload] Review of draft-spittka-payload-rtp-opus-02
X-BeenThere: payload@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Audio/Video Transport Payloads working group discussion list <payload.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/payload>, <mailto:payload-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/payload>
List-Post: <mailto:payload@ietf.org>
List-Help: <mailto:payload-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/payload>, <mailto:payload-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Nov 2012 10:52:18 -0000

Hi,

I was reading through the Opus RTP draft, and I have a few comments I
thought I'd share with you.

   - Section 1, page 3, section 1, line 3: "is is" -> "it is"
   - Section 2, page 4, abbreviation list:
      - PSTN never used in the document, can be removed
      - Add VBR - Variable bitrate
      - Add CBR - Constant bitrate
      - Add DTX - Discontinuous transmission
      - Add FEC - Forward error correction
   - Section 4.1, page 9, Table 2: The name of the table is odd. The table
   is already described in the text on the previous page, and the description
   below the table isn't needed.
   - Section 4.2, page 10, Table 3:
      - Again, the name of table is difficult to read. Consider moving the
      information to the section above instead.
      - This isn't really correct: "fs specifies the audio sampling
      frequency in Herz (Hz)". It's the abbreviations for audio
bandwidth that is
      used in the table.
      - You might want to add that the duration is in milliseconds.
      - In the previous section it says "only one packet output from the
      Opus encoder MUST be used as a payload", but the last sentence
in the table
      description talks about multiple frames in one packet.


   - Section 6.1, page 14, if the receiver says useinbandfec=0, is it okay
   for the sender to send FEC anyway? It doesn't explicitly say in the text.
   - Section 6.2, page 16: it isn't described in the bullet list where to
   include the optional parameter maxplaybackrate.
   - Section 6.2.1, page 18, second bullet: "sprop-maxcaptureerate"
   misspelled twice, should be  "sprop-maxcapturerate".


Thanks,
Tina le Grand.