Re: [payload] WGLC for draft-ietf-payload-tsvcis-00.txt

"Roni Even (A)" <roni.even@huawei.com> Wed, 10 October 2018 10:36 UTC

Return-Path: <roni.even@huawei.com>
X-Original-To: payload@ietfa.amsl.com
Delivered-To: payload@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B51B1130ECC for <payload@ietfa.amsl.com>; Wed, 10 Oct 2018 03:36:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P_tSqEgLrGuo for <payload@ietfa.amsl.com>; Wed, 10 Oct 2018 03:36:15 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0598B130EC1 for <payload@ietf.org>; Wed, 10 Oct 2018 03:36:15 -0700 (PDT)
Received: from LHREML714-CAH.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 4AD05BF5D0879 for <payload@ietf.org>; Wed, 10 Oct 2018 11:36:11 +0100 (IST)
Received: from DGGEMM403-HUB.china.huawei.com (10.3.20.211) by LHREML714-CAH.china.huawei.com (10.201.108.37) with Microsoft SMTP Server (TLS) id 14.3.399.0; Wed, 10 Oct 2018 11:36:12 +0100
Received: from DGGEMM526-MBX.china.huawei.com ([169.254.8.153]) by DGGEMM403-HUB.china.huawei.com ([10.3.20.211]) with mapi id 14.03.0399.000; Wed, 10 Oct 2018 18:36:01 +0800
From: "Roni Even (A)" <roni.even@huawei.com>
To: "Ali C. Begen" <ali.begen@networked.media>, "payload@ietf.org" <payload@ietf.org>
Thread-Topic: [payload] WGLC for draft-ietf-payload-tsvcis-00.txt
Thread-Index: AQHUYGTb/Ck/lD1KcUi9WL2LGJ4ieaUYQaVw
Date: Wed, 10 Oct 2018 10:36:01 +0000
Message-ID: <6E58094ECC8D8344914996DAD28F1CCD8E47AD@dggemm526-mbx.china.huawei.com>
References: <CAA4MczvuQUw-q4xmDSm+yC0WPb0MVkmS+w_Rv=qCEg8jxx1pMA@mail.gmail.com>
In-Reply-To: <CAA4MczvuQUw-q4xmDSm+yC0WPb0MVkmS+w_Rv=qCEg8jxx1pMA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.200.202.226]
Content-Type: multipart/alternative; boundary="_000_6E58094ECC8D8344914996DAD28F1CCD8E47ADdggemm526mbxchina_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/payload/f2W_a9o7xM3LQRovj1ixP53vKnY>
Subject: Re: [payload] WGLC for draft-ietf-payload-tsvcis-00.txt
X-BeenThere: payload@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Payloads working group discussion list <payload.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/payload>, <mailto:payload-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/payload/>
List-Post: <mailto:payload@ietf.org>
List-Help: <mailto:payload-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/payload>, <mailto:payload-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Oct 2018 10:36:18 -0000

Hi,
I read the document, some comments

1.   Add a reference to TSVCIS in section 1 when first mentioned. Is there a reference to tsvcis that is publically available?

2. the following sentence in 3.1 is not clear  “RTP packetization of MELPe follows RFC 8130 and is repeated here for all three MELPe rates [RFC8130] which with promoted suggestions or recommendations now regarded as requirements “

3.  Typo in section 3.1 “The comfort nosie frame”

4. In section 3.2 “The TSVCIS augmented speech data as packed parameters MUST be placed immediately after a corresponding MELPe 2400 bps payload “ does it mean in the same RTP packet?




5. section 3.3 “TSVCIS coder frames in a single RTP packet MAY be of different coder bitrates.  With the exception for the variable length TSVCIS parameter frames, the coder rate bits in the trailing byte identify

   the contents and length as per Table 1.” I understand that the parsing is done by looking at the expected position for the CODA, CODB and CODC, this is similar to MELPE but here there is tsvcis data which is variable length. Is the parsing done by assuming that the tsvcis data frame may only appear after a 2400 frame?



6. In section 4.1 for tcmax maybe specify 35 and ask for feedback



7. In section 4.1 published specification should be RFCXXXXand ask the RFC editor to replace with the RFC number of this document.



Roni Even as individual





From: payload [mailto:payload-bounces@ietf.org] On Behalf Of Ali C. Begen
Sent: Wednesday, October 10, 2018 9:43 AM
To: payload@ietf.org
Subject: [payload] WGLC for draft-ietf-payload-tsvcis-00.txt

All,

This is to start the WGLC for the following draft:
https://www.ietf.org/id/draft-ietf-payload-tsvcis-00.txt

Please send comments to the list by Oct. 24th.

Thanks.
-acbegen
________________________________