[payload] review of draft-df-stecker-expertenforum-payload-tetra-00

"Roni Even (A)" <roni.even@huawei.com> Sun, 18 March 2018 10:30 UTC

Return-Path: <roni.even@huawei.com>
X-Original-To: payload@ietfa.amsl.com
Delivered-To: payload@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 84D5E127077 for <payload@ietfa.amsl.com>; Sun, 18 Mar 2018 03:30:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.23
X-Spam-Level:
X-Spam-Status: No, score=-4.23 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hy4b-eVgdFYL for <payload@ietfa.amsl.com>; Sun, 18 Mar 2018 03:30:50 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AF037127599 for <payload@ietf.org>; Sun, 18 Mar 2018 03:30:49 -0700 (PDT)
Received: from LHREML711-CAH.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 4313B2866C323 for <payload@ietf.org>; Sun, 18 Mar 2018 10:30:46 +0000 (GMT)
Received: from DGGEMM424-HUB.china.huawei.com (10.1.198.41) by LHREML711-CAH.china.huawei.com (10.201.108.34) with Microsoft SMTP Server (TLS) id 14.3.382.0; Sun, 18 Mar 2018 10:30:47 +0000
Received: from DGGEMM506-MBX.china.huawei.com ([169.254.3.214]) by dggemm424-hub.china.huawei.com ([10.1.198.41]) with mapi id 14.03.0361.001; Sun, 18 Mar 2018 18:30:41 +0800
From: "Roni Even (A)" <roni.even@huawei.com>
To: "payload@ietf.org" <payload@ietf.org>
Thread-Topic: review of draft-df-stecker-expertenforum-payload-tetra-00
Thread-Index: AdO+noCKXg3hAn4dTqCwB52K75Au8w==
Date: Sun, 18 Mar 2018 10:30:41 +0000
Message-ID: <6E58094ECC8D8344914996DAD28F1CCD86CD40@DGGEMM506-MBX.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.47.91.2]
Content-Type: multipart/alternative; boundary="_000_6E58094ECC8D8344914996DAD28F1CCD86CD40DGGEMM506MBXchina_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/payload/zN03JxCXn7BbxtPHgmalrPCOyuA>
Subject: [payload] review of draft-df-stecker-expertenforum-payload-tetra-00
X-BeenThere: payload@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Audio/Video Transport Payloads working group discussion list <payload.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/payload>, <mailto:payload-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/payload/>
List-Post: <mailto:payload@ietf.org>
List-Help: <mailto:payload-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/payload>, <mailto:payload-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Mar 2018 10:30:53 -0000

Hi,
I read the draft and have some comments.

1. in the abstract you can remove the sentence about the storage mode and in the first sentence remove "to be used"

2. In the introduction (section 1 ) add the reference to TETRA in the first sentence.

3. In section 3 what are E1 lines?

4. Last secntence of section 3 -  Is it used, what is the use case for carrying  OSTE in RTP where there is timing information is RTP.

5.  In section 4 "or together  within one RTP frame " maybe say RTP packet.

6.  For clarity maybe move section 4.4 before section 4.2 (or include 4.4 in the beginning of 4.2)

7. About the note at the end of 4.3 , what out of scope means? Is it meant to say MUST be ignored by the RTP receiver?

8.  In section 4.2.4 "This bit may be set to "1" if an encryption or a decryption operation could not be performed successfully".  Since this is the sent RTP stream,  I can understand cannot encrypt this half block, what does it mean cannot decrypt.

9. In section 4.2.4 -" If a receiver decides to forward the TETRA audio data to   OSTE or FSTE"  . How is the decision made and should he forward this sub block or the whole audio stream?

10. in section 6 maybe use the following text "Since UDP does not provide congestion control, applications that use  RTP over UDP SHOULD implement their own congestion control above the
   UDP layer [RFC8085<https://tools.ietf.org/html/rfc8085>] and MAY also implement a transport circuit  breaker [RFC8083<https://tools.ietf.org/html/rfc8083>]3>].  Work in the RMCAT working group [RMCAT<https://tools.ietf.org/html/rfc8130#ref-RMCAT>] describes
   the interactions and conceptual interfaces necessary between the  application components that relate to congestion control, including   the RTP layer, the higher-level media codec control layer, and the
   lower-level transport interface, as well as components dedicated to   congestion control functions."

11. section 7 use "per the media type   registration template from RFC 6838<https://tools.ietf.org/html/rfc6838> [RFC6838<https://tools.ietf.org/html/rfc6838>]."

12.  in section 7.1 - drgw-fe - Why do you need to specify it here and register this parameter. If you are sending rtp payload with subtype name tetra it is this rtp payload.

13.  In section 7.1 - security consideration should say see section 10 of RFCXXXX (this RFC) and a note to RFC editor to replace RFCXXXX with the number of this RFC

14. In section 8 - we do not use the term MIME but media type or media subtype.

15. in the example at the end of section 8 the a=fmtp:99 is not needed if you do not have any optional parameters.

16.  in 8.1 add reference to RFC3264. Also about maxptime. Do they need to be symmetric, is it allowed to use values that are not 60?

17. In section 8.2 Multiple TETRA rtpmap values MAY be used to convey TETRA-coded voice at different packet  rates. Does not work if you want to use ptime and maxptime since there can be one for media section, it is a=maxptime:60 and not a=rtpmap:xx ptime:60

18. in section 9 add at the end of first sentence "from section 7.1"



Roni Even as individual















________________________________