Re: [Pce] Chair's Review of draft-ietf-pce-stateful-pce-11
Ina Minei <inaminei@google.com> Thu, 03 December 2015 17:10 UTC
Return-Path: <inaminei@google.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B0BEA1AC3CB for <pce@ietfa.amsl.com>; Thu, 3 Dec 2015 09:10:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.388
X-Spam-Level:
X-Spam-Status: No, score=-1.388 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E3xzccm7qd97 for <pce@ietfa.amsl.com>; Thu, 3 Dec 2015 09:10:02 -0800 (PST)
Received: from mail-yk0-x236.google.com (mail-yk0-x236.google.com [IPv6:2607:f8b0:4002:c07::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6A3091A92E3 for <pce@ietf.org>; Thu, 3 Dec 2015 09:10:02 -0800 (PST)
Received: by ykdr82 with SMTP id r82so93083836ykd.3 for <pce@ietf.org>; Thu, 03 Dec 2015 09:10:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=gpFQvfNnb+kDLs1Y1GE/xKp07Iw1H5MWr8VCtH31URM=; b=lKmrVgsglcdOHW4NvgFXPLOIyuVTE/0U12mi2dM18NKCUkawbHPsUD5B1iDqWjmELs X77MyH6fWmXNdSBY9Fpq95PhVKT0ewbyjPvbQRVfzfl5N8r8s7Dcqcvjyxi0QAUWrR6v Gnkt9pDTzqo7r49zbFXStSlGwkaWnxb/DX5YNRAWQg5+bWMPDgKh6fPqnyEUqR4zlBgv yNqf8KTNY7ecs6s5DSBoS12eF2CQ7zmxl+ixjg9sirhO7f+S+A6YyoRHY7YdILFAfL+7 OzQvmVxZ1fn1NPyBiZBw2uh38AE6Nw3ls3LSlG99FF9g0mt+pIBaankyLrUuLZyEoaNX lFug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=gpFQvfNnb+kDLs1Y1GE/xKp07Iw1H5MWr8VCtH31URM=; b=kHdbHN956uqY1EdGH4rsgArgQBP+KxFrgYNg9Y1nlUYT0qzhr3xpcLK3Q4IvvMMP5h CZi1kUlQSFb2DWkbsNNnvZD/NIM3we4dvOVZnhOfoSzCQOoE8YdmxI0CXS8CkHY5lxgS +g6jdQaG62YomaeOmc8nC9MWfLyQSOqFX/UJyYO6NzbJqlV09B+2nSnmyO8BCIf9o0Ef Zm3hZd5sZ8hdgsN9mfqODgM6kvvF86GmRsj0ab09eXxsHkQcnyQwhb+9JmXAoPoqV/4w 4PiMIcBgvk7aeCq7eApdbcc4YXQQ8b14jiJXfm53tE+VdoBbVzabY6c8y/PLyPa+8se2 3VGQ==
X-Gm-Message-State: ALoCoQl64E721V6sB+8y+cmfA4r9iBF4s80buZryT4DfeqIuCEmdUZwvybK53aCPNaboLX7PiD8a
MIME-Version: 1.0
X-Received: by 10.129.78.7 with SMTP id c7mr8469833ywb.210.1449162601448; Thu, 03 Dec 2015 09:10:01 -0800 (PST)
Received: by 10.37.119.197 with HTTP; Thu, 3 Dec 2015 09:10:01 -0800 (PST)
In-Reply-To: <CAG4Q_avu_1DTo_JJODn7QGXr2Fv6mHuyGP1EkPC5YeOP1iePbQ@mail.gmail.com>
References: <56210C68.1080904@orange.com> <CAG4Q_avL_vVpmzyTfk4uGbdKYhvYVr_74KfaX-5iCGm7Vf+xVA@mail.gmail.com> <56422DF8.6030403@orange.com> <CAG4Q_avu_1DTo_JJODn7QGXr2Fv6mHuyGP1EkPC5YeOP1iePbQ@mail.gmail.com>
Date: Thu, 03 Dec 2015 09:10:01 -0800
Message-ID: <CAG4Q_asD4uvcTkj_PjhPFYAXOYbq-+_woKjmFAJT4eEk3vQTQw@mail.gmail.com>
From: Ina Minei <inaminei@google.com>
To: Julien Meuric <julien.meuric@orange.com>
Content-Type: multipart/alternative; boundary="001a114dacbc154d4505260176d3"
Archived-At: <http://mailarchive.ietf.org/arch/msg/pce/-uT35t3XvQEaB7lC3-VH2ETlRWo>
Cc: draft-ietf-pce-stateful-pce@ietf.org, "pce@ietf.org" <pce@ietf.org>
Subject: Re: [Pce] Chair's Review of draft-ietf-pce-stateful-pce-11
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2015 17:10:06 -0000
All the changes discussed in this thread have been incorporated in version 13 published yesterday https://tools.ietf.org/html/draft-ietf-pce-stateful-pce-13 Thank you, Ina On Sun, Nov 29, 2015 at 1:21 PM, Ina Minei <inaminei@google.com> wrote: > Thanks a lot for the very useful discussions and for the continued review. > Please see inline %%%, a new version of the draft will be published next > week, > > Ina > > On Tue, Nov 10, 2015 at 9:48 AM, Julien Meuric <julien.meuric@orange.com> > wrote: > > [snip] > >> Two questions and one ask >>> 1. Forward references to SRP object and SRP-ID - there are several in >>> the comments, though the relevant section is always mentioned. How should >>> such forward references be addressed? >>> >> [JM] A simple way is to add the acronym and its expansion into the >> terminology section, and optionally the forward reference. >> >> %%% Done > > >> 2. Section 7 - s/defined in this document/defined in that >>> (aforementioned) document/ >>> The comment was not clear to me. The intention is for the flags to be >>> set as explained for the new objects we are defining here, can you clarify >>> the comment? >>> >> [JM] Just suggesting a rewording, but my proposal was not clear either; >> "this current I-D" may be enough to clear the ambiguity. > > %%% Done > > [snip] > > >> - s/Active Stateful PCE: is an extension/Active Stateful PCE: an >>> extension/ >>> >>> ### Replaced as "an Active Stateful PCE that may issue >>> recommendations... >>> >>> [JM] Guessing you actually meant "a Stateful PCE that may...", it is OK. >> > %%% Yes :-) > > [snip] > >> >>> >>> >>> >>> - OLD >>> State Timeout Interval: when a PCEP session is terminated, a PCC >>> waits for this time period before flushing LSP state associated >>> with that PCEP session and reverting to operator-defined default >>> parameters or behaviors. >>> NEW >>> State Timeout Interval: the period of time a PCE waits for, when a >>> PCEP session is terminated, before flushing LSP state associated >>> with that PCEP session and reverting to operator-defined default >>> parameters or behaviors. >>> >>> ### Done >>> >> [JM] I hope you caught my (double) typo: I was only trying to rephrase, >> the waiting party remaining the PCC. >> >> %%% I did now :-), fixed. > > [snip] > >> >> <snip> >> >>> >>> - The reference to draft-sivabalan-pce-disco-stateful makes the >>> reader wonder why is is not part of draft-ietf-pce-stateful-pce >>> itself. Besides, Table 1 also mentions IS-IS and OSPF >>> PCE-CAP-FLAGS sub-TLV, only the allocation section seems to be >>> missing here. Would you talk to the authors (some being common to >>> both I-Ds) of the former to consider using their material as a >>> contribution? A separate document is quite an overhead for >>> allocating 2 bits. >>> >>> >>> ### I don't think discovery should be part of the base draft. Several >>> reasons: a) 5440 does not include discovery, b) the base spec is already >>> quite large, we want to keep only the core function and c) the discovery >>> draft is expired. I cleaned up table 1 and added the following text instead >>> of the reference to the draft: >>> Old text >>> [I-D.sivabalan-pce-disco-stateful] defines the extensions needed >>> tosupport autodiscovery of stateful PCEs when using OSPF ([RFC5088]) or >>> IS-IS ([RFC5089]) for PCE discovery. >>> New text >>> Similarly to [RFC5440], no assumption is made about the discovery method >>> used by a PCC to discover a set of PCEs (e.g., via static configuration or >>> dynamic discovery) and on the algorithm used to select a PCE. Extensions >>> needed to support autodiscovery will be defined in a separate document. >>> >> [JM] Along with RFC 5557 and 6006, including discovery bit allocation >> with PCEP extensions in a single document would save much administrative >> processing. >> >> %%% Done > > >> <snip> >> >>> >>> - s/include an empty ERO/include an empty RRO/ [Along with RFC >>> 5440 (section 7.10), the object sent by a PCC to report to a PCE >>> is an RRO: let us keep it consistent.] >>> >>> ### XXX Pending >>> >> [JM] As discussed, clarifying that you encode the "intended path" using >> ERO (class 7) and "actual path" using RRO (class 8) will address my >> comments related to xROs. >> >> %%% Done > > >> <snip> >> >>> >>> - Avoiding "positive acknowledgements for properly received >>> synchronization messages" has scalability benefits in normal >>> situations, but the PCC is blind and may keep on sending PCRpt to >>> dead processes behind up PCEP sessions. Have you consider >>> acknowledgement, possibly using a compression mechanism like the >>> one defined later in the I-D? >>> >>> ### XXX Pending >>> >> %%% No, we did not think we needed positive acks because we are using a > TCP session (guaranteed delivery all the way to the PCE). > > >>> - When mentioning errors, adding a sentence reminding that RFC >>> 5440 already defines a set of applicable error codes would be >>> valuable. >>> >>> ### XXX Pending >>> >> %%% Done see text below: > "Error reporting is done using the procedures defined in [RFC5440], and > reusing the applicable error types and error values of [RFC5440] wherever > appropriate. The current document defines new error values for several > error types to cover failures specific to stateful PCE." >> >> >>> <snip> >> >>> >>> - In section 5.5.1, it is not clear if an empty LSP Update Request >>> with a Delegate flag to 1 is an acceptable way for a PCE to send a >>> delegation acknowledgement: to be clarified. >>> >>> ### XXX Pending >>> >> %%% Yes, it is allowed, modified the text to clarify. > > >> <snip> >> >>> >>> - s/SHOULD return the LSP delegation/MUST return the LSP delegation/ >>> >>> ### This should remain SHOULD. The nice way to do it is to return it >>> explicitly, but it may choose to wait until the next update and return the >>> delegation then by not setting the delegate flag. >>> >> [JM] As discussed together, I can live with that. >> >> - In section 5.5.3, assuming an LSP was delegated, does the >>> reception by the PCC of a non empty LSP Update Request with a >>> Delegate Flag to 0 trigger an error? >>> >>> ### XXX Pending >>> >> %%% No, this is a delegation return. I cleaned up the text, see below. > > In order to keep a delegation, a PCE MUST set the Delegate flag to 1 > on each LSP Update Request sent to the PCC. A PCE that no longer > wishes to update an LSP's parameters SHOULD return the LSP delegation > back to the PCC by sending an empty LSP Update Request which has the > Delegate flag set to 0. If a PCC receives a non-empty LSP Update > Request with the Delegate flag set to 0, it MUST treat this as a > delegation return. > > > >> <snip> >> >>> >>> - At the top of page 18, "and [assuming that] PCEs' decisions are >>> the same" should be added. >>> >>> ### The comment is not clear - I am assuming you refer to the text >>> "assuming that the state timeout... ' on page 17, changed to: " and >>> assuming that the primary and redundant PCEs take similar decisions, this" >>> >> [JM] You got my point. :-) >> >> <snip> >> >>> >>> - In section 5.6.2, in case of new LSP, the very first message >>> sent by the PCC aims at getting a path. This is clearly the role >>> of a PCReq message, and the I-D extends it to support the LSP >>> object including the delegation flag (section 7.3). However, >>> Figure 8 treats a new LSP the same way as reporting an existing >>> LSP, i.e., using a PCRpt message. In this case, there is an >>> overlap between PCReq and PCRpt, which MUST be resolved because >>> interoperability is at stake. Documenting the delegation of a new >>> LSP deserves some new text and possibly figure, the overlapping >>> specification of the PCRpt should be explicitly precluded. >>> >>> ### This is historical confusion in the figure, from the time when >>> initiation was rolled up in the same document. I modified the figure so it >>> is clear this is for updating parameters only. >>> >> [JM] Seems addressed. Just to be confirmed when published and to >> confront with draft-ietf-pce-pce-initiated-lsp. >> >> <snip> >> >>> >>> - s/<ERO><attribute-list>/<RRO><attribute-list>/ [Per RFC 5440, a >>> report from PCC to PCE is RRO.] >>> >>> ### XXX Pending >>> >> [JM] As above. > > %%% Done > >> >> >> - The need for the optional xRO is not well documented. Its proper >>> naming will depend on the associated use that must be clarified. >>> - "SRP" is still not defined. >>> >>> ### Isn't it enough to reference the section in which it is defined? >>> >> [JM] Once added in terminology section, all these are solved. >> >> %%% Done > > >> <snip> >> >>> >>> - The use of the optional xRO is mentioned, but its relationship >>> with the RRO (formerly ERO) is not clear. I suspect some >>> assumptions are made on the way the ERO/RRO are populated; RFC >>> 5440 only says ERO for PCE->PCC and RRO for PCC->PCE. >>> >>> ### XXX Pending >>> >> [JM] As above. >> >> %%% Done > >> <snip> >> >>> >>> - The behavior associated to the resource limit per PCC rather >>> looks like a Notifcation than an Error (e.g., in RFC 5440, >>> cancelling a set of pending requests relies on PCNtf). Please >>> consider the use of Notification instead of Error here. >>> >>> ### XXX Pending >>> >> [JM] To be updated. >> %%% Done >> > > >> <snip> >> >>> >>> - s/defined in this document/defined in that (aforementioned) >>> document/ >>> >>> ### Unclear comment, the intention was for the flags to be set as >>> explained for the new objects in this document, not for anything in 5440. >>> >> [JM] As above: adding "current" may be enough. >> %%% Done > > > >> <snip> >> >>> >>> - s/on a PCRpt message/On a PCRpt or PCReq message/ >>> >>> ### We don't support delegation through a PCReq message >>> >> [JM] Addressed as part of the resolution of the new path delegation. >> >> <snip> >> >>> >>> - "PCE SHOULD remove all state" is written 3 times: I wonder about >>> "MUST". >>> >>> ### SHOULD is the correct operation, the PCE is free to choose to keep >>> state around for as long as it wishes. The 3 removal statements refer to >>> different scenarios. >>> >> [JM] I can live with that. >> >> <snip> >> >>> >>> - It would be nice to elaborate on the reason why the >>> SYMBOLIC-PATH-NAME MUST be included and not SHOULD. >>> - I do not see why SYMBOLIC-PATH-NAME may be included in SRP >>> Object: defining the LSP Object as its single place seems enough >>> and much simpler. >>> >>> >>> ### XXX Pending >>> >> %%% The inclusion in SRP was a historical leftover and is removed. > Regarding why it MUST be included in the LSP object is described in the > draft in section 7.3.2. It is a stable (across PCEP session, PCC restart, > ..etc), signaling protocol agnostic, and unique Identifier that identifies > the LSP during its lifetime. > > >> <snip> >> >>> - As mentioned above, in Error-Type 19, Error-value 4 should be >>> considered in a PCNtf. >>> ### XXX Pending >>> >> <snip> > > %%% Done > >> >> >>> - Again in section 10.4, the "resource limit exceed" information >>> (Error-value 4 of Error-Type 19) should be considered in a PCNtf. >>> >>> ### XXX Pending >>> >> <snip> >> > %%% Done > >
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Robert Varga
- [Pce] Chair's Review of draft-ietf-pce-stateful-p… Julien Meuric
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Ina Minei
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Julien Meuric
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Ina Minei
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Ina Minei
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Julien Meuric
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Robert Varga
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Julien Meuric
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Jan Medved (jmedved)
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Robert Varga
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Ina Minei
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Ina Minei
- Re: [Pce] Chair's Review of draft-ietf-pce-statef… Julien Meuric