Re: [Pce] Suresh Krishnan's No Objection on draft-ietf-pce-association-group-09: (with COMMENT)

Dhruv Dhody <dhruv.dhody@huawei.com> Thu, 11 July 2019 06:17 UTC

Return-Path: <dhruv.dhody@huawei.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A2B4A1200F4; Wed, 10 Jul 2019 23:17:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 54zk0KkDfEMw; Wed, 10 Jul 2019 23:17:37 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A966212008B; Wed, 10 Jul 2019 23:17:37 -0700 (PDT)
Received: from LHREML713-CAH.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id C1F611F8054D43C8634D; Thu, 11 Jul 2019 07:17:34 +0100 (IST)
Received: from lhreml706-chm.china.huawei.com (10.201.108.55) by LHREML713-CAH.china.huawei.com (10.201.108.36) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Jul 2019 07:17:34 +0100
Received: from lhreml706-chm.china.huawei.com (10.201.108.55) by lhreml706-chm.china.huawei.com (10.201.108.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 11 Jul 2019 07:17:34 +0100
Received: from BLREML701-CAH.china.huawei.com (10.20.4.170) by lhreml706-chm.china.huawei.com (10.201.108.55) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA_P256) id 15.1.1713.5 via Frontend Transport; Thu, 11 Jul 2019 07:17:34 +0100
Received: from BLREML503-MBX.china.huawei.com ([169.254.9.50]) by blreml701-cah.china.huawei.com ([::1]) with mapi id 14.03.0439.000; Thu, 11 Jul 2019 11:47:22 +0530
From: Dhruv Dhody <dhruv.dhody@huawei.com>
To: Suresh Krishnan <suresh@kaloom.com>, The IESG <iesg@ietf.org>
CC: "pce@ietf.org" <pce@ietf.org>, "pce-chairs@ietf.org" <pce-chairs@ietf.org>, "draft-ietf-pce-association-group@ietf.org" <draft-ietf-pce-association-group@ietf.org>
Thread-Topic: [Pce] Suresh Krishnan's No Objection on draft-ietf-pce-association-group-09: (with COMMENT)
Thread-Index: AQHVN2fTiZkKy1milE+nzwPSHak1s6bE8Krw
Date: Thu, 11 Jul 2019 06:17:22 +0000
Message-ID: <23CE718903A838468A8B325B80962F9B8DB1A0DF@BLREML503-MBX.china.huawei.com>
References: <156279465698.15539.15530286228049893555.idtracker@ietfa.amsl.com>
In-Reply-To: <156279465698.15539.15530286228049893555.idtracker@ietfa.amsl.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.18.149.39]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/2Afezug5IerKgqX4UkbubZ0Ekzk>
Subject: Re: [Pce] Suresh Krishnan's No Objection on draft-ietf-pce-association-group-09: (with COMMENT)
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jul 2019 06:17:41 -0000

Hi Suresh, 

Agreed, and updated in the working copy. 

https://github.com/dhruvdhody-huawei/ietf/commit/4cfd450b0cef372c04340aed2d5cb3639887f631

Thanks! 
Dhruv


> -----Original Message-----
> From: Pce [mailto:pce-bounces@ietf.org] On Behalf Of Suresh Krishnan via
> Datatracker
> Sent: 11 July 2019 03:08
> To: The IESG <iesg@ietf.org>
> Cc: pce@ietf.org; pce-chairs@ietf.org; draft-ietf-pce-association-
> group@ietf.org
> Subject: [Pce] Suresh Krishnan's No Objection on draft-ietf-pce-
> association-group-09: (with COMMENT)
> 
> Suresh Krishnan has entered the following ballot position for
> draft-ietf-pce-association-group-09: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-pce-association-group/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> * Section 6.1.
> 
>    Association Source: 4 or 16 bytes - A valid IPv4 or IPv6 address that
>    provides scoping for the Association ID.  See Section 6.1.3 for
>    details.
> 
> If I understand correctly, the length of this field is not really 4 or 16
> bytes but rather fully dependent on the ASSOCIATION Object-Type. i.e. you
> cannot have a 16 byte address here if the Object_Type is 1. If so, it
> would be good to state this dependence explicitly. Suggest something like
> 
>   Association Source: Contains a valid IPv4 address (4 bytes) if  the
>   ASSOCIATION Object-Type is 1 or a valid IPv6 address (16 bytes) if  the
>   ASSOCIATION Object-Type is 2. It provides scoping for the Association ID.
>   See Section 6.1.3 for details.
> 
> 
> _______________________________________________
> Pce mailing list
> Pce@ietf.org
> https://www.ietf.org/mailman/listinfo/pce