Re: [Pce] I-D Action: draft-ietf-pce-pcep-yang-09.txt

[Dhruv Dhody <[e-mail]>]

Hi Tom,

Thanks again for your review. I made an update to the draft (-10).

More inline..

On Thu, Oct 18, 2018 at 6:53 PM tom petch <[e-mail]> wrote:
>
> Dhruv
>
> I will have some more in a day or so.  Meanwhile,
>
> I note that some of the lines exceed the limit allowed for an RFC, e.g.
> in the tree diagrams.
>

done.

> The convention (rule almost) is to use the same prefix for the same
> module in all cases; here you have
>        import ietf-pcep {
>           prefix p;
> and
> module ietf-pcep {
> ...
>     prefix pcep;
>

well I updated the prefix at module ietf-pcep to "p".
Using a big prefix makes keeping everything within 80 characters difficult.

> I find it useful for the YANG reference clauses to include the name of
> the RFC as well as the RFC number e.g.
>        reference
>          "RFC4360: BGP Extended Communities Attribute.
>           RFC5668: 4-Octet AS Specific BGP Extended Community.";
>

Updated.

> > You say
> >    RFC Ed.: In this section, replace all occurrences of 'XXXX' with
> the
> >    actual RFC number ...
> > and then
> >     import ietf-te {    prefix "te";    reference "RFC XXXX";    }
> >     import ietf-te-types {     prefix "te-types";    reference "RFC
> > XXXX";
> >     import ietf-tls-server {   prefix "tls-server";    reference "RFC
> > XXXX";   }
> >     import ietf-tls-client {    prefix "tls-client";     reference
> "RFC
> > XXXX";
> >
> > Mmm I think not!
> >

Updated.

> > And, I like all the references in the YANG module but they need to be
> in
> > the references of the I-D.  I think you are missing
> >
> > 3209
> > 5088
> > 5089
> > 5520
> > 5541
> > 5557
> > 6536
> > 8232
> > 8306
> >
> > while
> > 8253
> > is there but Informative; my preference is for such references to be
> > Normative.
> >

Updated.

> > A common practice is to have a section just prior to the module proper
> > which gives references to all the RFC which the module references,
> which
> > obviates the appearance of warnings about  'Unused Reference'.
> >

Updated.

Thanks for your continued reviews of all the yang work and keeping
everyone on their toes :)

Thanks,
Dhruv

> > Tom Petch
> >
> >
> > > Dhruv
> > > PS. The yang errors in the datatracker are in the imported yang
> > modules.
> > >
> > > On Mon, Oct 15, 2018 at 6:32 PM <[e-mail]> wrote:
> > >
> > > >
> > > > A New Internet-Draft is available from the on-line Internet-Drafts
> > > > directories.
> > > > This draft is a work item of the Path Computation Element WG of
> the
> > IETF.
> > > >
> > > >         Title           : A YANG Data Model for Path Computation
> > Element
> > > > Communications Protocol (PCEP)
> > > >         Authors         : Dhruv Dhody
> > > >                           Jonathan Hardwick
> > > >                           Vishnu Pavan Beeram
> > > >                           Jeff Tantsura
> > > >         Filename        : draft-ietf-pce-pcep-yang-09.txt
>