Re: [Pce] Éric Vyncke's Discuss on draft-ietf-pce-pcep-extension-for-pce-controller-12: (with DISCUSS and COMMENT)

Dhruv Dhody <dd@dhruvdhody.com> Thu, 25 February 2021 15:21 UTC

Return-Path: <dd@dhruvdhody.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 070FB3A1B18 for <pce@ietfa.amsl.com>; Thu, 25 Feb 2021 07:21:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=dhruvdhody-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IlJEsIKBeHfj for <pce@ietfa.amsl.com>; Thu, 25 Feb 2021 07:21:04 -0800 (PST)
Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 74ACA3A1B07 for <pce@ietf.org>; Thu, 25 Feb 2021 07:21:04 -0800 (PST)
Received: by mail-pj1-x102d.google.com with SMTP id s23so3725820pji.1 for <pce@ietf.org>; Thu, 25 Feb 2021 07:21:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dhruvdhody-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kUMcPFnKYphPcG59OG3ncZDuqN23JovrVogUWLfQTmg=; b=omm+EtGFYSDb4Htu133M+xhs0eoixxGo9AcXbSjgjb/fuNAvskAxCctnjkIrT9jpMa HhPzEJtuEijJHlrTreUJ0plQIQsbHAFTHs1rfmV1mPSczjR9c2kGvu+Fe4vR60aQvP3k Rellxl/PnG48enqG0ACKk0VUR6nc8qKKaE8eGzxdUSatG2GNh8A1FKTsQrPCzo5YxoZG 4aFO5kgiCTCm5wbN+RXEL2eROPFN1oSMR8FK7f6ugJ5B1fopZh62rSaHKMuRJS4StWtT U07t5L22HeFujDRuwwn9kmIvkeyB2Q1XG14j3m9Ru4Pl47HKKYgtfq/tc/PPlAqgOhkT rKkw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kUMcPFnKYphPcG59OG3ncZDuqN23JovrVogUWLfQTmg=; b=hyVZwtG2vk/y/rj+awgoOmz20m6nWW2sP7M1xc7Q9H8ur/j7zaMcp31Hwl91VvTznt B0xciBu+apV60S27glLBR5lWVAKwefliTpWUBJQCxz6ZMw1OuUWHDlzRmP37hshE8Bjc Bh0mQkimGnNznDc5MG9WDhUlXQgOCXxmtNdrBNJtl7OkYDMb9p5Pc9e9YMFe//rggJuR RBGAm75EE9iKVv8WIEn2sWgrvH7znhRwY2ElU4Mv6vbIgrSyHSuA/KJEoSlZpCH3I/Mp F1VZLZGyNuZRH8JiKtXgpNxsgFcoRhhulI3KJpJnqLdgQ8FHJYhO5mg7AWEg5UdNOVbT yWZw==
X-Gm-Message-State: AOAM530cWFf7jIK8v3Lj3zg4xh54jVsVfcFegI7OvnyognYLNTVZRTtM 4Kus99iz2S95/8kDcb9sNKE7kklTXomcI8iTblvsOA==
X-Google-Smtp-Source: ABdhPJxARKm2hQSiZqgg4VM9EBe11AelxzqrJQSmoWxh1w5TWXirqLwK2SckwZGwq3CZxwBCt4BqhNto2rOtBzVAoPA=
X-Received: by 2002:a17:90a:5d8f:: with SMTP id t15mr1303850pji.94.1614266463913; Thu, 25 Feb 2021 07:21:03 -0800 (PST)
MIME-Version: 1.0
References: <161426552149.16097.6516812692543543724@ietfa.amsl.com>
In-Reply-To: <161426552149.16097.6516812692543543724@ietfa.amsl.com>
From: Dhruv Dhody <dd@dhruvdhody.com>
Date: Thu, 25 Feb 2021 20:50:27 +0530
Message-ID: <CAP7zK5Z8GdDghPhsknN6FVciV+vF61C8GGKC_LDm-oX9SgAq5w@mail.gmail.com>
To: Éric Vyncke <evyncke@cisco.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-pce-pcep-extension-for-pce-controller@ietf.org, pce-chairs <pce-chairs@ietf.org>, pce@ietf.org, Julien Meuric <julien.meuric@orange.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/8zI5Cnlk9wLXAzWRT81or4iRA7c>
Subject: Re: [Pce] Éric Vyncke's Discuss on draft-ietf-pce-pcep-extension-for-pce-controller-12: (with DISCUSS and COMMENT)
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Feb 2021 15:21:06 -0000

Hi Eric,

On Thu, Feb 25, 2021 at 8:35 PM Éric Vyncke via Datatracker
<noreply@ietf.org> wrote:
>
> Éric Vyncke has entered the following ballot position for
> draft-ietf-pce-pcep-extension-for-pce-controller-12: Discuss
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-pce-pcep-extension-for-pce-controller/
>
>
>
> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
>
> Thank you for the work put into this document. I have not had time to review in
> details though :( but I appreciated the detailed description as well as the
> useful time diagrams.
>
> Please find below one blocking DISCUSS point (which may be my bad
> understanding), some non-blocking COMMENT points (but replies would be
> appreciated).
>
> I hope that this helps to improve the document,
>
> Regards,
>
> -éric
>
> == DISCUSS ==
>
> -- Section 7.3.1 --
> LINKLOCAL-IPV6-ID-ADDRESS TLV: I fail to understand why there are two addresses
> in this TLV while others have one one ? Also is 'local' and 'remote' really
> global addresses ?
>
>

Erik Kline had the same comment.

The text and encoding is inspired by RFC 8664
https://www.rfc-editor.org/rfc/rfc8664.html#section-4.3.2

which says -

IPv6 Link-Local Adjacency:
Specified as a pair of (global IPv6 address, interface ID) tuples. It
is used to describe an IPv6 adjacency for a link that uses only
link-local IPv6 addresses. Each global IPv6 address is configured on a
specific router, so together they identify a pair of adjacent routers.
The interface IDs identify the link that the adjacency is formed over.

A reference to RFC8664 and more description can be added.

Thanks!
Dhruv

> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> == COMMENTS ==
>
> A minor comment: the abstract is clear but probably a little too long for an
> abstract.
>
> -- Section 7.3 --
> Just wonder why  LINKLOCAL-IPV6-ID-ADDRES is not mentioned in this section but
> well in the next one ?
>
>
>