[Pce] Shepherd review of draft-ietf-pce-stateful-pce-vendor-06

Dhruv Dhody <dd@dhruvdhody.com> Wed, 28 August 2024 09:40 UTC

Return-Path: <dd@dhruvdhody.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 27B33C1D6FDE for <pce@ietfa.amsl.com>; Wed, 28 Aug 2024 02:40:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.907
X-Spam-Level:
X-Spam-Status: No, score=-1.907 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=dhruvdhody-com.20230601.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tff9IEmsdjZh for <pce@ietfa.amsl.com>; Wed, 28 Aug 2024 02:40:14 -0700 (PDT)
Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 840E2C1D6FAA for <pce@ietf.org>; Wed, 28 Aug 2024 02:40:14 -0700 (PDT)
Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3db18a5835dso88935b6e.1 for <pce@ietf.org>; Wed, 28 Aug 2024 02:40:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dhruvdhody-com.20230601.gappssmtp.com; s=20230601; t=1724838013; x=1725442813; darn=ietf.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=fxpg4eq/wmU3KgAxDSqcZhXP+jclA7BMXahOVF+AjFM=; b=CQEf6Me4IKucsJqxsKWaRMFs9CESpr6Msa2WZ8ZZZ4ocI82q2Fw23yGpQkGx1gGqAq bchZm3BCuSQWgUIhiH3qpqH/OwbM8Yk25Sjcf7xdlhjTgijkgJAIK3K2EjUHgKUu/Bu4 PoKVCp9ja+X6UrEd26Y75f2uOODwXkrlelVWMaR1jrwkTN0b5pRXuyDjDKhGVLgJJLca vGpxhmnN8jN9BuEVwf5MdoHI7QEAXU4gs+VGibpRRdECqZPFZXSVfNMQ21vK5eHwTsXZ 54mOxdAJdEdUA0SQgrfKMQ8WXySdtGk38m7DLnaqPAY5x9UMqyPCabcpDtxv5Nj9n2CW meIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724838013; x=1725442813; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fxpg4eq/wmU3KgAxDSqcZhXP+jclA7BMXahOVF+AjFM=; b=cbaFnzIViUKi0CsPRCIlq8VfDb90BG4zUtrY2t4jyvC7G8dCiXhvQAXwK0TqmfbE7G hkm31SlCLj3h8Ua6O3sKPJAhGPcirjYHCQs1GldzacAkgEVUCey2SdXigFLq/CPAG2CD z359ldbxo0aFVSW1rzTOdUt0Z5Cdd7bA1sFv06mwylDgTcLMTmClJ/IwVTfk5A2jRz2p AiA5bJ/LicmiFmLIStgSzMgrG1t8Ky3ileX8iUmtJZLmkkfr5gzwLbXh5QgH0Df510Cf KkjNwhaac8YRHpczwTuqAVy+q4zBwusThZ9nKdZhpLLcwQszixZ9vhNcbDF37Xz4N1HP y1/w==
X-Gm-Message-State: AOJu0YwKXo+H4avbKmsG5E88qaBKcxL4Twevt5o3BWUZiVnKj4NPy8dj 273Y/DIOk3a7na5qRi+ew5PoQegJ2sH8AsdQWt11vx5iF+i5BIAj1UaSkhYza9pLXS9bz+P8TLL 0V1DmN5+po7uUr74i4zaTwP+iHbZmg1n0V5Y/vw==
X-Google-Smtp-Source: AGHT+IE0WxZ7Q2zUagR+kD10vl6Tp5xpKe3p7402VHPxGatomrmWpDsv5vrEyEhAYkzxTwp0ogUUNYMzQN+6N+494Hs=
X-Received: by 2002:a05:6870:2011:b0:268:99df:437c with SMTP id 586e51a60fabf-273e63cb170mr9832317fac.2.1724838013307; Wed, 28 Aug 2024 02:40:13 -0700 (PDT)
MIME-Version: 1.0
From: Dhruv Dhody <dd@dhruvdhody.com>
Date: Wed, 28 Aug 2024 15:09:36 +0530
Message-ID: <CAP7zK5b6=3V1b6LTLtmoant-_WrBKfMWGHZqeD8-2MsEPkSF-A@mail.gmail.com>
To: draft-ietf-pce-stateful-pce-vendor@ietf.org
Content-Type: multipart/alternative; boundary="0000000000001425e50620bb256e"
Message-ID-Hash: 32IHLHYOCYAYOX5DE74NACNCVEPH6UUP
X-Message-ID-Hash: 32IHLHYOCYAYOX5DE74NACNCVEPH6UUP
X-MailFrom: dd@dhruvdhody.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-pce.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: pce@ietf.org, pce-chairs <pce-chairs@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Pce] Shepherd review of draft-ietf-pce-stateful-pce-vendor-06
List-Id: Path Computation Element <pce.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/DlVAxL2SCNnPsbWhBT_sg6Q4By8>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Owner: <mailto:pce-owner@ietf.org>
List-Post: <mailto:pce@ietf.org>
List-Subscribe: <mailto:pce-join@ietf.org>
List-Unsubscribe: <mailto:pce-leave@ietf.org>

Hi Authors,

I have completed my shepherd review. There are only a few comments and
nits. Please fix them and we would be ready to ship this to our AD.

## Comments

- Introduction, the last paragraph
````
OLD:
This document extends the usage of the Vendor Information Object and
the VENDOR-INFORMATION-TLV to Stateful PCE.  The VENDOR-INFORMATION-
TLV can be carried inside any of the new objects added in PCEP for
Stateful PCE as per [RFC7470], this document extends the stateful
PCEP messages to include the Vendor Information Object as well.
NEW:
The Vendor Information Object and the VENDOR-INFORMATION-TLV are
also valuable in the Stateful PCE model. The VENDOR-INFORMATION-TLV
can be included within any of the new objects introduced in PCEP
for Stateful PCE as defined in [RFC7470]. This document extends
stateful PCEP messages to incorporate the Vendor Information
Object.
END
````

- Add a new section 1.2
````
1.2.  Use of RBNF

   The message formats in this document are illustrated using Routing
   Backus-Naur Form (RBNF) encoding, as specified in [RFC5511].  The use
   of RBNF is illustrative only and may elide certain important details;
   the normative specification of messages is found in the prose
   description.  If there is any divergence between the RBNF and the
   prose, the prose is considered authoritative.
````

- I am unsure about this text in Section 4.6 - "Further, the mechanism
described in this document can help the operator to request control of the
LSPs at a particular PCE." Is it a copy-paste error when you borrowed the
text from a different document?

- I also suggest changing this text "Section 6.6 of [RFC7470] describes
congestion mitigation methods for a PCC for Stateless PCEP messages" to
"Section 6.6 of [RFC7470] highlights how the presence of additional
vendor-specific information in PCEP messages may congest the operations and
how to detect and handle it"

- Section 7, I suggest this text, which we have been using in the recent
RFCs -
````
OLD:
   As stated in [RFC6952], PCEP implementations SHOULD support the TCP-
   AO [RFC5925] and not use TCP MD5 because of TCP MD5's known
   vulnerabilities and weakness.  PCEP also supports Transport Layer
   Security (TLS) [RFC8253] as per the recommendations and best current
   practices in [RFC9325].
NEW:
   As per [RFC8231], it is RECOMMENDED that these PCEP extensions
   only be activated on authenticated and encrypted sessions across PCEs
   and PCCs using Transport Layer Security (TLS) [RFC8253], as per the
   recommendations and best current practices in RFC 9325 [BCP195]
   (unless explicitly set aside in [RFC8253]).
````

## Nits

- s/traffic engineered/traffic-engineered/

- s/stateless Path Computation Element Communication Protocol
(PCEP)/stateless PCE Communication Protocol (PCEP) messages/

- s/with [RFC8231] as base/with [RFC8231] as the base/

- s/update attributes of an LSP/update the attributes of an LSP/

- s/In addition, requirements and considerations/In addition, the
requirements and considerations/

- s/The registrations procedures/The registration procedures/

Thanks!
Dhruv