IETF Logo Mail Archive

Re: [Pce] AD review of draft-ietf-pce-pcep-stateful-pce-gmpls-20

John Scudder <jgs@juniper.net> Mon, 15 May 2023 18:43 UTC

Return-Path: <jgs@juniper.net>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2EF58C1DF990; Mon, 15 May 2023 11:43:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.085
X-Spam-Level:
X-Spam-Status: No, score=-2.085 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b="lpf15UCy"; dkim=pass (1024-bit key) header.d=juniper.net header.b="jIgiysZI"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n5ahNWsAQyNI; Mon, 15 May 2023 11:43:24 -0700 (PDT)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AA98AC1DF98F; Mon, 15 May 2023 11:43:21 -0700 (PDT)
Received: from pps.filterd (m0108163.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34FE5lrp007562; Mon, 15 May 2023 11:43:19 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=PPS1017; bh=gx5rW+3z3W31bYekUtRRWWL0Y9Lmxnf28piQMkC/mNo=; b=lpf15UCy+bcIZDttD8+uT6WgbZm+LiERSZBQ8ZcvHaNl1DDMKFK7skuBFCTYSVPRWqfp av6kFlk0Eo2vx5Cm8YnVsuyHVif/7E6NbUhW9DKAfUrAZipTSG31JngCN4ByMKGncRzf C3aMLnUok6yMKMvW8z7TLctkRV2eWkjf4QxqOw8HmTUHsK8vl28tkcAXMyjGsNx5xqKF LU6tXT8XnuloSOKuhWlUgsNOhGC6IFe/f/LeYpNbEKNvum6qkl+mnWHdvQaCkRzFrvja F5QUMLp6wDn3Fet4wgVNpHLgTJPeDmlZ9tD82VEm8TcB2piPGijRZ3fC0e+6xisdF65W UA==
Received: from cy4pr02cu007.outbound.protection.outlook.com (mail-westcentralusazlp17011014.outbound.protection.outlook.com [40.93.6.14]) by mx0b-00273201.pphosted.com (PPS) with ESMTPS id 3qkp6p8n9d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 May 2023 11:43:18 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UaH++QuooJKS3G2I1pOsUEbJrv3EGJDSyTgQPx09qo6dP1j67HYWhGa0n5CSivq6J7luiOIGFHP77bkvnarZ8vLRgyXrBIyB4z3bMwN8fBD4uyawaBtCP2HNmSQXejTKCwdrDBDIWIMD8ZGcNZuBOSkAmKoiicqB411TUAmKy5N9EY3dJVpKr+AjIvPJk5AKr8YHQhpiySbSYDwpaETMwAKBmc/UX0nAjh6u3swQPruzHxTbBqM6z9ALVVI/+6irL+Jw1rCqXtAlXCjfeE9Hhe83nGtoFiZdyPa65O3Nrr/QLvdimJuvWgzpzsXdSMo0F59h4XzK9LItFmp1U5Rbpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gx5rW+3z3W31bYekUtRRWWL0Y9Lmxnf28piQMkC/mNo=; b=RLDGYrOJhLYYVP7MmCtT7NbFZLvYPU80N9nU3InLpnfS7SgorJcaS3GjPcctnk6XbTqkL5l0HuIP+mLLlCYryYN0dpS4t8iZG6Oq9Pwox2DDRCfqNNcpAXq2Um5IiQo+YOvtF2hDf7eFQNaKNaJn0U9TFBGkToOSLQ/yu/zQOO20Ni5jmrQGWDCRajaQzalr/UrvPIE+y27pKKntV3PIBy8r9t594mOgVnP7qz/MWduBKCJViDWAYdl0pdVH5xHS01hVGGg8I9+J+SRGpkvTEoUKB2T2vVPaRnvc3GM9H2MKENdABWOtkiE9cNAm5hJhFpvhxyDnGxz4yNbYTdk+aQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gx5rW+3z3W31bYekUtRRWWL0Y9Lmxnf28piQMkC/mNo=; b=jIgiysZI2/JMjIkijsh5jKRyu75owojucd6h0HUBtPbdi7/eSsgRHBbJP3ooydT0NKG9ZRwopV464Qd+e88Q7u0h3vPdNMZLMmvP7CaH98LgIUDT7o3jvhZCy9BSxh2d4e5L8d5ILYMNw3DuNs+SbDFSsZ4w1zE2rhckO+Fxx0s=
Received: from MN2PR05MB6109.namprd05.prod.outlook.com (2603:10b6:208:c4::20) by BN8PR05MB6529.namprd05.prod.outlook.com (2603:10b6:408:59::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Mon, 15 May 2023 18:43:12 +0000
Received: from MN2PR05MB6109.namprd05.prod.outlook.com ([fe80::9ab0:387b:409:ee41]) by MN2PR05MB6109.namprd05.prod.outlook.com ([fe80::9ab0:387b:409:ee41%6]) with mapi id 15.20.6387.030; Mon, 15 May 2023 18:43:12 +0000
From: John Scudder <jgs@juniper.net>
To: Zhenghaomian <zhenghaomian=40huawei.com@dmarc.ietf.org>
CC: Dhruv Dhody <dd@dhruvdhody.com>, "draft-ietf-pce-pcep-stateful-pce-gmpls@ietf.org" <draft-ietf-pce-pcep-stateful-pce-gmpls@ietf.org>, pce-chairs <pce-chairs@ietf.org>, "pce@ietf.org" <pce@ietf.org>
Thread-Topic: [Pce] AD review of draft-ietf-pce-pcep-stateful-pce-gmpls-20
Thread-Index: AQHZcu5zvSrdWhyEK0iz3ZDhgbCMwq9G3XmAgA3i7ACABxPxAA==
Date: Mon, 15 May 2023 18:43:12 +0000
Message-ID: <0D519A87-C372-4A73-9041-96E594536952@juniper.net>
References: <06F9BC26-DCD4-4918-8A03-50532127FB36@juniper.net> <CAP7zK5bXMSvrA9QQ+U_aAT_7SX85GnUR1iYqDcd9+aoa2qL46w@mail.gmail.com> <854bade4d7824a49a7c769c1cf8d9770@huawei.com>
In-Reply-To: <854bade4d7824a49a7c769c1cf8d9770@huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.2)
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: MN2PR05MB6109:EE_|BN8PR05MB6529:EE_
x-ms-office365-filtering-correlation-id: a40ed4ac-4714-42f4-87e3-08db55743cb6
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: f98QeYA4IRXIZ0FekS8QSN9LyD1Cjw+maRE70kHLU+/XZn6TL3R2IWKvrcfXt4dGmsvwC9JRBGTGV9/fX2YUp5Wro7YdMngfwmzo2ecsuYe3w2b+NPHGzF736OICkJETfNZ42dFU6/SA4hdUtpLqh9g/RsBYLF3o0soMkgxgDQIAZYEsSWjM0710YKJw9eBh7IzMT0HIsFGwmADHFKiyCA5cVnjVr7UVOnXr/BkIz7Y0gDeCqavvBKfe9wbZF7br5d73gBnXJ75pR6acuwEFmNSoCSkQ06XRylIi7IwqzeVWGglHtG5sGzhLvQvChXm5Rs6RIWYKk1erkRgqxja7cuhWlqJJw/3glnM1XBpU2n0IyvKjE/1Mew6jSilYDes6lWZppctcD0FxqmLcMOgIi54VlhaA8SfU78wx4nTSkFk93vH06jRalOWVJ8gXeAVTRJ+bnQXmGkL4AD3uxvPkeMflq3s6FIOwPD7+KMtcXhixTz1TiWm2N7Zlro5oxOP2qYQa5JdPS7n+03epQIVEkUvvyG3spFhNbmjJ/Gwubv+CRtHRxM1yH+jJY4vfn6N+rZcOESEQBuVEDKUt/O0sUg==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR05MB6109.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(366004)(39860400002)(346002)(376002)(396003)(451199021)(38070700005)(99936003)(38100700002)(86362001)(36756003)(33656002)(122000001)(66899021)(26005)(8936002)(8676002)(5660300002)(478600001)(6512007)(6506007)(6486002)(186003)(316002)(53546011)(54906003)(91956017)(2616005)(2906002)(66446008)(83380400001)(66946007)(64756008)(71200400001)(41300700001)(66476007)(66556008)(76116006)(4326008)(45980500001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: Ku3C4RB6QxtR+4IFcuKKZkjmxpejykq4Neyso/T9/ly8CkODnmv/EupZkPOwDk+GUgEZeXlbFzhINxmL+Qwa1/YI7iBUfIikZfHWXOaE4XMaRjSOLk/LjAtRvGaghVIQuyPa4CoDCF+Hsum5s4o3iFqc+t3ar8VM6J55i5AnF95tf/5droTvocswuBJo5eaINuNEAC4LxOqOla86KCZSNQU996DM2yAz8kwcpM6+PXmnGzSfYSPYeHteENgGOBc8s3o6jqP/mC2uxzMZTWMNyceSvRj8YEJj6BVbxfurt7Z6SOSBsLJV6VWC5sW2V3LUpZLNRUJLSBKDtGH9DdDyonXf88BTn0Awa13d7D5nGFvKl9/cUEp/WhrAG6gihKy4T16STW0DaNdKJxgJe+ppilf8qg0BhNLp+HgIrcUCWwzVBh9BY44ZgNWmBy+oNQhfXBa8hjRJvkqcj8qtQZnL9X7HEaPtOSr32gOHfzNQRjgY+OjqsAIW5RPRy7znmWvno89rq3MQR5tiCtRAMtURBOfqjg7gNV5454hVcp/F8CWfE3kfuVufgNwE/+6RRNAVS1WIpPjy6o4fIyAIwiqpIeJogjxLF3xhCoaKgaKNfRpgnxN/19anB94W91Fpybbxmnhp18kPAdmUfQFQfDV8b83S8vT0P0OjKGlLc8RuRQh7D0U5XpJ7g0DE4OEC3ZI7X/DGbyILymVzsC2hdz6heFrQclgRT1yuexap49M1vkiy9RZJtldpX/mEMRPHvqRUeP6KrSNwDJOS6cFKtXUzjxfIjutXPEe/eA3QQlAjtBHSZRqIYeTuIITtaqLMdA6MZv8p8HTr96ktReCJKnGCM5UCFG2TdFjd8ITqRCRW5XoGkbBt/52SHvmz+TaHBGUTcJQnJmK+upj3DCbr6swxJqIicW8U/VHzNqzpAoOMZXMD8LkCTDuF07MvIkNeRSMsEvJ9OjBiY4NTtK+zMNoTLRV1kERV8bV9803k6wm6dVBDDNW/23OhVcC3xaFMgOzpl8a52HmWvdu8bSzOCrA6UW2knDxXUWzfuQbOj0C/+sD5gcd5v5v9+k+cztogcQaQlwS2KKVf/fhwRtixZGasJWuNIHmLNAUG+PK1rAiwJfgSMvreo5X/9CUdeuCQFkcuDHzBfTKf/0TU2ymFM2jCcBS1BPJNP8+ESjZ3Fk8sHbcNLRkk5kNGMWxfyxMRT3IilDYY4TJ5IyO2qBBJfqRXmyEEWl7CCIqO9zsd0IZ9vUw89V2ZOyO8MG3NnXel8qkXrloVHSLAF+05Dd3ugZhEK8d5IrChFFuxa10wc0dhcWXJnboHNNx8/IAnO5jlJIpkntt1ITI57TNkvVC9D663fAzUbea/6KBCq/Cz3bpAat4W6diXwyPksI7kwoi080tUb45lFQF2j1DG/cBZDgKK/B/imzWClSoEBrImf03hUUF0Fwx41Nwm2dH/6ruVNCHW29cDjno4ZCtTyr4C03PsZFmXt5eQVhFgrN+8mBHo1JwuMfAxmRuEMOGJBMJ/t/6rv406qwKzZlg0/81d4eVTF9xuLuEImcs2kN8yjisNdPVj/kanaOVgfHo80DT0pJAd
Content-Type: multipart/mixed; boundary="_003_0D519A87C3724A73904196E594536952junipernet_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR05MB6109.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a40ed4ac-4714-42f4-87e3-08db55743cb6
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2023 18:43:12.5807 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Xt5mpQyxZTpp7qeSKwFT/J5cggp2wyznpr1QrmvlKosqTv4C2Hndv+WRGLCMYv+J
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR05MB6529
X-Proofpoint-GUID: bA7Hb6MMGUA43gVeSgz9Pa1ebWl_2JQX
X-Proofpoint-ORIG-GUID: bA7Hb6MMGUA43gVeSgz9Pa1ebWl_2JQX
X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-15_17,2023-05-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 lowpriorityscore=0 clxscore=1011 impostorscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305150158
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/E_3jEx7uy4Kmi1n46bVx3HL9AJs>
Subject: Re: [Pce] AD review of draft-ietf-pce-pcep-stateful-pce-gmpls-20
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 May 2023 18:43:29 -0000

Hi Haomian,

(And adding WG list back to the cc)

> On May 11, 2023, at 2:38 AM, Zhenghaomian <zhenghaomian=40huawei.com@dmarc.ietf.org> wrote:
> 
> Thank you for the comments and offering the help.
> I have just posted the work to -21 with comments addressed. Please check:)

Thanks for the update, looks good to me. I will request IETF Last Call. I do have two small nits in version 21, below, you can pick these up in your next revision.

—John

--- draft-ietf-pce-pcep-stateful-pce-gmpls-21.txt	2023-05-15 14:17:16.000000000 -0400
+++ draft-ietf-pce-pcep-stateful-pce-gmpls-21-jgs-comments.txt	2023-05-15 14:34:34.000000000 -0400
@@ -239,7 +239,13 @@
    used to trigger the end node to set up the LSP.  Any modifications to
    the Objects/TLVs that are identified in this document to support
    GMPLS technology-specific attributes will be carried in the
-   PCInitiate messages.
+   PCInitiate message.
+---
+jgs: I proposed changing "PCInitiate messages" to "PCInitiate message", 
+singular. If you really mean messages, plural, then you should remove
+the definite article, i.e. it should say "... carried in PCInitiate
+messages" (no "the").
+---
 
    [RFC8779] defines GMPLS-technology specific Objects/TLVs in stateless
    PCEP, and this document makes use of these Objects/TLVs without
@@ -755,6 +761,9 @@
 9.  IANA Considerations
 
 9.1.  title=New Flags in GMPLS-CAPABILITY TLV
+---
+jgs: Looks like a small bug in your XML above
+---
 
    [RFC8779] defines the GMPLS-CAPABILITY TLV; per that RFC, IANA
    created a registry to manage the value of the GMPLS-CAPABILITY TLV's

v2.27.6 | Report a Bug | By Email | System Status