[Pce] Chair review of draft-ietf-pce-stateful-path-protection

Dhruv Dhody <dhruv.ietf@gmail.com> Thu, 16 May 2019 11:12 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B2C0A120173; Thu, 16 May 2019 04:12:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wabwBpy7vRfo; Thu, 16 May 2019 04:12:02 -0700 (PDT)
Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2D9B112017F; Thu, 16 May 2019 04:12:02 -0700 (PDT)
Received: by mail-io1-xd33.google.com with SMTP id x24so2238171ion.5; Thu, 16 May 2019 04:12:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=XaXPU/SDZ6YwgigRUptyXnhaqYQbtx+xh6cqQmg/3EA=; b=liLrzEbwCUARqc9Xj5kVxfD5SfFIUhUcg7PptcXkTZofFygMJPmTyzSX+PlPUfbqah F8VdhECdsFZzEaGTSJA+mUVjGrnzXrTIJQXUyoJiCW9Yd2UbJOeWjVAOahvYQjJ94Gz4 GMqI5NRwf7VtHiVT9eRg0gd60YlPa1wN+xBBj40e1yByZeGn8OmJf5CpLqnqdkox9vAE YHHrOYQAW7dtBEq8Iy2Scrb3J5IbqAQCe959sol/kN+HCkk5dHTCYvo4V+CHaaEgXDk9 AzYRSTmbkV+eKW1dM2ZkMHOuWE6+Hn1YjMU9nw83o7oByLd8RoZkN6Zo8GiDPdtxQfhe YDcg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=XaXPU/SDZ6YwgigRUptyXnhaqYQbtx+xh6cqQmg/3EA=; b=eRRBsObeM7qaP42HAAO0ArAH7LTsMV2GW7TTBBpIcRqV/gVIiaSmRV2cSlkOhkPL6S 2pBKkQJRGftbzW0J9CPoKyQVeVb45SG0gJHz5/6ca1O78oGyyid+VRhCZvSjGNK6wlDt 2Qq3TFTi3Ssbp48lmjQhXxJHy7QdfQaN+xTaP5nh39aLF+YCp31MPndqXj6yU2OyAD1E j/s4x/oZJxB+vZjkD9OzQBUbzpDZYGhXnpICo1dM/xcOAEuR9cfP8qcc9Pm4BwBuaoBD tYeLAYGlxaxkR1Xz0YY3BRT4RoMpYxJkcHFXblpC4L0wjaEidCE3XHyFUeztMM2OewzA uPeg==
X-Gm-Message-State: APjAAAWBiH4EpiwnDS0V8fGs4RFOiHaro9P8oP0svnjjYo9WcGUJ0wiq y3KmTza9OoyEV8eldcPM83On38/x+tS7q4D2UgFOfIXQ
X-Google-Smtp-Source: APXvYqyp2F8LH/8rbv6AmRhdjuNuSOk0c29xqrrCa6lzae6yAlkoGnsyb6o3hLNT392T+kySdCECqp9QbqLkfN8r0yY=
X-Received: by 2002:a05:6602:204a:: with SMTP id z10mr25879606iod.158.1558005121042; Thu, 16 May 2019 04:12:01 -0700 (PDT)
MIME-Version: 1.0
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Thu, 16 May 2019 16:41:24 +0530
Message-ID: <CAB75xn5ivwsfBsoswKNXd7gwDHtBSV3L=4EAFqfS1YK1quzCyA@mail.gmail.com>
To: draft-ietf-pce-stateful-path-protection@ietf.org
Cc: pce@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/H-O3gsov4QuB9hknFOTPLsAcjIo>
Subject: [Pce] Chair review of draft-ietf-pce-stateful-path-protection
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 May 2019 11:12:04 -0000

Hi Authors,

I did a chair's review of the I-D. Expect a separate shepherd review from
Julien. I found minor issues that can be easily fixed.

(1) The issue with number of authors on the front page is bound to come up,
either provide valid justification to your shepherd or reduce to 5.

(2) Add reference to RFC8051 in introduction, which had a section on
protection.

(3) It would be good to explicitly state that in PCE-initiated LSPs case, the
association group is created by PCE.

(4) Section 4.1.

OLD:
   During state synchronization, a PCC MUST report all the existing path
   protection association groups as well as any path protection flags to
   PCE(s) as per [I-D.ietf-pce-association-group].
NEW:
   During state synchronization, a PCC report all the existing LSP state as
   described in [RFC8231], the the association group membership pertaining to
   a LSP is also reported as per [I-D.ietf-pce-association-group]. This
   includes PPAG.
END

Nits
----
s/Path Computation Element Protocol (PCEP)/Path Computation Element
 communication Protocol (PCEP)/
s/between one a pair of PCEs/between a pair of PCEs/
s/Stateful pce/Stateful PCE/
s/Path Protection Association Object Type/Path Protection Association Type/
s/[A|a]ssociation-type/Association type/
Section 4.4, extra "." at the end.
Section 4.5, closing braces missing, end of 2nd paragraph.
Expand on 1st use - PCRpt, PCUpd, PCInitiate...

Regards,
Dhruv