[Pce] Rtgdir early review of draft-ietf-pce-stateful-pce-lsp-scheduling-12
Carlos Pignataro via Datatracker <noreply@ietf.org> Mon, 23 March 2020 03:18 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: pce@ietf.org
Delivered-To: pce@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 196E93A00E2; Sun, 22 Mar 2020 20:18:47 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Carlos Pignataro via Datatracker <noreply@ietf.org>
To: rtg-dir@ietf.org
Cc: pce@ietf.org, draft-ietf-pce-stateful-pce-lsp-scheduling.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.122.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <158493352697.31725.4511309706970342279@ietfa.amsl.com>
Reply-To: Carlos Pignataro <cpignata@cisco.com>
Date: Sun, 22 Mar 2020 20:18:47 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/It6wO65mYlKgeu49IUrbndwzCUQ>
Subject: [Pce] Rtgdir early review of draft-ietf-pce-stateful-pce-lsp-scheduling-12
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Mar 2020 03:18:47 -0000
Reviewer: Carlos Pignataro Review result: Has Nits Hello, I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft. Document: draft-ietf-pce-stateful-pce-lsp-scheduling Reviewer: Carlos Pignataro Intended Status: Proposed Standard Summary: This is a well written document, which displays iterations that improved its quality. I have no concerns with this document. I would point out a small set of questions and potential issues for the author's consideration: 5.2.1. SCHED-LSP-ATTRIBUTE TLV Can Start-Time and Duration take any value from 0 to 32-bits-of-ones? 9. Manageability Consideration Could these add Default values or ranges (esp. to times, seconds, etc.)? 10. IANA Considerations 10.1. PCEP TLV Type Indicators For the SCHED-LSP-ATTRIBUTE and SCHED-PD-LSP-ATTRIBUTE, I suggest creating Registries for the Flags: | Flags |R|C|A| What is the future's allocation policy for remaining Flags for example? Actually reading later Section 10.3 I realize they are specified there. Why are the Flags in a different section, but Opt in this section? Anyway, a nit. IANA is requested to create and maintain a new registry "Opt" under SCHED-PD-LSP-ATTRIBUTE (TLV Type: TBD2). Initial values for the registry are given below. What is the allocation policy for Unassigned? Value Name Definition ----- ---- ---------- 0 Reserved 1 REPEAT-EVERY-DAY Section 5.2.2 2 REPEAT-EVERY-WEEK Section 5.2.2 3 REPEAT-EVERY-MONTH Section 5.2.2 4 REPEAT-EVERY-YEAR Section 5.2.2 5 REPEAT-EVERY-REPEAT-TIME-LENGTH Section 5.2.2 6-14 Unassigned 15 Reserved What is the reason for "Section 5.2.2"? Since this are instructions for IANA, these references are not significant without the document reference. Appendix A. Contributor Addresses There are more than one Contributors -- why singular? I hope these help, Carlos Pignataro.
- [Pce] Rtgdir early review of draft-ietf-pce-state… Carlos Pignataro via Datatracker
- Re: [Pce] Rtgdir early review of draft-ietf-pce-s… Huaimo Chen
- Re: [Pce] Rtgdir early review of draft-ietf-pce-s… Carlos Pignataro (cpignata)
- Re: [Pce] Rtgdir early review of draft-ietf-pce-s… Huaimo Chen