Re: [Pce] cursory review of draft-xiong-pce-lsp-flag
Dhruv Dhody <dd@dhruvdhody.com> Wed, 29 July 2020 09:01 UTC
Return-Path: <dd@dhruvdhody.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 865203A0A02 for <pce@ietfa.amsl.com>; Wed, 29 Jul 2020 02:01:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=dhruvdhody-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tWGSUJU6qFEE for <pce@ietfa.amsl.com>; Wed, 29 Jul 2020 02:01:29 -0700 (PDT)
Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A6EB33A0AB0 for <pce@ietf.org>; Wed, 29 Jul 2020 02:01:29 -0700 (PDT)
Received: by mail-pg1-x542.google.com with SMTP id h12so2551946pgf.7 for <pce@ietf.org>; Wed, 29 Jul 2020 02:01:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dhruvdhody-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8GPWaM7ZK8FBNonlBhpyyxhHHn7F65adwSkjRD5rkBU=; b=lN9y+I+G8t17f7tjb27HxYVb/T7qcs/ll7uzm59TmLSRsdPLeSOjowgER9Mbh3sky9 bIl0cjIQetW+SJt6gx6w/kSvMt29dWR00pJEVoXWyEoVhsV7SAzffjdiIZBocoN2q1lq p6RUrswE/du3mr+rpjwo3H6mr7O4asHlUSU7/zs2I8uUI6SPOHIc1BWMWzcenGApZJ26 OMcTeB2WGTJwrTqiBkCTWcpMZ9AK51DtqYR0sABSAj6o508xBqG/vpsyS+JhayGhPIZI J/49gvE8kXyn28xm73KEfh406M39n1YmAlGqC37dMY9mopRHQbj2aFXDXRcgTT/u+PCQ STbQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8GPWaM7ZK8FBNonlBhpyyxhHHn7F65adwSkjRD5rkBU=; b=aFHjA8PIa4Q22ztFYKinOWi2PmFAQb0mgQOTKb7WBkmg20hM8RnQQLg1SA+GBNPb6p 1LdinhsEAB006dVJ0T3sA40koHcxfsH0oYYt3emG7KRsUHCQ2m5H6s76R5u+CscRaFug +KF71PSpX3/UsgmCC5u+vAIZU24vSuoTkH5jwPBKlbNv7S4XTcsXX/z5cRDJiHfMRJAQ mBRbgqwjjo5AnhpcKcYJxT8p6SnQvBn7xBb0BAzktn5fBzaSGO8WSFfKweSYSp6+2Jon RSqdIQ5niXbdRokFrnPvaLB8oWUOipAF2a5FhuLXKsTy5xLpXo0jrvlNlcWOhmFqczhm L1Tw==
X-Gm-Message-State: AOAM531LDIcObQnxuqefZraJJnuJAvvEuJRBvT2t3it9W/mz355uNslb lgNymU1gh7CQ/l4MagI4tHQgo5PmXhyHuP8c96mqBEYXR4PlBQ==
X-Google-Smtp-Source: ABdhPJyXGOYfzsubKMKBPMHPwfy4Cbvf2MVf5sfocKEYIlU/cfy017Ok4s6M5tpclXbXBi2vspE4UNtZCKgT1+TIijQ=
X-Received: by 2002:a63:920b:: with SMTP id o11mr29378187pgd.447.1596013288889; Wed, 29 Jul 2020 02:01:28 -0700 (PDT)
MIME-Version: 1.0
References: <138eecce-8db7-90da-d6e8-b006ee4ddc8e@pi.nu>
In-Reply-To: <138eecce-8db7-90da-d6e8-b006ee4ddc8e@pi.nu>
From: Dhruv Dhody <dd@dhruvdhody.com>
Date: Wed, 29 Jul 2020 14:31:17 +0530
Message-ID: <CAP7zK5Ydyv+8QZYyp3kBiYy1Nz59uTRV=qhmMisavPn7JuYpOg@mail.gmail.com>
To: Loa Andersson <loa@pi.nu>
Cc: draft-xiong-pce-lsp-flag@ietf.org, "pce-chairs@ietf.org" <pce-chairs@ietf.org>, "pce@ietf.org" <pce@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/J5wPOanc7U1VQZrij0SZZDecWtI>
Subject: Re: [Pce] cursory review of draft-xiong-pce-lsp-flag
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jul 2020 09:01:32 -0000
Hi Loa, > Comment: > > 5.2. PCEP-Error Object > > IANA is requested to register the following error types and error > values within the "PCEP-ERROR Object Error Types and Values" > subregistry of the "Path Computation Element Protocol (PCEP) Numbers" > registry: > > +--------------+-------------------------------------+ > | Error-Type | Meaning | > +--------------+-------------------------------------+ > | 6 | Mandatory Object missing | > | | Error-value | > | | TBD2: LSP-EXTENDED-FLAG TLV missing | > +--------------+-------------------------------------+ > > Table 2 > > Both the RTG DIR rules and IANA rules strongly advice against putting > fixed numeric values into allocation from existing registries. The > reason is obvious, in the time from you put the value in your document > until iet is ready for IESG review (which includes IANA review) someone > else might have been assigned tht value. This has happened and have > caused serious problems. > > 6 in table 2 hould be replaced with TBA (to be assigned). > > Note: If you really want the value 6, we should go for an early > allocation as soon as we have the wg document. > [Dhruv] The value 6 is for Error-Type already allocated by RFC 5440. This I-D is asking for a new Error-Value which is TBD2. A reference column in the IANA table would have helped here. > Question: > > In section 4 you say: > > The LSP-EXTENDED-FLAG TLV MUST be defined as mandatory when a router > supporting the LSP Object and needs to use the extended flag field. > > I don't really parse; are you saying that if it is present it should be > treated as mandatory? > > If that is what you are saying, what does it change? > [Dhruv]: I read it as a requirement for a future extension that would define a flag in the LSP-EXTENDED-FLAG TLV. If that is true, I would suggest not using normative MUST. How about - A future extension that defines a flag in the LSP-EXTENDED-FLAG TLV could mark this TLV as mandatory to be carried the LSP Object. Thanks! Dhruv > /Loa > > > -- > > Loa Andersson email: loa@pi.nu > Senior MPLS Expert loa.pi.nu@gmail.com > Bronze Dragon Consulting phone: +46 739 81 21 64
- [Pce] cursory review of draft-xiong-pce-lsp-flag Loa Andersson
- Re: [Pce] cursory review of draft-xiong-pce-lsp-f… Dhruv Dhody
- Re: [Pce] cursory review of draft-xiong-pce-lsp-f… Loa Andersson
- Re: [Pce] cursory review of draft-xiong-pce-lsp-f… Dhruv Dhody
- [Pce] 答复: cursory review of draft-xiong-pce-lsp-f… xiong.quan
- Re: [Pce] cursory review of draft-xiong-pce-lsp-f… Dhruv Dhody
- [Pce] 答复: cursory review of draft-xiong-pce-lsp-f… xiong.quan