Re: [Pce] RtgDir: Early Review of draft-ietf-pce-pcep-flowspec-05.txt - "PCEP Extension for Flow Specification"

"Acee Lindem (acee)" <acee@cisco.com> Tue, 22 October 2019 18:25 UTC

Return-Path: <acee@cisco.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 63662120939; Tue, 22 Oct 2019 11:25:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=hIWWH4MT; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=jlPcv4hL
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l3OSvDz6Ax5R; Tue, 22 Oct 2019 11:25:31 -0700 (PDT)
Received: from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2247A120959; Tue, 22 Oct 2019 11:25:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3880; q=dns/txt; s=iport; t=1571768731; x=1572978331; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=JnbfVw+AeONQUhRNpmfo02S1yrYQ/DGKZjFCLz+lA+M=; b=hIWWH4MTIjYpEz68+57q5U7Ibx9jIEWAr7QDxmOfvJjgJjz6gmqviWrG +hHePyGBhu3SzpmFqFUknQU5gHqWN/7G+DuhFNUW16LI8k1wGFCqOiDF6 vn8D1fjpLze77TBPUIv1Uar/l1weIg3xfP7vfMLLTD0iTEDib70aGYV50 g=;
IronPort-PHdr: =?us-ascii?q?9a23=3A1lM6SxDwkxVe3g6t2VWtUyQJPHJ1sqjoPgMT9p?= =?us-ascii?q?ssgq5PdaLm5Zn5IUjD/qgw3kTRU9Dd7PRJw6rNvqbsVHZIwK7JsWtKMdRXUg?= =?us-ascii?q?Mdz8AfngguGsmAXETwIfPCZC0hF8MEX1hgrDm2?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CRBQBUSa9d/49dJa1ZDBwBAQEBAQc?= =?us-ascii?q?BAREBBAQBAYF7gUtQBYFDIAQLKoQmg0cDiliCXJgDglIDVAkBAQEMAQEtAgE?= =?us-ascii?q?BhEACF4MTJDgTAgMJAQEEAQEBAgEFBG2FNwyFTAEBAwESCwYRDAEBNwEPAgE?= =?us-ascii?q?GAhoCHwcCAgIwFRACBAENBSKDAIJHAw4gAQKWMZBiAoE4iGF1gTKCfgEBBYU?= =?us-ascii?q?JGIIXCYEOKIwPGIF/gREnH4JMPoQFAYNPMoIsj3iObI5+CoIki2iJPhuZTo4?= =?us-ascii?q?2mUcCBAIEBQIOAQEFgWkigVhwFTsqAYJBUBAUgwY4gzuKU3SBKY58AQE?=
X-IronPort-AV: E=Sophos;i="5.68,217,1569283200"; d="scan'208";a="648238033"
Received: from rcdn-core-7.cisco.com ([173.37.93.143]) by rcdn-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 22 Oct 2019 18:25:06 +0000
Received: from XCH-ALN-008.cisco.com (xch-aln-008.cisco.com [173.36.7.18]) by rcdn-core-7.cisco.com (8.15.2/8.15.2) with ESMTPS id x9MIP1VH025259 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 22 Oct 2019 18:25:05 GMT
Received: from xhs-aln-001.cisco.com (173.37.135.118) by XCH-ALN-008.cisco.com (173.36.7.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 22 Oct 2019 13:25:04 -0500
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 22 Oct 2019 13:24:49 -0500
Received: from NAM05-BY2-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 22 Oct 2019 13:24:49 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kgXmDf2YCXyFMKoj6MGJbZwGkW8GGdJMFiCQQAZT83MmvEeitsHhJ8hS2/ugbMOef9re4S8zrajp/406hDbiphjTy5lMYDEogAO9Yy9vsCzGrufZVddgrlElTxBtHYy/95dpuc85lzlbxkQAyBTCUnUYW0CbPpz45L5lFZSrKY3AePkUNDXUylYmXkjB0Bs3yvaoSBJvlq93w0HJnoHdCwRrAiRo9d85WHLV2OMXkuAlL5neIPceerkSw8mBN2JJwuQmN53AXXucPFg/7ElFYPoAZvCQHiMTX/OeEMLTDtPZfCmfpoNj/r9U0X2LoGJlxBzFIOXqdV4JTYnu9k0P2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JnbfVw+AeONQUhRNpmfo02S1yrYQ/DGKZjFCLz+lA+M=; b=gwGvmuQNGxio52XAUae0RwOUDNOuLzQFcEnCzn2+ifrOMxszcyef89nsUY81/+NUiSC3fbrwpqq4WTJbP46/vT97ldWWIUDr2uJBC9+tk/u3ydY5vxoUeY52vcqSCCT1lz5GQ9JcvF415Rhy+NgmvZSVlEtBDpJZNQmrzsvvfewEIBrvkc+1iiCR7aiIneLrJL1S9UhzeQH8qc3Yo6vGXA88iGqXXpXNeuvvUpW/MwwZiseUAfu2eUHKgTAjrtSph7wmKUs23nyVeg4POhXUYrHAdOKpVLjN3gJvw5FMYVgSy4x3i6R7qMqCrpabzH/TK+6h0xbaA6be1hsuMqHfjw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JnbfVw+AeONQUhRNpmfo02S1yrYQ/DGKZjFCLz+lA+M=; b=jlPcv4hLwMF+Trsxwg/+6CRykNlxg3SZtIPw8M3zfjZt3QrGBhahEswihg7+tz/HS4UriRQYMGVFu+x64X4ETc9++NGYsXBLU+df0LKTH3H6q/IvuxOJbwL3KBjp0NjED1zQ8PHXxFSRjF/4KzvG3s10vyGe22oMW9ERkU/atrs=
Received: from MN2PR11MB4221.namprd11.prod.outlook.com (52.135.38.14) by MN2PR11MB3856.namprd11.prod.outlook.com (20.178.251.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.19; Tue, 22 Oct 2019 18:24:48 +0000
Received: from MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::787e:8cf4:6217:9f56]) by MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::787e:8cf4:6217:9f56%4]) with mapi id 15.20.2347.029; Tue, 22 Oct 2019 18:24:48 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: "adrian@olddog.co.uk" <adrian@olddog.co.uk>, "'Routing ADs'" <rtg-ads@tools.ietf.org>, "draft-ietf-pce-pcep-flowspec@ietf.org" <draft-ietf-pce-pcep-flowspec@ietf.org>
CC: "pce@ietf.org" <pce@ietf.org>, "'Routing Directorate'" <rtg-dir@ietf.org>
Thread-Topic: RtgDir: Early Review of draft-ietf-pce-pcep-flowspec-05.txt - "PCEP Extension for Flow Specification"
Thread-Index: AQHViP4MtH6x+n2/sU2hLmfZzonfOqdm9LQA///COAA=
Date: Tue, 22 Oct 2019 18:24:48 +0000
Message-ID: <F5BC2656-EC1D-4C73-8A0C-0AEDA8A24D87@cisco.com>
References: <2B1BFBB7-702E-4E0F-BE3E-1A46D6FA7A15@cisco.com> <03f701d58903$597d78c0$0c786a40$@olddog.co.uk>
In-Reply-To: <03f701d58903$597d78c0$0c786a40$@olddog.co.uk>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=acee@cisco.com;
x-originating-ip: [2001:420:c0c4:1008::334]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 76401821-4d81-413d-36be-08d7571d1f08
x-ms-traffictypediagnostic: MN2PR11MB3856:
x-microsoft-antispam-prvs: <MN2PR11MB385602AD334126DA60BCB96AC2680@MN2PR11MB3856.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 01986AE76B
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(189003)(199004)(51914003)(2616005)(229853002)(476003)(6486002)(6512007)(64756008)(66556008)(46003)(486006)(11346002)(76176011)(6506007)(76116006)(102836004)(36756003)(99286004)(2501003)(66446008)(446003)(6436002)(91956017)(66476007)(66946007)(186003)(5660300002)(6246003)(5024004)(14444005)(256004)(6116002)(71200400001)(25786009)(71190400001)(33656002)(7736002)(478600001)(2906002)(8676002)(305945005)(14454004)(86362001)(81156014)(54906003)(8936002)(110136005)(4326008)(316002)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3856; H:MN2PR11MB4221.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 7r3ilfJvKh+0zXgEzUwJuDn11XseSp06dZR9po1QfmK6Gzf3tYkpnoOfileIlBoitiUkDoBeQ81tJa97qjlbrU9aTRNdso5ZU7254sZNlUeIHbbQI+bw1BV3bAFstZZnu9vSYeDDleFjSx4dpyHKcZy2RXN8Yi/gsjBuuZY0whLQ3jrMcN37p7JN1tm3RdaCqv+WBLXc787B7QekHNqe9bN6yqA07VfnOItkvpak6eym2ZHljBLq1dvewpYwZYipN8gfoK7hvGZvYdiDw8HMWspM6TfEqZnI3etfl4rdjvkKi2r3QvCkTp2isGjYWfpYF9bABWgpb2zXMVfNDBklmJaAgVR+mGQ72dTOJkv0JHiBIur8ZpdpTC4uzkD7FHbP/eZTn0xghs5xKoB1DTLpcU9fUfItJH0nQkhYnOlILLXCDNTNZIjL2Dj9ymjhjqMF
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <26DE49AD55818C4D9919596A60232C2A@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 76401821-4d81-413d-36be-08d7571d1f08
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2019 18:24:48.1355 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Lc5R/rqQGrVpILN/bM/yEg3V/J2fxrjXVIL7+/kMoFHPQEz/QNOKPvYYe9v5F1Az
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3856
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.18, xch-aln-008.cisco.com
X-Outbound-Node: rcdn-core-7.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/UHl9PQo7O_C2MlbQqRi4MOzjX3E>
Subject: Re: [Pce] RtgDir: Early Review of draft-ietf-pce-pcep-flowspec-05.txt - "PCEP Extension for Flow Specification"
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 18:25:33 -0000

Hi Adrian,

On 10/22/19, 2:06 PM, "Adrian Farrel" <adrian@olddog.co.uk> wrote:

    Hi Acee,
    
    Thanks for the review and the kind words.
    I believe this document is in WG last call at the moment, so this is not quite so early as an “Early Review” might normally be.
    
    >  I have a question and a few suggestions:
    >
    >    1. For the multicast flow filter TLVs, is there some reason why
    >       the S-bit and G-bit respectively indicate that the fields are
    >       NOT used? In most protocol encodings, a Set bit indicates that
    >       a field is used and a Clear bit indicates that it is not used.
    >       Also, all zeros has also been used a wildcard specification
    >       but I guess you preferred something explicit.
    
    No particular reason for the bit settings that I can remember. It makes the bits fit nicely with the "Reserved" field, but that is not a very telling point. We could change this if there is a good reason to do so.
    
    IIRC the setting of all zeros has a specific meaning in this case and so a different wildcard value was needed.

I'm fine with it - especially if the document is already in Working Group Last Call (WGLC) and the WG is used to this encoding. I wouldn't have put it in the Nits if I really thought it were important. 
    
    >    2. For IGPs, we always hyphenate Bit definitions. However, in this
    >       specification, the Bit definitions are not hyphenated other
    >       than in the IANA section. Being the LSR chair, I'd prefer
    >       consistency with the IGP specifications.
    
    I just checked back with RFC 5440 (the PCEP base specification) and there hyphenation is not used.
    
    I have no strong opinion and will let the PCE chairs tell me what to do.

It is probably more important to be aligned with the base specification. There was one instance of R-bit in the IANA specifications that could be changed to be consistent. 
    
    >    3. In most IETF specifications, "headend" is a single compound
    >       word. 
    
    Oooh, I hate that 😊
    Can we leave it to the RPC to fix as a matter of house style?

I don't have that strong an opinion. At least "head end" is used consistently. 
    
    >    4. In section 9, could you indicate that the only change is adding
    >       the <flowspec-list>? This seems to be the case but it would be
    >       good to state it explicitly.
    
    In my working copy.
    
    >   5. I have attached an RFCDIFF of suggested editorial changes.
    
    That was unusually thorough of you. Thanks! All of those nits were spot on and are in my working copy (modulo one s/am/an/).

Thanks - this was an unusually easy Routing Directorate review!
Acee
    
    Best,
    Adrian