Re: [Pce] WGLC for draft-ietf-pce-association-policy

"Pengshuping (Peng Shuping)" <pengshuping@huawei.com> Mon, 21 September 2020 08:03 UTC

Return-Path: <pengshuping@huawei.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A5F7B3A09E7; Mon, 21 Sep 2020 01:03:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TLRzaBINsiV1; Mon, 21 Sep 2020 01:03:44 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 15EE73A09E1; Mon, 21 Sep 2020 01:03:44 -0700 (PDT)
Received: from lhreml726-chm.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id CD2EB5364E710C7A3110; Mon, 21 Sep 2020 09:03:40 +0100 (IST)
Received: from lhreml726-chm.china.huawei.com (10.201.108.77) by lhreml726-chm.china.huawei.com (10.201.108.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 21 Sep 2020 09:03:40 +0100
Received: from DGGEML404-HUB.china.huawei.com (10.3.17.39) by lhreml726-chm.china.huawei.com (10.201.108.77) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.1.1913.5 via Frontend Transport; Mon, 21 Sep 2020 09:03:40 +0100
Received: from DGGEML532-MBX.china.huawei.com ([169.254.8.242]) by DGGEML404-HUB.china.huawei.com ([fe80::b177:a243:7a69:5ab8%31]) with mapi id 14.03.0487.000; Mon, 21 Sep 2020 16:03:35 +0800
From: "Pengshuping (Peng Shuping)" <pengshuping@huawei.com>
To: Dhruv Dhody <dd@dhruvdhody.com>, "pce@ietf.org" <pce@ietf.org>
CC: "draft-ietf-pce-association-policy@ietf.org" <draft-ietf-pce-association-policy@ietf.org>, pce-chairs <pce-chairs@ietf.org>
Thread-Topic: [Pce] WGLC for draft-ietf-pce-association-policy
Thread-Index: AQHWgnpComOj7fJafEyjBgQD5acE1KlyzXFA
Date: Mon, 21 Sep 2020 08:03:35 +0000
Message-ID: <4278D47A901B3041A737953BAA078ADE193E3CDC@DGGEML532-MBX.china.huawei.com>
References: <CAP7zK5YoAAwu4hshZpzQpam3urNQUHwrZLm3Urw0q6-g+PDGdQ@mail.gmail.com>
In-Reply-To: <CAP7zK5YoAAwu4hshZpzQpam3urNQUHwrZLm3Urw0q6-g+PDGdQ@mail.gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.153.195.37]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/VIdDlsUzvjCKkV5FU7bWmgA4b2E>
Subject: Re: [Pce] WGLC for draft-ietf-pce-association-policy
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Sep 2020 08:03:47 -0000

Hi,

I have read this draft, and I support this document being published as an RFC.

Just a few nits are found and listed as below.

1. "may instantiate LSPs and specifies" -> "...specify"
2. "[RFC8697] specify" -> "... specifies"
3. "Error- Value 4" -> "Error-Value 4"
4. " In some cases to apply a PCE policy successfully, it is required to also associate some policy parameters that needs to be evaluated, to successfully apply the said policy. " 
-> " In some cases to apply a PCE policy successfully, it is required to also associate some policy parameters that need to be evaluated. "
5. "The TLV could include one or more policy related parameter" -> "... parameters"
6. "a 4-bytes alignment" -> "4-byte"
7. "The PCEP peer implementation need to be aware" 
->" The PCEP peer implementation needs to be aware"
8. "Further, if one or more parameters received in the POLICY-PARAMETERS-TLV received by the PCEP speaker "
-> "Further, if one or more parameters in the POLICY-PARAMETERS-TLV received by the PCEP speaker "
9. " IANA is requested to confirm the early-allocated codepoints "
-> " IANA is requested to confirm the early-allocated code point" 
10. "in which case the an operator MUST "
-> " in which case the operator MUST "
11. "This module supports associations as defined in [RFC8697] and thus support the Policy Association groups "
-> "This module supports associations as defined in [RFC8697] and thus supports the Policy Association groups "
12. " this document borrow some of " -> " this document borrowed some of "

Best regards,
Shuping


> -----Original Message-----
> From: Pce [mailto:pce-bounces@ietf.org] On Behalf Of Dhruv Dhody
> Sent: Friday, September 4, 2020 1:13 PM
> To: pce@ietf.org
> Cc: draft-ietf-pce-association-policy@ietf.org; pce-chairs
> <pce-chairs@ietf.org>
> Subject: [Pce] WGLC for draft-ietf-pce-association-policy
> 
> Hi WG,
> 
> This email starts a working group last call for
> draft-ietf-pce-association-policy [1].  Please indicate your support or
> concern for this draft. If you are opposed to the progression of the draft to
> RFC, please articulate your concern. If you support it, please indicate that
> you have read the latest version and it is ready for publication in your
> opinion. As always, review comments and nits are most welcome.
> 
> The WG LC will end on 21st September 2020.
> 
> Thanks,
> Dhruv & Julien
> [1] https://datatracker.ietf.org/doc/draft-ietf-pce-association-policy/
> 
> _______________________________________________
> Pce mailing list
> Pce@ietf.org
> https://www.ietf.org/mailman/listinfo/pce