Re: [Pce] Shepherd Review of draft-ietf-pce-association-policy-12

Hariharan Ananthakrishnan <hari@netflix.com> Wed, 07 October 2020 15:49 UTC

Return-Path: <hari@netflix.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C3BBD3A0ABB for <pce@ietfa.amsl.com>; Wed, 7 Oct 2020 08:49:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.298
X-Spam-Level:
X-Spam-Status: No, score=-3.298 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=netflix.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jwxBnSoBsIAd for <pce@ietfa.amsl.com>; Wed, 7 Oct 2020 08:49:02 -0700 (PDT)
Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 48BB33A0AEB for <pce@ietf.org>; Wed, 7 Oct 2020 08:49:02 -0700 (PDT)
Received: by mail-il1-x12c.google.com with SMTP id j13so2719138ilc.4 for <pce@ietf.org>; Wed, 07 Oct 2020 08:49:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jQLmU7zd6VwXt+RfsbeLOkVSpCMBG+o8aUkp7uzq6sg=; b=FwwXttamoSYWiVRTlAz3Gt9YsZwW34ALZF2dyhEbhcEAMaYmumoSkEjcd1+bxkboc9 JwEA442/fKnlOOoSJp6supzfJYbda+oqOWfdSJe+HPXFeXLiSLZt8enR4XIltfjWzWwL jjhBIWhSIWU7/nr697o8+65c/+Slo3OZKCUmc=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jQLmU7zd6VwXt+RfsbeLOkVSpCMBG+o8aUkp7uzq6sg=; b=aup6EbglsVGHn+Tgba8t+ZMJDKSmp6+57jnyVW3i3QP5U0PafjdZPq7+KVSMR68VFU WsKfYQi0bGDkfJ9tdXEGnNK2bxJSGKEUUkEVAApXiIuSwT6xkGf/9DhjOJEr7uwU8PhR ZcU5CoS0hO/jo5XoEA8lnhb8bCsJRA2WdhITCskGQhQBUhPq/YnZC1fvbUaydr+M7jmj S7eh6Xs5pRIN9bz01qD5YLVeZzz07UVg7pXa76/k1ogbHug8r6nG3b7TVIlHqvAnRmcD Rh374hB26GJYUnX0cQaJkQqOl5PqepA8HYEg3CrpzrdkQGoQIBep5QnqaYd0i9Zm6+cV qysg==
X-Gm-Message-State: AOAM530mcBGksJrXFHIVg9tcKHJ7IolvSPWUS+xtP1ZwFAGHmJeffH2h iIUeE6XC2hz8JeWA6y8TkpOyg6f8oVW/Fgh7+wdbsg==
X-Google-Smtp-Source: ABdhPJyXsGFRP6VCUYtlkhh1cAunl3140fv885p5t2lrmbABbSsOzekl1AQhUgH/+PnAYjpoiAXrok6Dqe0Yi3/xSxM=
X-Received: by 2002:a92:c94d:: with SMTP id i13mr3573678ilq.102.1602085741075; Wed, 07 Oct 2020 08:49:01 -0700 (PDT)
MIME-Version: 1.0
References: <CAL70W4pkwjYdjO9dOc36LuFn=39fgd9X=BCR60p9802jo3dERA@mail.gmail.com> <CAM5Nu_ykxG7hk10JXiqhc=M5Z8MO4+FaHMTpSL1cHieRi7n01Q@mail.gmail.com>
In-Reply-To: <CAM5Nu_ykxG7hk10JXiqhc=M5Z8MO4+FaHMTpSL1cHieRi7n01Q@mail.gmail.com>
From: Hariharan Ananthakrishnan <hari@netflix.com>
Date: Wed, 07 Oct 2020 08:48:49 -0700
Message-ID: <CAL70W4oc91Y=Jqgfv+eAh7PbSt2tuMAj9j4_EEaWqYWMLncvtw@mail.gmail.com>
To: Mahend Negi <mahend.ietf@gmail.com>
Cc: slitkows@cisco.com, msiva282@gmail.com, jefftant.ietf@gmail.com, Jonathan Hardwick <jonathan.hardwick@metaswitch.com>, c.l@huawei.com, pce@ietf.org
Content-Type: multipart/alternative; boundary="0000000000007f5f9a05b116a70c"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/i4AUUa22psuunp70drLr_jPbaKs>
Subject: Re: [Pce] Shepherd Review of draft-ietf-pce-association-policy-12
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Oct 2020 15:49:09 -0000

Thanks for addressing the comments.

- Hari

On Tue, Oct 6, 2020 at 6:26 PM Mahend Negi <mahend.ietf@gmail.com> wrote:

> Hi Hari,
> Thanks for your comments, a new version of the draft is submitted.
>
> Htmlized version:
> https://datatracker.ietf.org/doc/html/draft-ietf-pce-association-policy-13
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-pce-association-policy-13
>
> Regards,
> Mahendra
>
> On Sun, Oct 4, 2020 at 3:14 AM Hariharan Ananthakrishnan <hari@netflix.com>
> wrote:
>
>> Hi Authors,
>>
>>
>> Please find the review comments below:
>>
>>
>> Title
>>
>> OLD
>>
>> Path Communication Element (PCE) communication Protocol (PCEP) extension
>> for associating Policies and Label Switched Paths (LSPs)
>>
>>
>> NEW
>>
>> Path Communication Element (PCE) Communication Protocol (PCEP) extension
>> for associating Policies and Label Switched Paths (LSPs)
>>
>>
>> 1. Introduction
>>
>>
>> OLD
>>
>> [RFC5440] describes the Path Computation Element communication
>> Protocol(PCEP) which enables communication between a Path Computation
>> Client(PCC) and a Path Control Element (PCE),
>>
>>
>> NEW
>>
>> [RFC5440] describes the Path Computation Element Communication
>> Protocol(PCEP) which enables communication between a Path Computation
>> Client(PCC) and a Path Computation Element (PCE),
>>
>>
>>
>> 2. Terminology
>>
>>
>> OLD
>>
>> PCC: Path Computation Client. Any client application requesting a  path
>> computation to be performed by a Path Computation Element.
>>
>>
>> NEW
>>
>> PCC:  Path Computation Client; any client application requesting a
>>
>>       path computation to be performed by a Path Computation Element.
>>
>>
>> OLD
>>
>> PCE:  Path Computation Element.  An entity (component, application,
>>
>>       or network node) that is capable of computing a network path or
>>
>>       route based on a network graph and applying computational
>>
>>       constraints.
>>
>>
>> NEW
>>
>> PCE:  Path Computation Element; an entity (component, application, or
>>
>>       network node) that is capable of computing a network path or route
>>
>>       based on a network graph and applying computational constraints.
>>
>>
>> 3. Motivation
>>
>> OLD
>>
>> Similarly, a PCC could request a user- or service-specific policy
>>
>>
>> NEW
>>
>> Similarly, a  PCC could request a user-specific or service-specific
>> policy
>>
>>
>> 3.1 Policy based Constraints
>>
>> OLD
>>
>> In the context of policy-enabled path computation [RFC5394], path
>> computation policies may be applied at both a PCC and a PCE.
>>
>>
>> NEW
>>
>> In the context of Policy-Enabled Path Computation Framework [RFC5394],
>> path computation policies may be applied at either a PCC or a PCE or both.
>>
>>
>> OLD
>>
>> The PCC may also apply user- or service-specific policies to decide
>>
>>
>> NEW
>>
>> The PCC may also apply user-specific or service-specific policies to
>> decide
>>
>>
>>
>> OLD
>>
>> The user- or service-specific policies applied to PCC and are passed to
>> the PCE along with the Path computation request, in the form of constraints
>> [RFC5394]
>>
>>
>> NEW
>>
>> The user-specific or service-specific policies applied to PCC are passed
>> to the PCE along with the path computation request, in the form of
>> constraints [RFC5394]
>>
>>
>>
>> 4. Overview
>>
>> OLD
>>
>> This document defines a new Association type, called “Policy Association”
>> (TBD1), based on the generic ASSOCIATION object.
>>
>>
>> NEW
>>
>> This document defines a new association type, called “Policy Association”
>> of value 3, based on the generic ASSOCIATION object.
>>
>>
>> OLD
>>
>> This capability exchange for the PAT (TBD1) MUST be done before using the
>> policy association.
>>
>>
>> NEW
>>
>> This capability exchange for the PAT MUST be done before using the policy
>> association.
>>
>>
>> OLD
>>
>> Thus the PCEP speaker MUST include the PAT (TBD1) in the ASSOC-Type-List
>> TLV
>>
>>
>> NEW
>>
>> Thus the PCEP speaker MUST include the PAT in the ASSOC-Type-List TLV
>>
>>
>> 5.1. Policy Parameters TLV
>>
>>
>> OLD
>>
>>
>>        0                   1                   2                   3
>>
>>        0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>>
>>       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>
>>       |         Type=TBD2             |          Length               |
>>
>>       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>
>>
>> NEW
>>
>>
>>        0                   1                   2                   3
>>
>>        0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>>
>>       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>
>>       |         Type=48               |          Length               |
>>
>>       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>
>>
>>
>>
>> OLD
>>
>> The type of the POLICY-PARAMETERS-TLV is TBD2
>>
>>
>> NEW
>>
>> The type of the POLICY-PARAMETERS-TLV is 48
>>
>>
>> Thanks,
>>
>> Hari
>>
>>
>>