IETF Logo Mail Archive

Re: [Pce] Suresh Krishnan's No Objection on draft-ietf-pce-gmpls-pcep-extensions-14: (with COMMENT)

Suresh Krishnan <Suresh@kaloom.com> Tue, 02 July 2019 01:52 UTC

Return-Path: <Suresh@kaloom.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AC54E12018F; Mon, 1 Jul 2019 18:52:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=kaloom.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7p5bmY7kn0Mw; Mon, 1 Jul 2019 18:52:15 -0700 (PDT)
Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670094.outbound.protection.outlook.com [40.107.67.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0AA4712018B; Mon, 1 Jul 2019 18:52:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kaloom.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9wtsnJ7+/iMwkkWIHQ/HQclS5z6eX1doOVubs2o1108=; b=RCpQ4l+1ZyKlcLwn8KlANehDTybYZjcpd4YXy1/x9BzIQRI2MEjjoShY7sFFVaKPKHza3S2MyvmGpT6NT0dkOxRYEnhvqXOBaISHvuCx0428DLhlrmOyGfcJXlbLqhGWuA5Ds1v/0JbD0asXkUOpbtjleJ1Im8EGSUfJCNgd9TM=
Received: from YTOPR0101MB1819.CANPRD01.PROD.OUTLOOK.COM (52.132.45.144) by YTOPR0101MB1131.CANPRD01.PROD.OUTLOOK.COM (52.132.50.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.18; Tue, 2 Jul 2019 01:52:13 +0000
Received: from YTOPR0101MB1819.CANPRD01.PROD.OUTLOOK.COM ([fe80::20b6:a749:45f6:12ba]) by YTOPR0101MB1819.CANPRD01.PROD.OUTLOOK.COM ([fe80::20b6:a749:45f6:12ba%3]) with mapi id 15.20.2032.019; Tue, 2 Jul 2019 01:52:13 +0000
From: Suresh Krishnan <Suresh@kaloom.com>
To: Cyril Margaria <cyril.margaria@gmail.com>
CC: The IESG <iesg@ietf.org>, "draft-ietf-pce-gmpls-pcep-extensions@ietf.org" <draft-ietf-pce-gmpls-pcep-extensions@ietf.org>, "pce@ietf.org" <pce@ietf.org>, "pce-chairs@ietf.org" <pce-chairs@ietf.org>
Thread-Topic: [Pce] Suresh Krishnan's No Objection on draft-ietf-pce-gmpls-pcep-extensions-14: (with COMMENT)
Thread-Index: AQHVL+ssMp5VSAt9U0y+T9FTQW+oT6a2kbEA
Date: Tue, 02 Jul 2019 01:52:13 +0000
Message-ID: <100DD5E8-2338-4081-9556-7E6C60E0EB7B@kaloom.com>
References: <155483525704.19587.9035104742869837510.idtracker@ietfa.amsl.com> <CADOd8-v5-rq3jNncd6oev55u1VOfsqGP5kuerVc6m83jzfCbFQ@mail.gmail.com>
In-Reply-To: <CADOd8-v5-rq3jNncd6oev55u1VOfsqGP5kuerVc6m83jzfCbFQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=Suresh@kaloom.com;
x-originating-ip: [172.58.27.251]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 069f4910-9bdc-473f-a339-08d6fe8fe726
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YTOPR0101MB1131;
x-ms-traffictypediagnostic: YTOPR0101MB1131:
x-ms-exchange-purlcount: 2
x-microsoft-antispam-prvs: <YTOPR0101MB11313ADCC562BC875AACFDCAB4F80@YTOPR0101MB1131.CANPRD01.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 008663486A
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(39850400004)(396003)(376002)(136003)(366004)(189003)(199004)(51914003)(229853002)(508600001)(76176011)(66446008)(2906002)(33656002)(6306002)(4326008)(6486002)(54896002)(36756003)(6512007)(6246003)(25786009)(68736007)(236005)(21615005)(66066001)(26005)(486006)(316002)(71190400001)(71200400001)(81156014)(91956017)(8676002)(6436002)(14444005)(6116002)(7736002)(54906003)(102836004)(76116006)(66946007)(99286004)(6916009)(73956011)(53936002)(80792005)(5660300002)(6506007)(53546011)(186003)(3846002)(11346002)(476003)(966005)(2616005)(446003)(72206003)(14454004)(66556008)(66476007)(64756008)(8936002)(606006)(86362001)(256004)(81166006); DIR:OUT; SFP:1102; SCL:1; SRVR:YTOPR0101MB1131; H:YTOPR0101MB1819.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: kaloom.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: kVXKNEWz2SpH6vJhk2QcnNYpmWqXjbZI/QviAMRoPh8lMArBfEOvXNpzAy4FQ+aMFMQk7ubOhtGFlcIBO46MgQPEXzSoreT48zYhkanizsYOaBJY0Z4wr9NtRJpdv8ReTKjv9SBlkh+UeovVYiLvQRiWPC0VuQW0PahtJQ58sFeH3zVXrSZtgK/Gt/EN7/7cCCJEbA2ne/+qS1GKgPqyG1N8deswL5pdS2XVGjVbXJrSPFYk1IcX2BppiE4yUaB20ukmFfZS3342IOXD3csSmJWNAw0a+O1ykKRoDY5EjusgrWqpZa8jpkpqJksB1CPGovNegJgGs8c/v5DIl3d6+Qh4DmIYO++2iwSWVhqN7T1Qgf3suWpRgBxwQdfbR4DyZw3zU7+Gae6otoKyD35KA0Tyjk0CkrpfPv08x5QNjoY=
Content-Type: multipart/alternative; boundary="_000_100DD5E82338408195567E6C60E0EB7Bkaloomcom_"
MIME-Version: 1.0
X-OriginatorOrg: kaloom.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 069f4910-9bdc-473f-a339-08d6fe8fe726
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2019 01:52:13.0751 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 47d58e26-f796-48e8-ac40-1c365c204513
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Suresh@kaloom.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB1131
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/iZGNm-Nbw50FQU7wI_ZUTdTrMpk>
Subject: Re: [Pce] Suresh Krishnan's No Objection on draft-ietf-pce-gmpls-pcep-extensions-14: (with COMMENT)
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jul 2019 01:52:18 -0000


On Jul 1, 2019, at 4:58 PM, Cyril Margaria <cyril.margaria@gmail.com<mailto:cyril.margaria@gmail.com>> wrote:

Thanks for the review,

please see inline

Best regards,
Cyril Margaria


On Tue, 9 Apr 2019 at 20:41, Suresh Krishnan via Datatracker <noreply@ietf.org<mailto:noreply@ietf.org>> wrote:
Suresh Krishnan has entered the following ballot position for
draft-ietf-pce-gmpls-pcep-extensions-14: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-pce-gmpls-pcep-extensions/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

* Section 2.5.2

"In this object type the order of the TLVs MUST be followed according to the
object type definition."

Not sure what this means. Can you clarify?


[MC] This refers to Section 2.5.1 Generalized Endpoint Object Type,
the TLV ordering matters (for a given object type).
A better wording could be as follows:
NEW:
All endpoint TLVs have the standard PCEP TLV header as defined in
   [RFC5440] section 7.1.  For the Generalized Endpoint Object Type the
   TLVs MUST follow the ordering defined in Section 2.5.1.

Works for me.


* Section 2.7

"C-Type (8 bits): the C-Type of the included Label Object as defined in
[RFC3471]."

I could not find any references to C-Types in RFC3471. Shouldn't you be
referring to RFC3473 instead? I have a similar comment for the Label field.


[MC] The reference should indeed be RFC3473 for the C-Type.

Excellent. Thanks for the changes.

Regards
Suresh

v2.23.0 | Report a Bug | By Email