Re: [Pce] Roman Danyliw's No Objection on draft-ietf-pce-stateful-pce-auto-bandwidth-11: (with COMMENT)

Dhruv Dhody <dhruv.ietf@gmail.com> Wed, 25 September 2019 08:28 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E2731120122; Wed, 25 Sep 2019 01:28:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XBR1-F-Lqa2g; Wed, 25 Sep 2019 01:28:13 -0700 (PDT)
Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 06A5112011B; Wed, 25 Sep 2019 01:28:13 -0700 (PDT)
Received: by mail-io1-xd29.google.com with SMTP id h144so11574141iof.7; Wed, 25 Sep 2019 01:28:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=M/0G22efe3zHuHuNaQnQMZOMdiTkHPE1l/XaLPOQ3E0=; b=YE1RlQHrt1rWdkTiOyA7rwG8m3hcpKuoRuXeQRRiuOaqzvul2r74A/MwW6WUbIkaUF 4KHfe2/ejcmOt8iJiz1NzQn+bS14IniBDcDfKxvy+jR8bD1mQ2aCIPMD4NvAXln5RCA5 OwE0fyuD7CQ8pzprBmMdhEXxEhdRQNPCkr3MouaKjpTOKiRTl8XwD6VcEa6DzwSC0JUc 5PdfD6IPrfTfKlZUD8JVDQTK0YckiNhS00lRJNA4bGuFOWL4Sv3bR35gJFkFK9ZIwsCG QdUCKycVaAPxUlAzbXjbXD20ba481mog4Oj9AAdnC7zq7wCS582XsMz2DqlA0Hyolv+b OqPQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=M/0G22efe3zHuHuNaQnQMZOMdiTkHPE1l/XaLPOQ3E0=; b=uGvMDAqHrTlbZszFCoMiF3s7s9zWYuZUuM64TjoQngRARd2gllIpiSt664iLro0h1p 5nNGbQ0t/bojUejet2QJPoo+S++MIaXSNQa6Jo89dckGiaA/ybdgzlqjaieF0B4kRp9D 0nkpK3a+LBY6JhodR4PsxVrPYhCqOsBhZ6wGJ4NgbtMnwmZzOIz/xzCs7flh3ZlM0Ech MJJMlXdyKCtS1Sv4DoT+b9/pHgTgwLERcNfA/tW2jFCjzw4K4+k8HfO/ZkJTbyowchdT lnpy6xvRdmKJeaRjGmmnEHki3RwO7zayW9vM/0NeRw4evkTjo1JXp69HJcuwdx2NM7fN pgmA==
X-Gm-Message-State: APjAAAWaDYW7OLI/XjH5bSn7ESS0mGMehPSDQMSXWlIFCypIFddxdZYO 1k9/JP2vE66c8g3V6kuxVueyyvwhEwAl7tHULLg=
X-Google-Smtp-Source: APXvYqwuRed1knRDjlfvcGLepPoeTiB3Xdq1FAIN3KoI5u/JMt2bOOtPaX0mMMYeBPSLMNcnGvg/hBjsfPvnSJPZ1+8=
X-Received: by 2002:a5d:9c4c:: with SMTP id 12mr8728236iof.276.1569400092202; Wed, 25 Sep 2019 01:28:12 -0700 (PDT)
MIME-Version: 1.0
References: <156882833650.4553.15366878761681665492.idtracker@ietfa.amsl.com>
In-Reply-To: <156882833650.4553.15366878761681665492.idtracker@ietfa.amsl.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Wed, 25 Sep 2019 13:57:36 +0530
Message-ID: <CAB75xn79HoiABmaNQxyv7SrHo5rkvzSrkM1yTMLGtckuJiAwQQ@mail.gmail.com>
To: Roman Danyliw <rdd@cert.org>
Cc: The IESG <iesg@ietf.org>, draft-ietf-pce-stateful-pce-auto-bandwidth@ietf.org, Adrian Farrel <adrian@olddog.co.uk>, pce-chairs <pce-chairs@ietf.org>, pce@ietf.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/rlljrad5oxY6MjuhtZsfU5efgFo>
Subject: Re: [Pce] Roman Danyliw's No Objection on draft-ietf-pce-stateful-pce-auto-bandwidth-11: (with COMMENT)
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Sep 2019 08:28:15 -0000

Hi Roman,

On Wed, Sep 18, 2019 at 11:08 PM Roman Danyliw via Datatracker
<noreply@ietf.org> wrote:
>
> Roman Danyliw has entered the following ballot position for
> draft-ietf-pce-stateful-pce-auto-bandwidth-11: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-pce-stateful-pce-auto-bandwidth/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> ** I support Ben Kaduk’s DISCUSS position on the need for clarity in the
> definition of Overflow-Count and Overflow-Threshold
>

Updated.

> ** Section 5.2.x.  Error handling:
> -- A number of the sub-TLVs define ranges smaller than would be possible given
> the number of bit (e.g., 1..604800 in a 32-bit field; 1.100), how would an
> error be signaled for values used outside that range?
>
> -- For values that are [IEEE.754.1985]), how should negative value be processed?
>

I have added "In case of an invalid value, the Sub-TLV MUST be ignored
and the previous value is maintained." in sub-TLV to handle it for all
such cases. Also added a sentence in section 6.4 to log this event.

> ** Nits:
> -- Section 1.  Typo. s/a Active stateful/an Active stateful/
>
> -- Section 5.2.2.2.  For consistency with the other sections s/1 to 604800/1 to
> 604800 (7 days)/
>
> -- Section 6.6.  Typo. s/signalling/signaling/
>
>

All nits are fixed.

Thank you for your review!

Dhruv