Re: [Pce] Genart last call review of draft-ietf-pce-lsp-control-request-08

Francesca Palombini <francesca.palombini@ericsson.com> Fri, 13 September 2019 07:00 UTC

Return-Path: <francesca.palombini@ericsson.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EB4181200BA; Fri, 13 Sep 2019 00:00:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TnuUH4MWoO3l; Fri, 13 Sep 2019 00:00:38 -0700 (PDT)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80079.outbound.protection.outlook.com [40.107.8.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A344912004D; Fri, 13 Sep 2019 00:00:37 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fl7gO5yX7XdOHVFu+mTw72VWioo1p6ZVfYpeGhjmGSy01oaN4e9lwv3mgetorM3pgw8nKW6WVVcbkNLXAVa2kWiRDImb0IWvMGathnrwv3dBjBs+wIFsjBtN6d2kxDuivyed8AkaBcqymSrXWl80U13uwHM/RSP+A5RbsPzfuili1BU9KdeUU0eCPIMpthqZWLWZZdNcK3zUd1bQw4/cAz9OCYkJ4s3M/Mm3r2PsPykP1g12Crw88ks1wCY4HCRF4SVvfdHPpLtZ42rvsnhPAQ1wr5kaBNZUNP5oB+6IGyBit+eX0JZgY1wkUoT66JkzgGEFVaChjrANt4LtReYVAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/IYKYJlihEdgnZd1gI2RMQXrs/Q/FYnQiTCAPndHRwk=; b=Sv8H6DHWBL5wkYZyNG3QTKgQ2VquxNEEAMlFUqBhtM5+IObWkovUR3j/w4YfAsXJLN0W+dD5VDFfkS+y4LfE4XofYCggCWYf2OyOI5wWNNqCrqYrGs9N7taXMdJTz/Iw2Ok8EUmXAPpSFqkdacwOIShduE8d7QcZOn7xs3EZOUE1it9CGXKV2npl3/0s5BjBPeMv7K1WngiQlc9y2XjSgglhLmAEu6vUiY6lUTk8KKIUX8S50tvc2dB/DHpJBG6a/ltivYj/MZsh07A6v4n1Fu/uT5D7CITIa/+U8vT3eO3s/D/g4cd/MQX5r5Fpf78lcV0X2787xzW20kfdMWW/yA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/IYKYJlihEdgnZd1gI2RMQXrs/Q/FYnQiTCAPndHRwk=; b=kFZHvRmnN15US06gA18RFZeBrpQMWTMHig5H4L9No4EDz2evJNjjRWKJe40EJOX7zdGw/Ksh26K4C3YigTidwnZQNfTEd63ZcdptesKXskntiSCNm5aXyH9wCS8YxwWZpxI1bYlqway3PBBu5f1F0YvNQuUwQfInmZKaE+iIRaY=
Received: from HE1PR0701MB2746.eurprd07.prod.outlook.com (10.168.185.17) by HE1PR0701MB2362.eurprd07.prod.outlook.com (10.168.126.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.10; Fri, 13 Sep 2019 07:00:35 +0000
Received: from HE1PR0701MB2746.eurprd07.prod.outlook.com ([fe80::69ac:4f28:cd6a:6302]) by HE1PR0701MB2746.eurprd07.prod.outlook.com ([fe80::69ac:4f28:cd6a:6302%11]) with mapi id 15.20.2263.016; Fri, 13 Sep 2019 07:00:35 +0000
From: Francesca Palombini <francesca.palombini@ericsson.com>
To: Dhruv Dhody <dhruv.ietf@gmail.com>
CC: General Area Review Team <gen-art@ietf.org>, "draft-ietf-pce-lsp-control-request.all@ietf.org" <draft-ietf-pce-lsp-control-request.all@ietf.org>, "pce@ietf.org" <pce@ietf.org>, "ietf@ietf.org Discussion" <ietf@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-pce-lsp-control-request-08
Thread-Index: AQHVZJgCPIMQGKtzVUGn3Sf9A9xxvqcpWjcA
Date: Fri, 13 Sep 2019 07:00:34 +0000
Message-ID: <45C6E308-79BC-4427-A61C-590D03E7572B@ericsson.com>
References: <156682165261.25516.1887489813169802107@ietfa.amsl.com> <CAB75xn4=Q5gw1Z1fcYTDgwd5BD7S+=Qsa1pt1QfjGc8nLzUhYA@mail.gmail.com>
In-Reply-To: <CAB75xn4=Q5gw1Z1fcYTDgwd5BD7S+=Qsa1pt1QfjGc8nLzUhYA@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=francesca.palombini@ericsson.com;
x-originating-ip: [158.174.219.143]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bf3c4bfd-5ada-4116-173b-08d738181358
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:HE1PR0701MB2362;
x-ms-traffictypediagnostic: HE1PR0701MB2362:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <HE1PR0701MB236233E9A2DDE5CE6FD759F598B30@HE1PR0701MB2362.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0159AC2B97
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(376002)(39860400002)(136003)(366004)(189003)(199004)(51914003)(6506007)(71200400001)(71190400001)(53546011)(14454004)(8676002)(7736002)(66066001)(486006)(2906002)(446003)(102836004)(26005)(478600001)(11346002)(186003)(14444005)(256004)(86362001)(66946007)(81166006)(81156014)(316002)(305945005)(76116006)(6116002)(36756003)(4326008)(53936002)(99286004)(25786009)(8936002)(54906003)(6916009)(64756008)(66556008)(66446008)(66476007)(5660300002)(6512007)(6306002)(44832011)(2616005)(476003)(33656002)(6436002)(76176011)(6246003)(3846002)(6486002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0701MB2362; H:HE1PR0701MB2746.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: ix05MP8ox0Wc2HXmrLlrWVZMgKMxR3GQ+LgB2crCV1+dMFlMLQHOnVwULFRIqfJB4E0tgzaRvpGMKW3d8G2a6nQkHpAdB30CaBAgMLKQFiTsebk7upNyEvUcZoVonZ/xzaKe+i2yfrhIHEfEouim+6l4TvkxWBaoPhj2B6zFphUeL+OHMXQ6GbQo9iq4SL9TeyK5D3yo+jXYLCD76AU0QlCbX9geyIzpQKNaQXlw+QRWrd7K/YPcU/teIuEt1PFyab5ej20lAlYDOJ6F9aBI96Z/jLUCgHCZlDrH0Ql6bU7D2LjClzKHGvqTlkzxLLOdysRDsMG/B7c7XKyyh60322HtGf2iWA2/FYf8vGrVA1HNCIgNOzeMKEZC+quSVBWaqev7OtfNVgM3mgde4cgBLDNynowEr9qa3Fe/pyxnP1c=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <09B820FEE1A509459D39372D35E33FED@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf3c4bfd-5ada-4116-173b-08d738181358
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2019 07:00:35.0135 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZHHTBimi90+IJAdOJ18WHKp/LKkxK9g29RH3wpiHLwEDUNSi3QZtBocOMmCwgQytSv0vbypJLzEWNP0ZOMaZIWQibaeHQqCWpFY2jqil5lGNFYJ5piLtDToHFdZTcqZY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB2362
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/vr5PWfCrEyTlyOHFROZ4trZUf9A>
Subject: Re: [Pce] Genart last call review of draft-ietf-pce-lsp-control-request-08
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Sep 2019 07:00:42 -0000

Hi Dhruv,

Yes, that looks good to me, I agree with the changes and I'm fine with letting the RFC editor figure the last nit out. Thanks!

Francesca

On 06/09/2019, 11:46, "Dhruv Dhody" <dhruv.ietf@gmail.com> wrote:

    Hi Francesca,
    
    Thanks for your review. Few thoughts...
    
    On Mon, Aug 26, 2019 at 5:44 PM Francesca Palombini via Datatracker
    <noreply@ietf.org> wrote:
    >
    > Reviewer: Francesca Palombini
    > Review result: Ready with Issues
    >
    > I am the assigned Gen-ART reviewer for this draft. The General Area
    > Review Team (Gen-ART) reviews all IETF documents being processed
    > by the IESG for the IETF Chair.  Please treat these comments just
    > like any other last call comments.
    >
    > For more information, please see the FAQ at
    >
    > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
    >
    > Document: draft-ietf-pce-lsp-control-request-08
    > Reviewer: Francesca Palombini
    > Review Date: 2019-08-26
    > IETF LC End Date: 2019-08-28
    > IESG Telechat date: Not scheduled for a telechat
    >
    > Summary: This draft is almost ready for publication, but has minor issues/open
    > points that should be fixed before publication.
    >
    > Major issues: N/A
    >
    > Minor issues / questions:
    >
    > * Section 3: At the end of season 3, you indicate that this new flag has no
    > meaning in PCRpt and PCInitiate messages. RFC8231 defines that the SRP Object
    > MAY be carried in PCErr as well, shouldn't there be such requirements (MUST be
    > set to 0, MUST be ignored on reception) for PCErr?
    >
    
    I agree. I suggest to make this generic, something like - "The C Flag
    has no meaning in other PCEP messages that carry SRP object and the
    flag MUST be set to 0 on transmission and MUST be ignored on receipt."
    
    > * In the following text (Section 4): "The PCE SHOULD NOT
    >    send control request for LSP which is already delegated to the PCE,
    >    i.e. if the D Flag is set in the PCUpd message, then C Flag SHOULD
    >    NOT be set." Why is there a SHOULD NOT instead of MUST NOT? In which
    >    situation could it be acceptable or useful to request control for a
    >    delegated LSP?
    >
    
    It wont be useful, but if received it would be silently ignored. It
    does not rise up to a high level of error and I suspect that is why
    authors used SHOULD.
    
    > Nits/editorial comments:
    >
    
    Thanks for these, just one comment ...
    
    > * Terminology should also include a sentence about the reader being familiar
    > with at least RFC8231.
    >
    > * Terminology could also include what SRP stand for.
    >
    > * Section 3. When introducing SRP, it would have been helpful to the reader to
    > reference section 7.2 of RFC8231.
    >
    > * Section 3. "PCE sets the C Flag to 1 to indicate that, it wishes" -- remove
    > ","
    >
    > * Section 3. "MUST be ignored on receipt" -- "MUST be ignored on reception"
    >
    
    I have noticed 'on receipt' in many of our documents. We should leave
    this one for the RFC-EDITOR maybe...
    
    > * Section 4. When introducing the D flag, it would have been helpful to the
    > reader to reference section 7.3 of RFC8231.
    >
    > * Section 4. "Note that, the PCUpd message with C Flag set is received" --
    > "Note that, if the PCUpd message with C Flag set is received"
    >
    > (Please keep my address in the To: field if you want to make sure I see any
    > response to this thread)
    >
    > Thanks,
    > Francesca
    >
    
    Thanks again for your review.
    
    Regards,
    Dhruv