Re: [Pce] Rtgdir early review of draft-ietf-pce-stateful-pce-lsp-scheduling-12

"Carlos Pignataro (cpignata)" <cpignata@cisco.com> Mon, 23 March 2020 19:57 UTC

Return-Path: <cpignata@cisco.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1D8CE3A0D89; Mon, 23 Mar 2020 12:57:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.599
X-Spam-Level:
X-Spam-Status: No, score=-9.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=HimAjLJW; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=jQiEb+Ys
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XsyMI1jauCJG; Mon, 23 Mar 2020 12:57:33 -0700 (PDT)
Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DD75B3A0E6C; Mon, 23 Mar 2020 12:57:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=23709; q=dns/txt; s=iport; t=1584993453; x=1586203053; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=UvYVRw0IyUvKYMLczLAO6IGvZRkU4Zy4DRrj311vph8=; b=HimAjLJWFEq7nwxdDz4I/Tep5nlvXUp20MqPGS4KNRHDXGowYxR9NpjC 9AiwecCz7pr4TA5u8+23vJqmpEY5GTmD029tLsf8079ZP1AmIXswu3E4B dEEi0dikpXs30WIM758BaYDRyifQO30GSSP5iEaMwByHhVyRkGTltFdln s=;
IronPort-PHdr: =?us-ascii?q?9a23=3A4MPMAB/+dDZb/f9uRHGN82YQeigqvan1NQcJ65?= =?us-ascii?q?0hzqhDabmn44+8ZR7E/fs4iljPUM2b8P9Ch+fM+4HYEW0bqdfk0jgZdYBUER?= =?us-ascii?q?oMiMEYhQslVcWdCEL9JeLjRyc7B89FElRi+iLzPA=3D=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BfDQAqFHle/4MNJK1mHQEBAQkBEQU?= =?us-ascii?q?FAYF7gSUBLiknBWwPSSAECyoKhA6DRQOKcIJfkzqEYoJSA1QJAQEBDAEBIgs?= =?us-ascii?q?CBAEBgWiCXQIXghAkOBMCAwEBCwEBBQEBAQIBBQRthVYMhWMBAQEBAxIRHQE?= =?us-ascii?q?BNwEPAgEGAhEEAQEoAwICAjAUCQgCBA4FIoJ/BAEBgX5NAy4BDpFCkGcCgTm?= =?us-ascii?q?IYnWBMoJ/AQEFgS8Bg3QDFYIMCYE4hSANhwIagUE/gREnIIJNPoJkAgIagUg?= =?us-ascii?q?JDxYJglsygiyOAAkFgmmFeCSJeo5OdgqCPIZxbYpwhDkdgkyBAocpkGKSKYV?= =?us-ascii?q?xjzCDNAIEAgQFAg4BAQWBaSINgUtwFWUBgkEJCisSGA2EV4lGgScBCIJDhRS?= =?us-ascii?q?FQXQCAQEBgSSMXQGBDwEB?=
X-IronPort-AV: E=Sophos;i="5.72,297,1580774400"; d="scan'208,217";a="476729237"
Received: from alln-core-1.cisco.com ([173.36.13.131]) by alln-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 23 Mar 2020 19:57:32 +0000
Received: from XCH-ALN-003.cisco.com (xch-aln-003.cisco.com [173.36.7.13]) by alln-core-1.cisco.com (8.15.2/8.15.2) with ESMTPS id 02NJvV0D012111 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 23 Mar 2020 19:57:32 GMT
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by XCH-ALN-003.cisco.com (173.36.7.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 23 Mar 2020 14:57:31 -0500
Received: from xhs-aln-003.cisco.com (173.37.135.120) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 23 Mar 2020 15:57:30 -0400
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-003.cisco.com (173.37.135.120) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 23 Mar 2020 14:57:30 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c6HXGsKD4ehku10+KTcbbml2NJ2waiyhP6FV3l5LNrRoLWh4Q9dgpUficGGjix3D4zhrW+7Jo6tFrnMOmMAh/yaFfDC+rFQv2joUADXP0gjKt0j4eCEu4DfhpQsqjvnuAoOwZhtnUnRheA4cgmM5Pqt3JKtUnmz01YV13sL4oHOdtnP0Z4E7w+/Ga/A5HFR6S+Ybm70S0agYg4DHswAPzgBTfaEis81WWdk2Q4bWmHtTTXgeZvnAadzvutZAEpdynNzq6b/lQ34jHqFPXnjW2w9aTaYr4I+PqJTm6JHhAk2AaRXmUOO9rNleKZyWceHfTY+NL7cLMKiFu82b01RF5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UvYVRw0IyUvKYMLczLAO6IGvZRkU4Zy4DRrj311vph8=; b=lEo1fqAz+Nn0WJZNLjFlMWNbg05cDxU0MXJwLjqdWLeyszVzOgX6JikO0Xmss6Rqes3N9DZsc/SbbhATsQkp+ovC0n+eTYG/Vp+x77kqh5jJo6nxs8blGLrIo8j7KhtJ2hNbo2+0fu9wnf2tC0cSpJnKkav2i4CsKjJ20d1hHAZKxV4V1sWd81r7dDGnt6Gr4KFt1Tz1FeAI1C8KwWOxEJU/RzKWh0M8U997CmJCvpGj+uiRfclIdS3LvdgLhBoKuEMcihrQ07x4maePda/EI563h/Dmb0qFgJggE4/LKWFMJyn+Kt/a12+amKV6ti2MK2CEbfoJwx0TCqCNz9D/BA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UvYVRw0IyUvKYMLczLAO6IGvZRkU4Zy4DRrj311vph8=; b=jQiEb+Ysqe20+ve34tUlfvLT9BP0v7Y9b5DtWKHDeH17NTVkDSeRAJU2olD68g6I0ZIK9JPx//EgIeuQVp3fkWRwFQAk0dZNOGq9LtSC+a3xwHz11epz+OjBmOF7MCmnGR2znlPM7demvH0w6+UiyqY13oNA+W0wJK+f7eYFXGI=
Received: from BN8PR11MB3635.namprd11.prod.outlook.com (2603:10b6:408:86::20) by BN8PR11MB3537.namprd11.prod.outlook.com (2603:10b6:408:87::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.15; Mon, 23 Mar 2020 19:57:27 +0000
Received: from BN8PR11MB3635.namprd11.prod.outlook.com ([fe80::2c08:cdcf:fc41:fe74]) by BN8PR11MB3635.namprd11.prod.outlook.com ([fe80::2c08:cdcf:fc41:fe74%7]) with mapi id 15.20.2835.021; Mon, 23 Mar 2020 19:57:27 +0000
From: "Carlos Pignataro (cpignata)" <cpignata@cisco.com>
To: Huaimo Chen <huaimo.chen@futurewei.com>
CC: Routing Directorate <rtg-dir@ietf.org>, "pce@ietf.org" <pce@ietf.org>, "draft-ietf-pce-stateful-pce-lsp-scheduling.all@ietf.org" <draft-ietf-pce-stateful-pce-lsp-scheduling.all@ietf.org>
Thread-Topic: Rtgdir early review of draft-ietf-pce-stateful-pce-lsp-scheduling-12
Thread-Index: AQHWAUyH4ffY42vwbUqAl0qCLugLN6hWl/MA
Date: Mon, 23 Mar 2020 19:57:27 +0000
Message-ID: <FA97B889-E055-48E3-B56E-568020D629D9@cisco.com>
References: <158493352697.31725.4511309706970342279@ietfa.amsl.com> <BY5PR13MB3651CBD3454EABC5E90F0820F2F00@BY5PR13MB3651.namprd13.prod.outlook.com>
In-Reply-To: <BY5PR13MB3651CBD3454EABC5E90F0820F2F00@BY5PR13MB3651.namprd13.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.60.0.2.5)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=cpignata@cisco.com;
x-originating-ip: [108.203.7.63]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 529d2eb8-6287-41ba-7fcf-08d7cf6469b1
x-ms-traffictypediagnostic: BN8PR11MB3537:
x-microsoft-antispam-prvs: <BN8PR11MB3537EF202CFC51DD3A7B3F0EC7F00@BN8PR11MB3537.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0351D213B3
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(366004)(136003)(39860400002)(376002)(199004)(66446008)(45080400002)(478600001)(186003)(76116006)(6506007)(53546011)(66946007)(5660300002)(64756008)(8676002)(81166006)(81156014)(66556008)(86362001)(316002)(54906003)(71200400001)(33656002)(66476007)(36756003)(2906002)(6512007)(6486002)(2616005)(26005)(6916009)(8936002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR11MB3537; H:BN8PR11MB3635.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 4DQsGAL7EB0C1eVlEBa3PwhupX9SQMyuxKiv+3f1UlYuJ3s8nV5NKIseLYrgmf72pjTm9XKYDaFexwnEk/zS6A9mBnwRT73PgzeZBo+lAHN1V9fFfiEK75qyyfQxnslwt6yVoT5AV4JtKANBjeI/5hRYGZY46y4aw7jSbvIj9Hxn6FW0U6lK6HeoKBdUnzOzIneFzWoIr8sMAKeKhse3eNPBSXzdRsnBSTdl1mnjSvP1vIp10+CkxBKRdsrMU+zOmoICNPJV+cscVmtnKGLt/xJeCW2OtJAVXjJm8PPWV3ctjS45N569PQrp4dk56pNA4KisEqRJvZey7L4Zqik1WxGoMLxohvILXUxJR4TRq7H3j9sx4lmxcMMq0++TH+dF9/3mweMgngissaFeCXNGAQHh1FtD9dUHum2dBEsHCzc0OGgm8Mk0nolGbhA3C5O+eDepbs51nsfEpYrpw+Hu4zGSCuWuvmmpEIgJNBgFGXOXTrQuxMVSHDHWwhrmMxH10r/NAP8D2T/yBrnyZjRjGQ==
x-ms-exchange-antispam-messagedata: CF5ssK79IQS2LR7bXptO8qnC34C2ZqS2B+xLahIMWy9SgBPtzNxGoidsU9Hs296x6Dv1ir72/vQO1IAa8XoI45Y++2LisiTVpTX9bwgga8zFpItkJtb/+iHKG4MTThheVIga+YErao4plL+1hm2OLA==
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_FA97B889E05548E3B56E568020D629D9ciscocom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 529d2eb8-6287-41ba-7fcf-08d7cf6469b1
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2020 19:57:27.0855 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iTBq8x9iQourrVDjqg4IZ+FB2ttAbsG5WJGOi34Z/xLUerrVmCd8eDIvcYlW7qMIeKRw6irxOiJeV5UkIOTV4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3537
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.13, xch-aln-003.cisco.com
X-Outbound-Node: alln-core-1.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/wg3epPjmHbv9O0SnWpC_plIsJrU>
Subject: Re: [Pce] Rtgdir early review of draft-ietf-pce-stateful-pce-lsp-scheduling-12
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Mar 2020 19:57:58 -0000

Hi Huaimo,

I appreciate the quick response and I agree with all of your approaches to addressing the comments (hence a quick top-post Ack). Thank you!

Carlos.

2020/03/23 午後3:51、Huaimo Chen <huaimo.chen@futurewei.com<mailto:huaimo.chen@futurewei.com>>のメール:

Hi Carlos,

    Thank you very much for your comments and suggestions.
    We will address them accordingly as described inline below with prefix [HC].

Best Regards,
Huaimo
________________________________
From: Carlos Pignataro via Datatracker <noreply@ietf.org<mailto:noreply@ietf.org>>
Sent: Sunday, March 22, 2020 11:18 PM
To: rtg-dir@ietf.org<mailto:rtg-dir@ietf.org> <rtg-dir@ietf.org<mailto:rtg-dir@ietf.org>>
Cc: pce@ietf.org<mailto:pce@ietf.org> <pce@ietf.org<mailto:pce@ietf.org>>; draft-ietf-pce-stateful-pce-lsp-scheduling.all@ietf.org<mailto:draft-ietf-pce-stateful-pce-lsp-scheduling.all@ietf.org> <draft-ietf-pce-stateful-pce-lsp-scheduling.all@ietf.org<mailto:draft-ietf-pce-stateful-pce-lsp-scheduling.all@ietf.org>>
Subject: Rtgdir early review of draft-ietf-pce-stateful-pce-lsp-scheduling-12

Reviewer: Carlos Pignataro
Review result: Has Nits

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The
Routing Directorate seeks to review all routing or routing-related drafts as
they pass through IETF last call and IESG review, and sometimes on special
request. The purpose of the review is to provide assistance to the Routing ADs.
For more information about the Routing Directorate, please see
​https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftrac.tools.ietf.org%2Farea%2Frtg%2Ftrac%2Fwiki%2FRtgDir&amp;data=02%7C01%7Chuaimo.chen%40futurewei.com%7C89cb9451d2f74f854da608d7ced8e77c%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637205303321659875&amp;sdata=6R9jure7G95HIZQDlXO%2F27mVBVwZWR27RoFvhhpfsLo%3D&amp;reserved=0

Although these comments are primarily for the use of the Routing ADs, it would
be helpful if you could consider them along with any other IETF Last Call
comments that you receive, and strive to resolve them through discussion or by
updating the draft.

Document: draft-ietf-pce-stateful-pce-lsp-scheduling
Reviewer: Carlos Pignataro
Intended Status: Proposed Standard

Summary:
This is a well written document, which displays iterations that improved its
quality. I have no concerns with this document.

I would point out a small set of questions and potential issues for the
author's consideration:

5.2.1.  SCHED-LSP-ATTRIBUTE TLV

Can Start-Time and Duration take any value from 0 to 32-bits-of-ones?

[HC]: Good catch.
The value of 0 for Start-Time and Duration does not make any sense.
We will restrict its use. The value of 32-bits-of-ones can be used.

9.  Manageability Consideration

Could these add Default values or ranges (esp. to times, seconds, etc.)?

[HC]: Yes. We will introduce some default values.

10.  IANA Considerations

10.1.  PCEP TLV Type Indicators

For the SCHED-LSP-ATTRIBUTE and SCHED-PD-LSP-ATTRIBUTE, I suggest creating
Registries for the Flags: |   Flags |R|C|A| What is the future's allocation
policy for remaining Flags for example?

Actually reading later Section 10.3 I realize they are specified there. Why are
the Flags in a different section, but Opt in this section? Anyway, a nit.

[HC]: We will move it into this section.

   IANA is requested to create and maintain a new registry "Opt" under
   SCHED-PD-LSP-ATTRIBUTE (TLV Type: TBD2).  Initial values for the
   registry are given below.

What is the allocation policy for Unassigned?

[HC]: We will add "New values are assigned by Standards Action [RFC8126]."

     Value    Name                              Definition
     -----    ----                              ----------
      0       Reserved
      1       REPEAT-EVERY-DAY                  Section 5.2.2
      2       REPEAT-EVERY-WEEK                 Section 5.2.2
      3       REPEAT-EVERY-MONTH                Section 5.2.2
      4       REPEAT-EVERY-YEAR                 Section 5.2.2
      5       REPEAT-EVERY-REPEAT-TIME-LENGTH   Section 5.2.2
      6-14    Unassigned
      15      Reserved

What is the reason for "Section 5.2.2"? Since this are instructions for IANA,
these references are not significant without the document reference.

[HC]: We will change it to "This document".

Appendix A.  Contributor Addresses

There are more than one Contributors -- why singular?

[HC]: We will use plural.

I hope these help,

[HC]: These really help improve the quality of the document.

Carlos Pignataro.