Re: [Pce] I-D Action: draft-ietf-pce-pcep-yang-16.txt

tom petch <ietfc@btconnect.com> Thu, 11 March 2021 12:56 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 261643A08D9 for <pce@ietfa.amsl.com>; Thu, 11 Mar 2021 04:56:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K1Next0Cytsw for <pce@ietfa.amsl.com>; Thu, 11 Mar 2021 04:55:58 -0800 (PST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2119.outbound.protection.outlook.com [40.107.20.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3BEA13A08C0 for <pce@ietf.org>; Thu, 11 Mar 2021 04:55:58 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HUrwT2UbbCBtk84jEo5wXh7q2sMpZwcDydAjpxGJQsjGciucR9tHCEZi2JEOuJHvZOUrM9CL3d4lakJbaVtAiZ+UzmCy2Z7ZR6sJ4ypx7z1RjRPIiy/Ca0V1VfPucHHGzXyLyYOJinJvUOirN6xGY7hfdWsavcHNo+Aa87u5SY20dvspIfwTWbmU3Sr1YikLN0qrGM2I0nxl6b2lW2cLto1nsIHLkayAgMCsccxXfacmHvTQA3KncMIInPgiujKre+2CmsJCokfA4iR+gyqbPwfa69C9bGivE21s5wznS725zbyzoFsA47ZOp0DafPeGnvk46UT4AHxGET1uKygVUQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xyNU6mrAQpJ94cA8Symr9ky5comjsETlQ6HC1sa5530=; b=Hqey+TP/CN0A8q/ZvJ0wXPWKtvo3CxoSt4typHVWCRcNSkk8cXNs89EXncB6WdyFrA45bKs7dyINdk2AouyRkgHEy5FuGQmoSvHh8zeAT5bkXlb/pSUuQLeumMQOGcf12xb/Qhov9DgvaWVuuN9nVRU5dyHy/BG/P5SCIuWc6AjeWhdMHRXNCTUkvu175a6dqzNNR5aL56N+VdC3rZkssqOhlLF/x8E3Upx4a6lqXJ+p+CfYE7wuwCqxGrDv8Fl0G7/QCfZrVAWE4YepMPFWOOdiFRFlgLVmZ5i6Sl5eiiq3uhgwxNSl7YTZpVsyy4uyi0yHgdSt1mCOCcJ3J1brkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xyNU6mrAQpJ94cA8Symr9ky5comjsETlQ6HC1sa5530=; b=XYgJrsv9me9mgVnN6L1dVFbrazXpCxYQ84XPrVrR+V0zlrEHNZKh+fp5LKtFGj/C2KrX1RDLhle+3TW0vIS7w4EQBAHZRGHjV6rMhWRxu7JTaf3L2SNoj/SW7DNyQtuLfvC2wEI+46KRkCkLifyJG0a5bTwrub6SiFC6oiKAlc8=
Received: from AM7PR07MB6248.eurprd07.prod.outlook.com (2603:10a6:20b:134::11) by AM6PR07MB6165.eurprd07.prod.outlook.com (2603:10a6:20b:3f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.13; Thu, 11 Mar 2021 12:55:54 +0000
Received: from AM7PR07MB6248.eurprd07.prod.outlook.com ([fe80::543d:497d:ba3f:5576]) by AM7PR07MB6248.eurprd07.prod.outlook.com ([fe80::543d:497d:ba3f:5576%3]) with mapi id 15.20.3955.010; Thu, 11 Mar 2021 12:55:54 +0000
From: tom petch <ietfc@btconnect.com>
To: "pce@ietf.org" <pce@ietf.org>
Thread-Topic: [Pce] I-D Action: draft-ietf-pce-pcep-yang-16.txt
Thread-Index: AQHXCScCDwxzOFwkQk2ecfQB6HJv0ap+yBTm
Date: Thu, 11 Mar 2021 12:55:54 +0000
Message-ID: <AM7PR07MB62483774D807F9076BF7A335A0909@AM7PR07MB6248.eurprd07.prod.outlook.com>
References: <161400406064.23027.17597651791521888748@ietfa.amsl.com>
In-Reply-To: <161400406064.23027.17597651791521888748@ietfa.amsl.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=btconnect.com;
x-originating-ip: [86.146.121.140]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: efd29688-9dee-48df-5b03-08d8e48d020a
x-ms-traffictypediagnostic: AM6PR07MB6165:
x-microsoft-antispam-prvs: <AM6PR07MB6165F39591C873227CAED1EBA0909@AM6PR07MB6165.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: bIuqf+07sjgqlmCluGqIpNkFceTI6Tdx9a93FB0p0Wid/ufCgWHdDpFIgv7BbbhNei1Ld/dUdzxfo51bXlGto6c7uLTE/PXf5jqCTu+i3wXrRPAiiQcoM2YCEXbNwJ4LH2N8cXZ5v1qvqDb38LS6OnKArbLWnS/5aQnKpaTyHxu++ShNoSxhfd2cKDsfCU/1TaBNV8UYFPzTIhGPyOJc8icR/P2zuevMZq+bY0fyDaADtSEbaBBsAje9lsPskcwL7uxr7Kf/QU+2skfVHpZ/AK4zun9cMrF7cRT8evIA+awwfoyw8MjXpo0tij2foizZAXxVzaTbEtAAxRBiPbk311AAHQbV4GFDASFz+0fGiv0HBgQKw12cbakRhk4SrP+9VLlfYK6Sq2x0CrwOhKIOLplhXqWUookYvZe3uBcLHoN/lRnpFw3K+l5GJwF8sOx3rEuKjW2w3TVB7khCcf/Cve8NzhtV8hYpSwsDBVgDszgLdiG8VnctID84Hp+BuYZDTReQZhe9M53wxxRZyWt5gG/eClCEtJjnS91+Nsz6gpIbC8Chy4KoDR9/o9clFwd0bWjFfN2ZxzkWQ46T/TiFgpnQzZLEL2ByDJnvD8FIjE1I49g3buTrx+AWpcbyRPY8
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR07MB6248.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(376002)(39860400002)(366004)(396003)(346002)(2906002)(5660300002)(76116006)(91956017)(966005)(66556008)(8676002)(66476007)(83380400001)(9686003)(316002)(55016002)(66946007)(52536014)(66574015)(33656002)(64756008)(71200400001)(66446008)(86362001)(6506007)(8936002)(7696005)(186003)(26005)(478600001)(6916009); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?WlmZ+mGADM4gWXTKbEojm7HXFn07jyWxB2wyBevZOS43vWpFLWOYs9lC4h?= =?iso-8859-1?Q?CSMx6IeUNncqnZ2T1EAO1P/vO6tYj8Cv1jTGBA3kLJCzuNlMeqVcnVtnlD?= =?iso-8859-1?Q?N3Uydv2LS0O2p/L7mVzJmSZEj126YS1EZz4rnVqzU57Z/GEggQ2P/rGRmx?= =?iso-8859-1?Q?B/tayEWScOjgjEKYhQTTlQDio6RV7ZfQPUA+6EV0rLlDlelM9eJ8pJE1e8?= =?iso-8859-1?Q?P//LhW7MZ23MjerEQPg7tbg5dR68Bv+XBbb7DrW80CgSSHPnwURCBVMwGi?= =?iso-8859-1?Q?qiH41Cy58ERpvsbNBVzGKGP1c06eVFW52KxiITQ6etPeuta5899uXN2K5z?= =?iso-8859-1?Q?N+c0qo0NggeH9nnpTMAABigj4wdev4XGCBFxLo1U4LF8yjQAqDfaqy8qjG?= =?iso-8859-1?Q?FwTebrMBtbbRR/egzfjZ4C2LFzK9IqhwP34kMxfMYvSL92984WhzsMVXgZ?= =?iso-8859-1?Q?DrvZX04zJ2QBMiBXA9l1ZkQr4sVNRUiFdm8cHG0ZkvwzAL3i2lVvHpUkxR?= =?iso-8859-1?Q?TjCZZh7wcbgtmqgerKWpjBNJ6g+vEZ/PiNgEW+ZZIL7md01UP0gAtoy9w2?= =?iso-8859-1?Q?a9Hvp+MMkkFKFxg8DdRsLG59h0rBBxcQmk5XHatsKsqtPqLTReXLZ+eSvY?= =?iso-8859-1?Q?Un0LId2XHCqNaAMMEnIAUBszOIjN9zJV5Vh+i+mzACGEjqWhPaKawstq3w?= =?iso-8859-1?Q?Qa9TlJseErFs1rzNbUZFtdLnd6Fjo9CsANm0KS6ecyObOIYi9NXZBaiyXO?= =?iso-8859-1?Q?gO7yvngKcwzh787uCnG8Q3diLu7u3yrQQzDfywLj7l5o6g0dYaVLOYZGya?= =?iso-8859-1?Q?cD8ZqdCf5pSiFhbZ3TfpTEt8izMdk3WSNc+VHk0XlNcwLs1ApwJgHC2lKJ?= =?iso-8859-1?Q?JcoMTUmEOAYxhmMp30ROqq4lzvFskO/CGDGBxB/7jP8PwdPYWAk2DahtzK?= =?iso-8859-1?Q?8K2GfN0RNrzvIVHPnE6zePVPJFqzDun+/Vl9NBsqjq1cZIflmlVqzvSw8O?= =?iso-8859-1?Q?rFt+M0tBdyhkURLgGNCE29gv2MysLWURQapnozM3prxuHr9+wJ7HzOOVuK?= =?iso-8859-1?Q?PKa9p71ABZjtqQFxc5ud3DAZa1gy1DF+Fh5Mysd6JecqSW2DHMN062wFdm?= =?iso-8859-1?Q?OBV3IdKFN7fCcOYU4JDNxr8UR4MtHC0Eywa1QB0y6uYRwo4orHztQ2ohZM?= =?iso-8859-1?Q?tY4SPOmDiIShT29GDw6QVrn+cqPDaUhVPsNurSW8vKla2L5uuDjfT/XCj2?= =?iso-8859-1?Q?Gmp2q7sKszESV06hTp4Gdiqp3SPDYg4qGLIYQy9InN956rGbquoWoeG0dw?= =?iso-8859-1?Q?PICfU7bj/kvyoibKxbNqsrmxZEMM/ny0yGwXMbs5yCnqwcc=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM7PR07MB6248.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efd29688-9dee-48df-5b03-08d8e48d020a
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2021 12:55:54.7664 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gP8zwRo+Z+5adPsxmpQAwfp52CCfmWaYEBr/S/QAa+J963Latef/WlpvQDs2N7GESXbNbsyY9gQPVfEUvUAAUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB6165
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/yKNQX9_HWkJnaQmuzrASnQG4g0g>
Subject: Re: [Pce] I-D Action: draft-ietf-pce-pcep-yang-16.txt
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Mar 2021 12:56:01 -0000

From: Pce <pce-bounces@ietf.org> on behalf of internet-drafts@ietf.org <internet-drafts@ietf.org>
Sent: 22 February 2021 14:27

<tp>
I notice a number of glitches in this I-D, several about terminology, others about arithmetic.  I post the ones I have seen so far because my cache is full, but I expect that there will be more!

s.3 lacks
**PLSPID
** Association
** OF  RFC5441
**SRP RFC8231
all of which I think are needed along with the relevant RFC as references

RFC5540 is consistent in its terminology as it should be, but this I-D does not follow that terminology and is not consistent.  I refer to such as 
Keepalive
OpenWait
KeepWait
DeadTimer
SyncTimer
back-off
Where these appear in text in the I-D then I think that they should appear exactly as in the RFC.  YANG leaf names is trickier.  YANG does not do camelcase so I think that hyphenated is best e,g,
open-wait, keep-wait; keep-alive I am unsure about and note that the I-D has both with and without a hyphen which needs fixing

grouping pce-scope lacks the bit name as in the RFC, L, R, S, Rd, etc

leaf intra-area-pref {
does not say which is the higher pref and again lacks the names in the RFC

there are several 'domain' which is why the YANG convention is to make a list name plural with the leaf therein as singular lest you get a path with the same element repeated several times!

container capability
the reference should be to the IANA registry not the RFCs; in two leaf

NAI needs expanding in the text, SID too

container neigh
neigh is the sound that a horse makes but ....

list domain perhaps better as list domains as above

admin-status oper-status
did NMDA make this approach redundant?

There is an awful lot of 'when pcc or pcc-and-pce.
It would be lovely if the pcc-and-pce case could be represented with two values so that it becomes just when pcc; ditto pce

          leaf enabled {
            type boolean;
            description
              "Enabled or Disabled";
which is true?  I know, obvious, but I like stating the obvious

      leaf open-wait-timer {
the RFC says this is fixed not configurable.  If there is a reason to ignore the RFC then that needs to be spelt out IMO
      leaf keep-wait-timer {
ditto

      leaf dead-timer {
the RFC recommends a multiplier  not a value which I think better lest an operator increase the wait, forget to increase dead and so kills sessions

      leaf allow-negotiation {
default?

            Zero means that the PCEP
           entity will allow no Keepalive transmission at
           all.";
This seems like a bad idea.  If the peer is not allowed to send Keepalive then I would expect them to be greeted with an error message

            Zero means that
           the PCEP entity will allow not running a Dead
           timer.";
Likewise, if the peer wants to run a Deadtimer how can you stop them?

      leaf min-dead-timer {
and again.  I think that the underlying concepts need more consideration.  I see nothing like this in the RFC.

      leaf max-unknown-reqs {
I think that the RFC fixes this as five.

/"The PCEP association type";/"The PCEP Association Type";/
and the reference should be to IANA not RFC

/"PCEP Association Global Source.";/"PCEP Global Association Source.";/
as per RFC; this also occurs lower down

            leaf srp-id {
RFC8231 says 0 and ffffffff reserved, YANG does not.

/"The Path-key should be retreived";/"The Path-key should be retrieved";/

              case auth-tls {
                if-feature "tls";
                choice role {
                  description
                    "The role of the local entity";
                  case server {

what happens when entity is pcc and pce? the PCC client must be the TLS client but I do not know how this is handled.

.... appear transiently in this yang module. The
caps for YANG

              leaf dead-timer {
as above I like counts not times

              leaf overload-time {
in several places, does the time duration  have any meaning when there is no time of day to go with it to say when it started?

                      "The PST authorized";
I am unclear why this is 'authorized; who has said so?

  notification pcep-session-local-overload {
as above does this need a data and time?

/"Trigger the resyncrinization at the PCE";/"Trigger the resynchronization at the PCE";

       leaf avg-rsp-time {
I would find 
       leaf rsp-time-avg
clearer for this and the other two times

counters
do they need a discontinuity date and time?

       leaf num-keepalive-sent {
elsewhere keep-alive is hyphenated in YANG leaf names

5.2
/capcabilities/capabilities


There are parts of PCE I have not looked at previously and so plan to look at the RFC which is likely to generate further comments.

Tom Petch



A New Internet-Draft is available from the on-line Internet-Drafts directories.
This draft is a work item of the Path Computation Element WG of the IETF.

        Title           : A YANG Data Model for Path Computation Element Communications Protocol (PCEP)
        Authors         : Dhruv Dhody
                          Jonathan Hardwick
                          Vishnu Pavan Beeram
                          Jeff Tantsura
        Filename        : draft-ietf-pce-pcep-yang-16.txt
        Pages           : 112
        Date            : 2021-02-22

Abstract:
   This document defines a YANG data model for the management of Path
   Computation Element communications Protocol (PCEP) for communications
   between a Path Computation Client (PCC) and a Path Computation
   Element (PCE), or between two PCEs.  The data model includes
   configuration and state data.


The IETF datatracker status page for this draft is:
https://datatracker.ietf.org/doc/draft-ietf-pce-pcep-yang/

There are also htmlized versions available at:
https://tools.ietf.org/html/draft-ietf-pce-pcep-yang-16
https://datatracker.ietf.org/doc/html/draft-ietf-pce-pcep-yang-16

A diff from the previous version is available at:
https://www.ietf.org/rfcdiff?url2=draft-ietf-pce-pcep-yang-16


Please note that it may take a couple of minutes from the time of submission
until the htmlized version and diff are available at tools.ietf.org.

Internet-Drafts are also available by anonymous FTP at:
ftp://ftp.ietf.org/internet-drafts/


_______________________________________________
Pce mailing list
Pce@ietf.org
https://www.ietf.org/mailman/listinfo/pce