Return-Path: <pasi.sarolahti@iki.fi>
X-Original-To: pcn@ietfa.amsl.com
Delivered-To: pcn@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix)
 with ESMTP id 42F4521F9AEA; Tue,  1 Nov 2011 13:10:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.599
X-Spam-Level: 
X-Spam-Status: No, score=-102.599 tagged_above=-999 required=5
 tests=[BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com
 [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZTT48reg+5NU;
 Tue,  1 Nov 2011 13:10:52 -0700 (PDT)
Received: from smtp.netlab.hut.fi (luuri.netlab.hut.fi [130.233.154.177]) by
 ietfa.amsl.com (Postfix) with ESMTP id 74EC021F9AD4;
 Tue,  1 Nov 2011 13:10:52 -0700 (PDT)
Received: from localhost (localhost.localdomain [127.0.0.1]) by
 smtp.netlab.hut.fi (Postfix) with ESMTP id 32E6A1E14B;
 Tue,  1 Nov 2011 22:09:16 +0200 (EET)
X-Virus-Scanned: by amavisd-new at luuri.netlab.hut.fi
Received: from smtp.netlab.hut.fi ([127.0.0.1]) by localhost
 (luuri.netlab.hut.fi [127.0.0.1]) (amavisd-new, port 10024) with LMTP id
 0QQ-DR8fcoqC; Tue,  1 Nov 2011 22:09:12 +0200 (EET)
Received: from [192.168.1.66] (dsl-hkibrasgw4-fe5cdf00-46.dhcp.inet.fi
 [80.223.92.46]) by smtp.netlab.hut.fi (Postfix) with ESMTPSA id 5C4851E11D;
 Tue,  1 Nov 2011 22:09:12 +0200 (EET)
From: Pasi Sarolahti <pasi.sarolahti@iki.fi>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Date: Tue, 1 Nov 2011 22:09:11 +0200
Message-Id: <FFAE9ADC-5675-4A18-A9AB-CCFB2F317D3C@iki.fi>
To: pcn@ietf.org, draft-ietf-pcn-encoding-comparison@tools.ietf.org
Mime-Version: 1.0 (Apple Message framework v1084)
X-Mailer: Apple Mail (2.1084)
X-Mailman-Approved-At: Tue, 01 Nov 2011 14:52:07 -0700
Cc: tsv-ads@tools.ietf.org, TSV Dir <tsv-dir@ietf.org>
Subject: [PCN] tsv-dir review for draft-ietf-pcn-encoding-comparison-06
X-BeenThere: pcn@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: PCN WG list <pcn.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pcn>,
 <mailto:pcn-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/pcn>
List-Post: <mailto:pcn@ietf.org>
List-Help: <mailto:pcn-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pcn>,
 <mailto:pcn-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Nov 2011 20:10:53 -0000

Hello,

I've reviewed this document as part of the transport area directorate's =
ongoing effort to review key IETF documents. These comments were written =
primarily for the transport area directors, but are copied to the =
document's authors for their information and to allow them to address =
any issues raised. The authors should consider this review together with =
any other last-call comments they receive. Please always CC =
tsv-dir@ietf.org if you reply to or forward this review.

Summary: This draft is ready for publication as an Informational RFC =
(but see the editorial suggestions below)


Detailed comments:

* Introduction, para 4: "...design and applicability of PCN-based AC and =
FT." -- AC and FT have not been described (this is only done later, in =
the next section)

* Sec. 2.2.1, para 3: "If the proportion of re-marked (ThM- and ETM-) =
PCN traffic is larger than a CLE-limit..." -- CLE-limit is not =
introduced. It would be good to shortly describe it here, even if it is =
specified in another PCN document.

* Sec. 3.2.2, title: "Tunneling Rules for the Handling of the DSCP" -- =
the wording of the title feels inconvenient. For example, would =
"Tunneling rules for DSCP" be any better (or not)?

* end of sec 3.2.3: "Therefore, option (1) is selected." -- selected for =
what?

* Sec 3.3 -- it might be useful to shortly tell why it is ok to redefine =
ECN bits.

* Sec. 4, para 1: "PCN semantics apply only to one or at most two =
specific DSCPs, and therefore ECN semantics do not apply to them" -- =
this sentence is a bit difficult to parse. Could it be reworded somehow? =
The point is to say that ECN semantics do not apply to PCN DSCPs, or =
what?

* Figure 7 -- Are the PCN-n and PCN-m codepoints specified somewhere? If =
so, add a reference.

* Sec 4.1, para 2: "The 10-codepoint is reserved for experimental =
purposes" -- this is not consistent with table 7, where EXP is on 01 - =
column.

- Pasi

