Re: [pcp] Ben Campbell's No Objection on draft-ietf-pcp-port-set-12: (with COMMENT)

[<[e-mail]>]

Hi Ben,

Please see inline.

Cheers,
Med

> -----Message d'origine-----
> De : Ben Campbell [mailto:[e-mail]]
> Envoyé : vendredi 23 octobre 2015 00:59
> À : BOUCADAIR Mohamed IMT/OLN
> Cc : The IESG; [e-mail]; [e-mail];
> [e-mail]; [e-mail]
> Objet : Re: Ben Campbell's No Objection on draft-ietf-pcp-port-set-12:
> (with COMMENT)
> 
> Hi, thanks for the response. Comments inline. I removed sections that do
> not seem to need further discussion.
> 
> On 21 Oct 2015, at 1:51, [e-mail] wrote:
> 
> [...]
> 
> >> -----Message d'origine-----
> >> De : Ben Campbell [mailto:[e-mail]]
> 
> [...]
> >
> >>
> >> Why might the first internal port  in a response differ from the
> >> requested internal port? Even if the server could not map the entire
> >> range, wouldn't the first internal port still be the same?
> >
> > [Med] This is likely to be the case for most cases, but as indicated
> > in Section 5.2, there may be cases where this is not true. The
> > specification allows for both.
> 
> Ah, I see. I wasn't thinking about the discovery case.
> 
> >
> >>
> >> The statement that the internal and external set sizes will always be
> >> the
> >> same could use some elaboration. I assume this means the set sizes
> >> will
> >> match after mapping, _not_ that the external set size will always
> >> match
> >> the _requested_ set size.
> >
> > [Med] What about?
> >
> > OLD:
> > The two ranges always have the same size (i.e., the Port Set Size
> > returned by the PCP server).
> >
> > NEW:
> > The Internal Port Set and the Assigned External Port Set have the same
> > size.
> 
> I think the issue goes back to the first sentence of the paragraph,
> which is not clear whether we are talking about the Internal Port Set as
> requested, or as actually mapped.
> 
> How about something like:
> 
> OLD:
> The Internal Port Set is defined as being the range of Port Set Size
>     ports starting from the First Internal Port.  The External Port Set
>     is respectively defined as being the range of Port Set Size ports
>     starting from the Assigned External Port.  The two ranges always
> have
>     the same size (i.e., the Port Set Size returned by the PCP server).
> NEW:
> The Internal Port Set is defined as being the range of Port Set Size
>     ports starting from the Internal Port

[Med] The internal port set starts from the "First Intenal Port".

 returned
>     by the PCP server.

[Med] I'm not OK with this mention because the definition is used in the document for both request and response. 

 Similarly, the External Port Set
>     is is the range of Port Set Size ports
>     starting from the Assigned External Port.  The two ranges always
> have
>     the same size.
> 
> [...]

[Med] In order to make it clear the sentence is about a response I updated the text to:

"The Internal Port Set returned in a response and the Assigned External Port Set have the same size."

> 
> > Also, I assume you
> >> use port parity in terms of even/odd parity. It might be useful to
> >> state
> >> that somewhere.
> >
> > [Med] Updated as follows:
> >
> > OLD:
> >
> > "If parity preservation is required, the PCP client MUST set the
> > parity bit (to 1) to ask the PCP server to preserve the port parity."
> >
> > NEW:
> >
> > "If parity preservation is required (i.e., an even port to be mapped
> > to an even port, and an odd port to be mapped to an odd port), the PCP
> > client MUST set the parity bit (to 1) to ask the PCP server to
> > preserve the port parity."
> 
> I think that's helpful--but I also just noticed you have a reference to
> 4787 to explain this in section 4.
> 
> [...]