Re: [pcp] Review of draft-ietf-pcp-upnp-igd-interworking

<mohamed.boucadair@orange.com> Thu, 16 August 2012 08:24 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: pcp@ietfa.amsl.com
Delivered-To: pcp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 18C5121F84C2 for <pcp@ietfa.amsl.com>; Thu, 16 Aug 2012 01:24:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.343
X-Spam-Level:
X-Spam-Status: No, score=-1.343 tagged_above=-999 required=5 tests=[AWL=-0.495, BAYES_00=-2.599, HELO_EQ_FR=0.35, HTML_MESSAGE=0.001, J_CHICKENPOX_32=0.6, SARE_SUB_RAND_LETTRS4=0.799, UNPARSEABLE_RELAY=0.001]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oICXp3Li1CAf for <pcp@ietfa.amsl.com>; Thu, 16 Aug 2012 01:24:54 -0700 (PDT)
Received: from relais-inet.francetelecom.com (relais-ias92.francetelecom.com [193.251.215.92]) by ietfa.amsl.com (Postfix) with ESMTP id 1B00721F844E for <pcp@ietf.org>; Thu, 16 Aug 2012 01:24:53 -0700 (PDT)
Received: from omfedm07.si.francetelecom.fr (unknown [xx.xx.xx.3]) by omfedm10.si.francetelecom.fr (ESMTP service) with ESMTP id 34D9F2641F8; Thu, 16 Aug 2012 10:24:53 +0200 (CEST)
Received: from PUEXCH81.nanterre.francetelecom.fr (unknown [10.101.44.34]) by omfedm07.si.francetelecom.fr (ESMTP service) with ESMTP id 1599A4C06B; Thu, 16 Aug 2012 10:24:53 +0200 (CEST)
Received: from PUEXCB1B.nanterre.francetelecom.fr ([10.101.44.9]) by PUEXCH81.nanterre.francetelecom.fr ([10.101.44.34]) with mapi; Thu, 16 Aug 2012 10:24:35 +0200
From: <mohamed.boucadair@orange.com>
To: Xiaohong Deng <dxhbupt@gmail.com>, "draft-ietf-pcp-upnp-igd-interworking@tools.ietf.org" <draft-ietf-pcp-upnp-igd-interworking@tools.ietf.org>, "pcp@ietf.org" <pcp@ietf.org>
Date: Thu, 16 Aug 2012 10:24:34 +0200
Thread-Topic: [pcp] Review of draft-ietf-pcp-upnp-igd-interworking
Thread-Index: Ac16Vbv3MzHDIHiITW26OIOqggfULgBHxPOQ
Message-ID: <94C682931C08B048B7A8645303FDC9F36E4FC2DA35@PUEXCB1B.nanterre.francetelecom.fr>
References: <CANb4OckhpkQH_Wkqyb1T6uuAO8ugLWZHHb_8L69DVe3bP8kUmQ@mail.gmail.com>
In-Reply-To: <CANb4OckhpkQH_Wkqyb1T6uuAO8ugLWZHHb_8L69DVe3bP8kUmQ@mail.gmail.com>
Accept-Language: fr-FR
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: fr-FR
Content-Type: multipart/alternative; boundary="_000_94C682931C08B048B7A8645303FDC9F36E4FC2DA35PUEXCB1Bnante_"
MIME-Version: 1.0
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.8.16.74528
Subject: Re: [pcp] Review of draft-ietf-pcp-upnp-igd-interworking
X-BeenThere: pcp@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: PCP wg discussion list <pcp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pcp>, <mailto:pcp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/pcp>
List-Post: <mailto:pcp@ietf.org>
List-Help: <mailto:pcp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pcp>, <mailto:pcp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Aug 2012 08:24:56 -0000

Hi Xioahong,

Thank you for your review.

Please see inline.

Cheers
Med

________________________________
De : pcp-bounces@ietf.org [mailto:pcp-bounces@ietf.org] De la part de Xiaohong Deng
Envoyé : mardi 14 août 2012 21:48
À : draft-ietf-pcp-upnp-igd-interworking@tools.ietf.org; pcp@ietf.org
Objet : [pcp] Review of draft-ietf-pcp-upnp-igd-interworking

Hello authors and WG,

Here is my review of draft-ietf-pcp-upnp-igd-interworking-02.

Overall I think the draft is in a good shape, neat, easy to follow, and has a good architecture for WGLC. Below are a couple of questions and thoughts on text. Two types of them: the ones begin with +, are ones that, in my point of view, are worth to be addressed, and the ones begin with *, are minor ones that may make no significant difference. In both cases if I miss something, please elaborate and clarify. Thanks.


  Interworking Function (IGD-PCP IWF) is required to be embedded in CP
+ CP -> Customer Premises (CP)
[Med] I expanded the acronym.


   Triggers for deactivating the UPnP IGD-PCP Interworking Function from
   the IGD and relying on a PCP-only mode are out of scope of this
+ I'm not sure I understand exactly "Triggers for deactivating the UPnP IGD-PCP Interworking Function". what does that exactly mean? Deactivating the whole IWF or IGD?
[Med] The sentence is about de-activating the IWF. It is out of scope of this document to elaborate on conditions which may justify to de-activate the IWF in the IGD.



   (1)  Section 4.1 provides the mapping between WANIPConnection State
        Variables and PCP parameters;
+ would suggest using'correspondence' than 'mapping', as no mappings required to store in IGD for that, and also for lowering confusion with NAT mappings
[Med] Done.


      on a per UPnP CP basis.
+ UPnP CP -> UPnP Control Point?
[Med] Yes. I added an entry to Section 2.
 There are two 'CP' exit in the document, which I suppose stand for different things respectively.
[Med] The core text does not use CP but IGD. It appears only in the abstract.



   PortMappingEnabled:
      PCP does not support deactivating the dynamic NAT mapping since
      the initial goal of PCP is to ease the traversal of Carrier Grade
      NAT.  Supporting such per-subscriber function may overload the
      Carrier Grade NAT.
+ What if the customer wants to deactivate a static NAT mappings on CGN? it is not stated clearly that IWF should support it or not. My reading here is that for the same reason: not to overload the carrier Grade NAT, it should not support deactivate static mappings either. IMO,it's worth to state clearer that it applys to both static and dynamic mappings, if that is what text here means.
[Med] IGD spec says "PortMappingEnabled: This variable allows security conscious users to disable and enable dynamic NAT port mappings on the IGD.". PCP does not provide such feature.


      On reading the value is 1, writing a value different from 1 is not
      supported.
+ what if on reading the value is 0, which means deactivating the mapping?
[Med] see above. Only "1" is supported.


      Point, it must be resolved to an IP address by the Interworking
      Function when relying the message to the PCP Server.
+ Must? Does this mean IWF must have a DNS resolving function also?
[Med] No. This can be passed to a name resolution library.


   6 MALFORMED_OPTION:  501 "ActionFailed"
      Should not happen.
*It may happen when IWF is not correctly implemented, mistached version of implementation with PCP server, and extra.
[Med] Yes; but there is no need to list when it can occur.


   7 NETWORK_FAILURE:  Not applicable
      Should not happen after communication was successfully established
     with a PCP Server.
*What if IWF/PCP Client fails to establish communication with a PCP server? In that case, I see that "ActionFailed" looks like the semantical correspondence.
[Med] If the IWF fails to establish a communication with the PCP Server, then no error is received. An error should be generated locally by the IWF and sent back to the UPnP CP. I updated section 5.7.1 and section 5.7.2 to indicate "501" error code is returned when the IWF fails to contact its PCP Server.



      Note: According to some experiments, some UPnP 1.0
      implementations, e.g., uTorrent, simply try the same external port
      X times (usually 4 times) and then fail.  Also note that some
      applications uses GetSpecificPortMapping() to check whether a
      mapping exists.
*Behavior of uTorrent is more like following: it tries GetSpecificPortMapping X times (usually 4 times),if it finds an external port not being used before X times, it will call AddPortMapping
[Med] I updated the text to indicate the behaviour when a port is not in use. Thanks.



   Upon receipt of GetSpecificPortMappingEntry() from a UPnP Control
   Point, the IGD-PCP IWF MUST check first if the external port number
   is used by the requesting UPnP Control Point.  If the external port
   is already in use by the requesting UPnP Control Point, the IGD-PCP
   IWF MUST send back a positive answer.  If not, the IGD-PCP IWF MUST

*or more precisely: IWF MUST send back mapping entires specified by the unique tuple of ExternalPort and PortMappingProtocol.
[Med] I prefer the initial wording without detailing the content of the response. The exact content of the response is part of the UPnP spec.


   relay to the PCP Server a MAP request, with short lifetime (e.g.,
   60s), including a PREFER_FAILURE Option.  If the requested external
   port is in use, a PCP error message will be sent by the PCP Server to
   the IGD-PCP IWF indicating CANNOT_PROVIDE_EXTERNAL as the error
   cause.  Then, the IGD-PCP IWF relays a negative message to the UPnP
   Control Point.  If the port is not in use, the mapping will be

+ if CANNOT-PROVIDE_EXTERNAL is returned from PCP server, it means the enquired external port is being used: for example, enquired external port is being used by another customer sharing the same external IP. Since one of major usage of GetSpecificPortMappingEntry() is for UPnP control point to find out if an external port is  available, how about using 718 "ConflictInMappingEntry"? which, to my eyes, provides a better semantic in this context.
[Med] Are you sure 718 error code is allowed for GetSpecificPortMappingEntry?


   created by the PCP Server and a positive response will be sent back
   to the IGD-PCP IWF.  Once received by the IGD-PCP IWF, it MUST relay
   a negative message to the UPnP Control Point indicating
   NoSuchEntryInArray as error code.

*Since this is a somehow complicated to be understood case, add something like below may make it slightly clearer:

it MUST relay a negative message to the UPnP Control Point indicating NoSuchEntryInArray as error code so that the UPnP control point knows the enquired mapping doesn't exist.
[Med] Updated. Thanks.

Cheers,
-Xiaohong
<http://fr.linkedin.com/pub/xiaohong-deng/28/577/599>