[pim] AD Review of draft-ietf-pim-igmp-mld-yang-06
Alvaro Retana <aretana.ietf@gmail.com> Mon, 29 January 2018 20:59 UTC
Return-Path: <aretana.ietf@gmail.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 531F8131936; Mon, 29 Jan 2018 12:59:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GhHwCGleW7r1; Mon, 29 Jan 2018 12:59:55 -0800 (PST)
Received: from mail-oi0-x243.google.com (mail-oi0-x243.google.com [IPv6:2607:f8b0:4003:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1BACF131933; Mon, 29 Jan 2018 12:59:54 -0800 (PST)
Received: by mail-oi0-x243.google.com with SMTP id c8so6133682oiy.9; Mon, 29 Jan 2018 12:59:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:date:message-id:subject:to:cc; bh=/9iqhox2YsmRE9cxGX2F8XGJZOKCwUgco5y1HmWBaXU=; b=ICBce/UDpjwBmLO5msObIFnCF9s4wnLwJ/SbdtCdPtbKm4p9X0Q0A/VBs9uIyCX2vd Wkr8xkPhCn5/QPUddcnZLi4qHtJoaMA2F283YQ0M0YWs5KKx6CQkyJiuxekzKHGDMe2b RJtqdx28cK+mN9NkMOaIGPltBLTJu7xpsc6InbgERm1Fa0o13STmoDPqaA3sueLKieA+ x5AwZtKnsLUaOZfeIjdwfxvG5tTzhjM5/1Lnru88PqVEluPfUVEPO5ryF8lWIj8+gAiF M9Mp3eoUo53IYncvXRlPSi2/cAvpZb/fb3y1bLqQX2AZRvsJERXiTeY1lmTj9Hr/bdXs LgwA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to:cc; bh=/9iqhox2YsmRE9cxGX2F8XGJZOKCwUgco5y1HmWBaXU=; b=P4UAJ0Kb7c+mlSTxiNZxmyLR875/pFF9oqBLXaWdBR8WuSkZr4VFc7RMeZWkH28rFw aRpFSI7F6sCtUNVtBjlwriibD1rJ8+/JeLJaOhQgLcm9XUE6+VOtlClBN2i3T3SE3d2s MECZmhmTKuUT0hGVrjSbulTUVwBY7euoB3SBeyOe7RVRT1VZnY8K12rstRxGqo2YcQYb 27c+oGOV4FYWQrs7+SwHdeh9cYthtHwloTjhQB5cAU58zCybNB8e8Sj1k9+5BD+v/otY 3/oIDDXZMpvMmO9FMRFjJlYi3S7kbjPsvl+RZ0PDHWUcLyp1hdENuf18YwxbEnYSqesL g0mQ==
X-Gm-Message-State: AKwxytfHdB8Zs9ALVVnq0AoL6k6DoqhX99VwAI/5iB+dD+KIQj8ZwMzI OiOEdgLVpm3uAp7eSp2R5j0tL7iFcnugReGAWBM=
X-Google-Smtp-Source: AH8x227N1FCf1+6WFxWbUZtCceYw6tPFAlbvpxnZvgeJMIPx7LJUjmiFLXxPdSPzbHHRfuft52rIKJxzojpPwBu5nfk=
X-Received: by 10.202.237.134 with SMTP id l128mr19972150oih.109.1517259593281; Mon, 29 Jan 2018 12:59:53 -0800 (PST)
Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Mon, 29 Jan 2018 12:59:52 -0800
From: Alvaro Retana <aretana.ietf@gmail.com>
X-Mailer: Airmail (467)
MIME-Version: 1.0
Date: Mon, 29 Jan 2018 12:59:52 -0800
Message-ID: <CAMMESsxNDOU0p7+-xDJoTuzx8d6Zi5ebTvNiMrp2ht-ztZL8eg@mail.gmail.com>
To: draft-ietf-pim-igmp-mld-yang@ietf.org
Cc: pim@ietf.org, pim-chairs@ietf.org, Stig Venaas <stig@venaas.com>
Content-Type: multipart/alternative; boundary="001a113df02e16f5e90563f087e8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/30skJ_rUg5sYec2OHi4pWJhA2cc>
Subject: [pim] AD Review of draft-ietf-pim-igmp-mld-yang-06
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jan 2018 20:59:57 -0000
Dear authors: I just finished reviewing this document. I have some comments (below) that I need addressed before we can start the IETF Last Call, and another YANG Dr review. Thanks! Alvaro. M1. It looks like the document doesn't follow all the recommendations from rfc6087bis, specifically related to the Security Considerations [1] and the Tree Diagram, where we need something similar to [2]. M2. References: M2.1. Please take a look at the Nits [3], as there are several out of date and unused references. M2.2. In general, we don't need to reference both the current a bis versions; rfc8022/rfc8022bis, for example. M2.3. There's no reference to or mention of draft-ietf-netmod-revised-datastores, which may be a better reference than I-D.dsdt-nmda-guidelines. M2.4. Some of the references (rfc7223bis, for example) are not formatted correctly. M2.5. The references to IGMP/MLD should be Normative: "The model covers IGMPv1 [RFC1112], IGMPv2 [RFC2236], IGMPv3 [RFC3376] and MLDv1 [RFC2710], MLDv2 [RFC3810]."...and rfc5790. [1] https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-16#section-3.7.1 [2] https://tools.ietf.org/html/draft-ietf-netmod-rfc7223bis-02#section-1.3 [3] https://tools.ietf.org/idnits?url=https://tools.ietf.org/id/draft-ietf-pim-igmp-mld-yang-06.txt
- [pim] AD Review of draft-ietf-pim-igmp-mld-yang-06 Alvaro Retana