Re: [pim] [secdir] Secdir last call review ofdraft-ietf-pim-msdp-yang-12

Benjamin Kaduk <kaduk@mit.edu> Mon, 03 February 2020 04:24 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EBFE012089D; Sun, 2 Feb 2020 20:24:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PLSZh3NVLt91; Sun, 2 Feb 2020 20:24:28 -0800 (PST)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2A4BE120890; Sun, 2 Feb 2020 20:24:28 -0800 (PST)
Received: from kduck.mit.edu ([24.16.140.251]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0134ONgR000370 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 2 Feb 2020 23:24:25 -0500
Date: Sun, 2 Feb 2020 20:24:22 -0800
From: Benjamin Kaduk <kaduk@mit.edu>
To: zhang.zheng@zte.com.cn
Cc: vincent.roca@inria.fr, last-call@ietf.org, draft-ietf-pim-msdp-yang.all@ietf.org, pim@ietf.org, secdir@ietf.org
Message-ID: <20200203042422.GN91553@kduck.mit.edu>
References: <20200202160816.GK91553@kduck.mit.edu> <202002030833550333378@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202002030833550333378@zte.com.cn>
User-Agent: Mutt/1.12.1 (2019-06-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/5FNg5uwx-0cihuREkV-W5FhsuEQ>
Subject: Re: [pim] [secdir] Secdir last call review ofdraft-ietf-pim-msdp-yang-12
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Feb 2020 04:24:30 -0000

Hi Sandy,

No, you should not delete the sentence. We should keep the standard
template as-is.

-Ben

On Mon, Feb 03, 2020 at 08:33:55AM +0800, zhang.zheng@zte.com.cn wrote:
> Hi Ben, Vincent,
> 
> 
> 
> 
> 
> 
> Thank you very much for your review!
> 
> 
> Yes. This sentence means that all the configurable leaves in the model.
> 
> 
> 
> Should I delete this sentence to avoid misunderstanding?
> 
> 
> 
> 
> 
> 
> Best regards,
> 
> 
> Sandy
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 原始邮件
> 
> 
> 
> 发件人:BenjaminKaduk <kaduk@mit.edu>
> 收件人:Vincent Roca <vincent.roca@inria.fr>fr>;
> 抄送人:last-call@ietf.org <last-call@ietf.org>;draft-ietf-pim-msdp-yang.all@ietf.org <draft-ietf-pim-msdp-yang.all@ietf.org>;pim@ietf.org <pim@ietf.org>;secdir@ietf.org <secdir@ietf.org>rg>;
> 日 期 :2020年02月03日 00:08
> 主 题 :Re: [pim] [secdir] Secdir last call review ofdraft-ietf-pim-msdp-yang-12
> 
> 
> 
> 
> Hi Vincent,
> 
> Thanks for doing the review!
> 
> On Wed, Jan 29, 2020 at 12:18:11AM -0800, Vincent Roca via Datatracker wrote:
> > Reviewer: Vincent Roca
> > Review result: Has Nits
> > 
> > Hello,
> > 
> > I have reviewed this document as part of the security directorate’s ongoing
> > effort to review all IETF documents being processed by the IESG. These
> > comments were written primarily for the benefit of the security area
> > directors.  Document editors and WG chairs should treat these comments just
> > like any other last call comments.
> > 
> > Summary: Ready with nits
> > 
> > The security considerations section is globally well writen and addresses
> > important topics. I don't have major comments.
> > 
> > Details:
> > - it is said that "(i.e., config true, which is the default)".
> >   I've searched in the YANG model and only found "config false" entries which
> >   seems to contradict what is said in section 5.
> 
> I think the idea is that you never actually say "config true", and rather
> just omit any 'config' statement to get the default (writeable) behavior.
> So I think there are still writeable leaves in this module.
> 
> -Ben
> 
> > - Section 2.1 says: "This model can be used to configure and manage MSDP
> > protocols." (with a final "s") which suggests there could be several MSDP
> > protocols. I think it's a mistake.
> > 
> > Cheers,    Vincent
> > 
> > _______________________________________________
> > secdir mailing list
> > secdir@ietf.org
> > https://www.ietf.org/mailman/listinfo/secdir
> > wiki: http://tools.ietf.org/area/sec/trac/wiki/SecDirReview
> 
> _______________________________________________
> pim mailing list
> pim@ietf.org
> https://www.ietf.org/mailman/listinfo/pim