Re: [pim] Fw: I-D Action: draft-ietf-pim-msdp-yang-16.txt

Benjamin Kaduk <kaduk@mit.edu> Tue, 24 March 2020 03:06 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4AE823A0F21; Mon, 23 Mar 2020 20:06:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mb3dl7YER9x5; Mon, 23 Mar 2020 20:06:46 -0700 (PDT)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 047203A0EDA; Mon, 23 Mar 2020 20:06:44 -0700 (PDT)
Received: from kduck.mit.edu ([24.16.140.251]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 02O36Vwd003295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Mar 2020 23:06:34 -0400
Date: Mon, 23 Mar 2020 20:06:31 -0700
From: Benjamin Kaduk <kaduk@mit.edu>
To: zhang.zheng@zte.com.cn
Cc: rdd@cert.org, barryleiba@computer.org, rwilton@cisco.com, aretana.ietf@gmail.com, rrahman@cisco.com, pim-chairs@ietf.org, pim@ietf.org
Message-ID: <20200324030631.GQ50174@kduck.mit.edu>
References: <202003091145456269025@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202003091145456269025@zte.com.cn>
User-Agent: Mutt/1.12.1 (2019-06-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/5f2Oj9sfkeSjWCKNWmvKKWe_3Ac>
Subject: Re: [pim] Fw: I-D Action: draft-ietf-pim-msdp-yang-16.txt
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2020 03:06:53 -0000

Hi Sandy,

I see that the YANG module has been updated to use must
"derived-from-or-self(., 'key-chain:md5')" for the algorithm associated
with the password to attempt to indicate that TCP-MD5 is the only currently
defined mechanism, but I don't think this fully addresses my point.

(First off, using key-chain:md5 as an indicator to use keyed MD5 for
TCP-MD5 is rather an abuse of the identifier -- md5 is a hash algorithm,
and just saying "MD5" does not indicate a particular keyed hash usage or
that TCP-MD5 should be used, though I can probably grudgingly accept that
this has become convention.)

Shouldn't the description refer to TCP-MD5, not just "the md5 algorithm",
ideally with a section reference to where using TCP-MD5 for MSDP is
discussed?

I note that using this "must derived-from-or-self" basically requires the
YANG module to be revised if some future security service is defined for
MSDP, when otherwise an abstract crypto-algorithm identifier might be
usable without modifying the module.  This perhaps has pros and cons, but
I don't have a sense for what discussion occurred about this choice.

Also, the security considerations puts the "key" node in the *readable*
configuration section, but it seems to be both readable and writeable, so I
think the discussion needs to be expanded and relocated.


Finally, could you clarify what changes were made to address my point about
the reference time for elements in the "state-attributes" container?  That
grouping has moved to a different location in the module so the diff is not
very helpful.

Thanks,

Ben

On Mon, Mar 09, 2020 at 11:45:45AM +0800, zhang.zheng@zte.com.cn wrote:
> Hi Ben, Roman, Barry, Rob, Alvaro, Reshad,
> 
> 
> 
> 
> 
> 
> Thank you very much for your comments and modification suggestions.
> 
> 
> And many thanks to everyone who give us suggestions.
> 
> 
> We updated the draft to 16 version.
> 
> 
> Please review it. Hope this verson can be well.
> 
> 
> 
> 
> 
> 
> Best regards,
> 
> 
> 
> Sandy
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 原始邮件
> 
> 
> 
> 发件人:internet-drafts@ietf.org <internet-drafts@ietf.org>
> 收件人:i-d-announce@ietf.org <i-d-announce@ietf.org>rg>;
> 抄送人:pim@ietf.org <pim@ietf.org>rg>;
> 日 期 :2020年03月09日 11:26
> 主 题 :[pim] I-D Action: draft-ietf-pim-msdp-yang-16.txt
> 
> 
> 
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the Protocols for IP Multicast WG of the IETF.
> 
>         Title           : A YANG Data Model for Multicast Source Discovery Protocol (MSDP)
>         Authors         : Xufeng Liu
>                           Zheng Zhang
>                           Anish Peter
>                           Mahesh Sivakumar
>                           Feng Guo
>                           Pete McAllister
>     Filename        : draft-ietf-pim-msdp-yang-16.txt
>     Pages           : 34
>     Date            : 2020-03-08
> 
> Abstract:
>    This document defines a YANG data model for the configuration and
>    management of Multicast Source Discovery Protocol (MSDP) Protocol.
> 
> 
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-pim-msdp-yang/
> 
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-pim-msdp-yang-16
> https://datatracker.ietf.org/doc/html/draft-ietf-pim-msdp-yang-16
> 
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-pim-msdp-yang-16
> 
> 
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
> 
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
> 
> 
> _______________________________________________
> pim mailing list
> pim@ietf.org
> https://www.ietf.org/mailman/listinfo/pim