Re: [pim] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-05
Hongji Zhao <hongji.zhao@ericsson.com> Thu, 18 October 2018 03:44 UTC
Return-Path: <hongji.zhao@ericsson.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 80DD9120072 for <pim@ietfa.amsl.com>; Wed, 17 Oct 2018 20:44:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.364
X-Spam-Level:
X-Spam-Status: No, score=-4.364 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.064, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=RB1B/YkF; dkim=pass (1024-bit key) header.d=ericsson.com header.b=lBGujP2n
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9pJFFXLDKDdx for <pim@ietfa.amsl.com>; Wed, 17 Oct 2018 20:44:32 -0700 (PDT)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 21A4E126BED for <pim@ietf.org>; Wed, 17 Oct 2018 20:44:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1539834270; x=1542426270; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pafaVBHzxmE2tOoDEvwHtFjISQKcTFKTxIWD3wt484U=; b=RB1B/YkFc5q0kaFH41sTcoyq4hrspsF+aiwct2oHwPAS7tmRQptmbL+AS5HV3WgT 7GIQD4MuSXENskNWMtYuqo9KB/Fg2dKtwQS8Oq0si7C36VM/LhRpVGTVlRIzQm2B HgMnk3N4oPCY0HA2ZMfDWfr2FIlU+TLyGjZgmB/pEWw=;
X-AuditID: c1b4fb2d-b4fff70000003a27-42-5bc8019e3905
Received: from ESESBMB501.ericsson.se (Unknown_Domain [153.88.183.114]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 73.82.14887.E9108CB5; Thu, 18 Oct 2018 05:44:30 +0200 (CEST)
Received: from ESESSMB503.ericsson.se (153.88.183.164) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 18 Oct 2018 05:44:29 +0200
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB503.ericsson.se (153.88.183.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Thu, 18 Oct 2018 05:44:29 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pafaVBHzxmE2tOoDEvwHtFjISQKcTFKTxIWD3wt484U=; b=lBGujP2np3EKlurFiT8zgmcL6BnJ9nCW7MrFyPB9m4huTZqQd7cG7GUnjK9qcUyEZV2WCBfGNdgFirByuD9Yj+7rjgb/lSLYpXP5zkM6dvMOq5A4XgFvAqSd2dnxxH47GRGDjjFbvkYtk4QujMA28C4Hpv8zZz5776XdQtKfRsI=
Received: from VI1PR07MB4192.eurprd07.prod.outlook.com (20.176.6.29) by VI1PR07MB1376.eurprd07.prod.outlook.com (10.164.92.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.20; Thu, 18 Oct 2018 03:44:28 +0000
Received: from VI1PR07MB4192.eurprd07.prod.outlook.com ([fe80::7d44:9062:8cce:6abf]) by VI1PR07MB4192.eurprd07.prod.outlook.com ([fe80::7d44:9062:8cce:6abf%2]) with mapi id 15.20.1250.020; Thu, 18 Oct 2018 03:44:28 +0000
From: Hongji Zhao <hongji.zhao@ericsson.com>
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
CC: "pim@ietf.org" <pim@ietf.org>, YANG Doctors <yang-doctors@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-05
Thread-Index: AQHUZkNsLOM6Zagayk61DqKTE7CU6qUkWsPA
Date: Thu, 18 Oct 2018 03:44:28 +0000
Message-ID: <VI1PR07MB4192189BF36A749AED4D497396F80@VI1PR07MB4192.eurprd07.prod.outlook.com>
References: <B7E291AA-E083-4D86-B9A7-5A8400714179@cisco.com>
In-Reply-To: <B7E291AA-E083-4D86-B9A7-5A8400714179@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [106.38.5.8]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR07MB1376; 6:tGSSBPnuXyckbuRqScYN4DdjUNrPzV103Qp73gqShDoI1sCPFy8xycM7z7Nd0majV0ufxqsjhVxS3Ms5AXINsB5R/YZdNGTieDM2zjN/Tq9K9O5GmwvcfH8i6JQ/k9+wFDNNFwID9ULyTs6a7Lw14fJYyaGVTg+1QtmFLeUubiSt8p4mz1XWZQREemfEZ03vhHef4+ego94WJfofxz9cMAsj2WwOIHY7qCEYpKjWbQiv8pWg80e7R9iMMJNz5Auq6hsCV58xpCImPkrxthrNdmZa+8M19OKwClstmigvNsSPG6vHbXAf1HIA6rXmJqNdzEvaQUceg92AEB6NynmksvWFWQw/KWdohylskF1JIE2xP9fk4s8Pq8RTR+5God91DHf0BaAASuxQIfGtTgn8EymuD4sOYo4ODuk9E6SG4a7vK5s/6Q5AVgFhgIhcHmpCBC90sOxCx/9aRJSG4MgFWQ==; 5:gKIPoMqlp3zcCsKAER0L0VbQlxXIV1gxhWy5nMmFaAvvhrXCXKwLK34QboRhPUDoVZfLvKT0+KuMWa5Jzw7mU58aXH08lzg+d+N1bsayMW9UUHkqfTsl+vACxV6Hl71HS0t4RSVlzb6QVapMEhMbDoVecgdDsr500Jqqusko+pE=; 7:VP3czKvUmI+jjhOu5YtOlEHX5YGnTziS8MG5a3YPCDaCy1pqJ+dxjxSakJyXgDE9gQ2pXbgLpc0tX4MKnKUZVJLUAB9kDc/PBvr3J42kIlD1J6P+5Ky1bvV6HcleAlVG4lcqNjTmU02zNfYd39WuMlZBKqcfC3KV+Z1YCwpaDIt98qrw7BUAYQy2XvrpWL7Xu1e4GEdb5hB5B7+4kVivn0PhAdrpV3fugsRnteiLVb4inzhVwQvCV78YthSy8ksI
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: b9e33004-9a4a-4a57-7919-08d634ac01a5
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:VI1PR07MB1376;
x-ms-traffictypediagnostic: VI1PR07MB1376:
x-microsoft-antispam-prvs: <VI1PR07MB13763CCB50E35A157320AA8496F80@VI1PR07MB1376.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(114627819485645)(95692535739014)(37575265505322)(248295561703944)(120809045254105)(21748063052155)(28532068793085)(190501279198761)(227612066756510);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(149066)(150057)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:VI1PR07MB1376; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB1376;
x-forefront-prvs: 08296C9B35
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(376002)(366004)(396003)(39860400002)(189003)(199004)(6306002)(54896002)(236005)(14454004)(55016002)(68736007)(478600001)(25786009)(256004)(4326008)(99286004)(44832011)(446003)(11346002)(486006)(476003)(53546011)(6506007)(9686003)(966005)(9326002)(8936002)(86362001)(2906002)(606006)(790700001)(6116002)(3846002)(53936002)(6246003)(54906003)(71200400001)(71190400001)(6436002)(33656002)(8676002)(6346003)(7696005)(316002)(105586002)(106356001)(5250100002)(229853002)(102836004)(74316002)(81166006)(81156014)(97736004)(19609705001)(26005)(76176011)(2900100001)(186003)(7736002)(5660300001)(66066001)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR07MB1376; H:VI1PR07MB4192.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=hongji.zhao@ericsson.com;
x-microsoft-antispam-message-info: 1ZZD4ByZAnKywDw4MnW9XK68VUUVbuBqIoEoYKp7SUEE8HY9I03Ktr+wNnmWLDb8eeYIb0tKZUPKMcWtNQkVVn7QEsyI1BF1FT1InP9Oc/2+OpwVgNGMmnN5Ca1+gbWX4MuoQBmX1P8PfvBXc4h7HojvlUrnfGZ/SThbz4JjHMDRMQfJciAbujkkDeTJ4Z5CjbXZNkj+GZ08ilfSMGO9PQ1bLEkGV1dy8+spPhaqcOPPL8jF/gtSlD4i4YaPN6F/d24YFWs9C1LgxU2mWpkY0kDzRKOoXSFvbSrqD6aag+fk3pKAenFKv35Yor92Q4xX403cPALTc/Y3oMy0698Za1ry2wpIUZlEHiNYBdZpzWc=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_VI1PR07MB4192189BF36A749AED4D497396F80VI1PR07MB4192eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b9e33004-9a4a-4a57-7919-08d634ac01a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2018 03:44:28.5884 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB1376
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHe885247Lweua+WQXaiGk5LzkByntQoH2IZAKCg1z5EnnZbMd FQ1BQe3iMtS2D05Ti0neUkrnrdlqGNMghNBllh+mJomaRjotM9t2FPz2e/7///u+z/Pw0qS4 jedLK5SZjFopT5PyhVTl1S51YA0aiAuusHuGL9k/k+G2hmJB+MPeN+g0Ga1de8GLNhh+EzFE rDAikUlTZDPqoJMJwuThoioio8OOcu4OdfELkOkLKkEeNOAwMPb3u1mM3yGot50rQUInOxA8 fT6PuMJAgL5wiHQVFC4j4ZvZJuCccgJmCttJrphAMKCrI1yX8fFRuK8xOg2aluAQ+NNywoUk joKxzn2uxC58CYwdfXwXS/BlmDFoKY5Doba+0c0U9oPB0ScCF4vwNVgpsvG5ViOgcXnJrXvg SNA6mt06wrth5X2LuwMS+8DYVC3BjYnBYHIN4GJvmJn8x+P4AHxvfbSp74ePtRr3xIBfC6Cq emNzR4GwqNNthi5Au/kVxYWsCBYLzALOCICpGhvFcSo0/FwguZAZwY/VObT1XFOpffO0mYSa Ci0qQ8H6be3q3VtSwYPyg3r31F4wWDlFcbI/tPUGcelDoNXYBRwfgeLqx4Lteh0SNCFvlmHZ 9KTQYzJGrbjBsiqlTMlkvkTOb/S2Yy2wGzXPnrEgTCOpp2j5rzVOzJNns7npFgQ0KZWIqCqn JEqU595m1Krr6qw0hrWgvTQl9RHJmkyxYpwkz2RSGSaDUW+5BO3hW4DuLGbqvHr7nlhazvt+ sA6MO0Z7LsbfPLsgTpk/3F4yEd+aBeGflIYdwz0xK555x4utObL88fWUsCWlKW+PcXrV37Z6 L2p25Jl3QPccG+SpnzDnX/ll7VQ4wvK6YlhxpDHYojJVdvTd2pB2Fk6PrPtqJk1fT2mI0VK/ nakJEkJKscnykABSzcr/A5H1ttpCAwAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/8KV9lzD50b4ejvIhrXZT__gVwQk>
Subject: Re: [pim] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-05
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Oct 2018 03:44:36 -0000
Hi Reshad,
Thanks a lot for your review.
Regarding tje main issues/questions:
* igmp-snooping-instances (mld- also) are top level containers, I believe they should be under rt:control-plane-protocol (RFC8349). I should have raised this in the previous review.
------------------------I think it is ok, and will move igmp-snooping-instances under rt:control-plane-protocol
* Should there be a dependency on draft-ietf-pim-igmp-mld-yang, e.g. should we allow IGMP/MLD snooping configuration only if IGMP/MLD is enabled (leaf “enable”) or supported (feature-mld and feature-igmp)? E.g. I don’t think it makes sense to configure igmp-snooping if igmp is not supported.
-------------------------I think there is no dependency on draft-ietf-pim-igmp-mld-yang
IGMP is enabled on L3 router, but IGMP Snooping is enabled on L2 switch. The switch snoops into IGMP Report and generates the mapping between port and Multicast MAC Address.
The IGMP Report is sent by host, passes the L2 switch, and to the L3 router.
So you can configure the IGMP snooping when IGMP is not enabled or supported.
In the current implementation of IGMP snooping, both Cisco and Huawei don’t need IGMP enabled. (https://www.cisco.com/c/en/us/td/docs/routers/7600/ios/15S/configuration/guide/7600_15_0s_book/snooigmp.html)
Regarding other comments, I will research them and modify the draft ASAP. Thanks a lot!
BR/Hongji
赵宏吉
From: Reshad Rahman (rrahman) <rrahman@cisco.com>
Sent: Thursday, October 18, 2018 2:01 AM
To: Hongji Zhao <hongji.zhao@ericsson.com>
Cc: pim@ietf.org; YANG Doctors <yang-doctors@ietf.org>
Subject: Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-05
Hi Hongji,
I have reviewed rev-05 (revised the existing review), see https://datatracker.ietf.org/doc/review-ietf-pim-igmp-mld-snooping-yang-03-yangdoctors-early-rahman-2018-06-28/
…
…
- Re: [pim] Yangdoctors early review of draft-ietf-… Hongji Zhao
- Re: [pim] Yangdoctors early review of draft-ietf-… Reshad Rahman (rrahman)