Re: [pim] [Last-Call] Last Call: <draft-ietf-pim-igmp-mld-snooping-yang-12.txt> (A Yang Data Model for IGMP and MLD Snooping) to Proposed Standard

tom petch <daedulus@btconnect.com> Mon, 22 June 2020 11:23 UTC

Return-Path: <daedulus@btconnect.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ABB373A0C0B; Mon, 22 Jun 2020 04:23:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YtGVvpmXskO9; Mon, 22 Jun 2020 04:23:11 -0700 (PDT)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60125.outbound.protection.outlook.com [40.107.6.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B51F73A0C07; Mon, 22 Jun 2020 04:23:10 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BYPQf2WIW7A4wmANfCYHGToAFRNnNcD9PXIGXw201rutzQbRy7lWnyEEe2/FTjURsqUB3VRvuMiRm1/+QaPKlc6n6hSLlE+fx3vECiqNljN/NeD9DlEAd0UsaXf4F4WkZy4wI5vXO9+lgWR3SPsGlKQAmnQB3pCqGnbgSNxszcykXHNSSTCRTc0H50jw10J6Yuz1yQpf1SwKp0+Tj0rANywj1tXTMe+evx++kXA7jk1sM2dLYx6kmCjj0oDn82uEmiMEaQj7QzsBliqMvRfYq02MytFovTyoO2gv7JKQN/ZU44+GAOhdPm2nsuvy772lf2++tnaHB1HCTVP04MMm/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6I7J6xXt13Li/F7WIm5j0K+HktIbZpfa5R8X6sYEYdk=; b=ad5O57tJvP/zI2wBfgEgV2Czk9wNIYtYbcKrLvL+GitCW32HuRGbheTqNjIYDJde4c7hASp/2rbAqkCY25Tyz4OMsGDw192gZhZSoXPV/3GH1j+U38/blhGf3qhwcKokRK8Jq1fTK4ADpMdP0RLHHk6qhqHnDIrb4bXWIuE2CBMz0BiYAD5hRZn99TFHb1ORrXx9HT6wy9wkdb2jMjjySIYlLRWasg34QCdLLflAZjnpgHBadJAxXtHhNGO5wlkW60esmStZv8E9BfolJY7jf2AUAc+fvVSPr2h85fgvZuRdenPBFrMqsBUmGf2I20YLt22CvEEznINfEK7+lK9hAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6I7J6xXt13Li/F7WIm5j0K+HktIbZpfa5R8X6sYEYdk=; b=FsyNFzZXsPPGf2lrBgrnQXk754XfmNY0EH60w/PIRD0yD8ShbdHTwaEUSl64LYjngMOVo06AzbjdqJdtU6cLK7epHpoVMAcs8FhuhvrMbtqEashBN67axyku4HQpNO78Udh4CwyFWAvl39QT3AuRy3bFY63GllLZO/iGcRHuWEc=
Authentication-Results: btconnect.com; dkim=none (message not signed) header.d=none;btconnect.com; dmarc=none action=none header.from=btconnect.com;
Received: from VI1PR07MB6704.eurprd07.prod.outlook.com (2603:10a6:800:18b::8) by VI1PR07MB6542.eurprd07.prod.outlook.com (2603:10a6:800:179::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.13; Mon, 22 Jun 2020 11:23:08 +0000
Received: from VI1PR07MB6704.eurprd07.prod.outlook.com ([fe80::bc6a:1add:e84e:f19b]) by VI1PR07MB6704.eurprd07.prod.outlook.com ([fe80::bc6a:1add:e84e:f19b%9]) with mapi id 15.20.3131.017; Mon, 22 Jun 2020 11:23:08 +0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
References: <159101702558.32435.15616119449036382064@ietfa.amsl.com> <DB6PR0701MB211826971407DCB2A99998D7CE830@DB6PR0701MB2118.eurprd07.prod.outlook.com> <1UWB4IgZSy.11NOwQkWKz1@pc8xp> <5EE21354.7020400@btconnect.com>
Date: Mon, 22 Jun 2020 12:22:58 +0100
Message-ID: <1UWBHOe8zv.11lIAssJfau@pc8xp>
In-Reply-To: <5EE21354.7020400@btconnect.com>
From: "tom petch" <daedulus@btconnect.com>
To: "tom petch" <daedulus@btconnect.com>, "last-call@ietf.org" <last-call@ietf.org>, "pim@ietf.org" <pim@ietf.org>
User-Agent: OEClassic/3.0 (WinXP.2600; F; 2019-11-28)
X-ClientProxiedBy: LO2P265CA0105.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::21) To VI1PR07MB6704.eurprd07.prod.outlook.com (2603:10a6:800:18b::8)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from pc8xp (86.128.101.145) by LO2P265CA0105.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.25 via Frontend Transport; Mon, 22 Jun 2020 11:23:07 +0000
X-Originating-IP: [86.128.101.145]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1af93ba8-7b8d-49a5-f9f5-08d8169ea3a8
X-MS-TrafficTypeDiagnostic: VI1PR07MB6542:
X-Microsoft-Antispam-PRVS: <VI1PR07MB6542D73AD7C4A8098286C3E7C6970@VI1PR07MB6542.eurprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-Forefront-PRVS: 0442E569BC
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: BEq2Zxrm9cHp4UHVfcLHDuyWHK5cgpJb21wkDmLamOYdC2KGHsCY1MvaFAnfYCCNSmHOZ/q0QdCSKH7nINgkrcUxqkt72f65wNXrQxrPkIgCpvvlOwmpD7AuonzWAzocH/5QAKobOq6KiI4oBqDgrytnWItzuFCK4RX3DTLYn+6oSDnrxA1PqIc/lp6BA+lE4hQ7HGCl0BrJD1ggPyAGnQ1ptlPYVWdIUvYhYFnXlsFrSjJAA4/9V47ZOnsNqlpJsIdrJju2nkY4pJiTXvHkxgTz5iuNAzgYK3601PDeY21g81whzM3zLIUcWgSa3rLmTADlzSRoprhxCF5sBCE2+5ZsWFGWOsNqV0wDXzuYlRURaXSRURfUyGkDFQj4SJHOWT0sNriScKmkbOoFvmdkWw==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR07MB6704.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(136003)(346002)(39860400002)(366004)(376002)(9576002)(45080400002)(966005)(86362001)(9686003)(6496006)(2906002)(8936002)(83380400001)(66574015)(956004)(55016002)(52116002)(478600001)(6666004)(33716001)(8676002)(66946007)(5660300002)(66556008)(66476007)(52230400001)(53546011)(316002)(110136005)(16526019)(296002)(186003)(26005); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: hETUYPK01Pagb11Z6eDmFz4USPim01kwgYEiBE9V2r8GcpZ2tNysN9Y+3F18Xoi0KgE/uDb8jyneU3jEApf2X2mI3foiGYRgaTX447ivI3Q8ZUV3mDbmZWnN7z6F6j+/ssKKaFqdvjQwBlNqCg8vdwEitzfg0ojMi844GYb1um4rxbL9F9TotW3dBiX/aNCGixzbdEWSaYKzmIPnOlz6Y8FMtm0a4G4ESkhHSQ7kc3XGDycgwSfHoiG/4S4TnTKaFP+B70P2s7V6AegnuSNMFAgRfivNVoDq8KbwLUbf2HFyqgTtJpeQ6iK0PudD42qpNP+oUp9wWUpORkNBxMBhjHq+kbvB4nzBfTE16OG+XYNOJntvMh7tV4ZRue4Z89VLoonH6lYtpe38yZ01vfl7qT5tapggW6XS4OMeygga3dZcXde1LKln3kyCqGzMcLGnoIq7D76IJ9yQ4hKSZ5AQqHvZ8nPeDZrnTMBmrQ+TCsUAe/0lFUKm6UqTetptoFps
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1af93ba8-7b8d-49a5-f9f5-08d8169ea3a8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR07MB6704.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2020 11:23:08.2724 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T/wRPQQp9HLWZggaRaFchxciNLaywzJCG0FvWLBaCx0SlYQzA9LEJJGhEKEdEJndOGGaoOmYHCwZC+PkIHcjBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB6542
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/AgGN6_k4RpbUOqkT14W54z0p_j8>
Subject: Re: [pim] [Last-Call] Last Call: <draft-ietf-pim-igmp-mld-snooping-yang-12.txt> (A Yang Data Model for IGMP and MLD Snooping) to Proposed Standard
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jun 2020 11:23:13 -0000

-13 looks good.

Security considerations mentions the use of NACM; some authors put a default deny all under the Action or RPC; is clearing statistics that sensitive? Up to you.

And as the YANG doctor implied, there are two lower case 'should' which may or may not call for the RFC8174 boilerplate - I have lost track of what we are meant to do if we only have lower case.

Tom Petch

----- Original Message -----
From: tom petch <daedulus@btconnect.com>
Sent: 11/06/2020 12:19:48
________________________________________________________________________________





---
New Outlook Express and Windows Live Mail replacement - get it here:
https://www.oeclassic.com/


Separately, two more YANG quirks

The augment have no conditional - rather the YANG 'when' is one level 
down on the container, not something I am used to nor the practice in 
other pim yang.

YANG must be plain text - [RFC 4541] looks like a markup

Tom Petch


On 10/06/2020 12:44, tom petch wrote:
>
> The RPC to clear the tables are somewhat insecure.  The default is to clear all so a mistake in entering a valid address will clear everything.  It would be more secure to have an explicit option for clear all.
>
> The RPC to clear the tables has no restrictions; a NACM deny all might be appropriate
>
> RPC or ACTION?  the latter may be suitable.
>
> RFC5790 is referenced by the YANG module but is not in the I-D References
>
> feature feature* is unusual; that an identifier is a feature is usually apparent from the context in which the identifier is used and so including 'feature' in the name is redundant
>
> And to state the obvious the formatting lacks leading spaces which will doubtless get fixed some time.
>
> Tom Petch
>
>
>
> ----- Original Message -----
> From: tom petch <ietfid@btconnect.com>
> To: tom petch <daedulus@btconnect.com>
> Sent: 10/06/2020 12:31:25
> Subject: Fw: Last Call: <draft-ietf-pim-igmp-mld-snooping-yang-12.txt> (A Yang Data Model for IGMP and MLD Snooping) to Proposed Standard
> ________________________________________________________________________________
>
>
>
> ________________________________________
> From: IETF-Announce <ietf-announce-bounces@ietf.org> on behalf of The IESG <iesg-secretary@ietf.org>
> Sent: 01 June 2020 14:10
> To: IETF-Announce
> Cc: draft-ietf-pim-igmp-mld-snooping-yang@ietf.org; pim-chairs@ietf.org; pim@ietf.org
> Subject: Last Call: <draft-ietf-pim-igmp-mld-snooping-yang-12.txt> (A Yang Data Model for IGMP and MLD Snooping) to Proposed Standard
>
>
> The IESG has received a request from the Protocols for IP Multicast WG (pim)
> to consider the following document: - 'A Yang Data Model for IGMP and MLD
> Snooping'
>    <draft-ietf-pim-igmp-mld-snooping-yang-12.txt> as Proposed Standard
>
> The IESG plans to make a decision in the next few weeks, and solicits final
> comments on this action. Please send substantive comments to the
> last-call@ietf.org mailing lists by 2020-06-15. Exceptionally, comments may
> be sent to iesg@ietf.org instead. In either case, please retain the beginning
> of the Subject line to allow automated sorting.
>
> Abstract
>
> This document defines a YANG data model that can be used to configure
> and manage Internet Group Management Protocol (IGMP) and Multicast
> Listener Discovery (MLD) Snooping devices. The YANG module in this
> document conforms to Network Management Datastore Architecture (NMDA).
>
>
>
>
> The file can be obtained via
> https://datatracker.ietf.org/doc/draft-ietf-pim-igmp-mld-snooping-yang/
>
>
>
> No IPR declarations have been submitted directly on this I-D.
>
>
> The document contains these normative downward references.
> See RFC 3967 for additional information:
>      rfc4541: Considerations for Internet Group Management Protocol (IGMP) and Multicast Listener Discovery (MLD) Snooping Switches (Informational - IETF stream)
>
>
>
>
> _______________________________________________
> IETF-Announce mailing list
> IETF-Announce@ietf.org
> https://www.ietf.org/mailman/listinfo/ietf-announce
>

-- 
last-call mailing list
last-call@ietf.org
https://www.ietf.org/mailman/listinfo/last-call