IETF Logo Mail Archive

[pim] FW: Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-05

Hongji Zhao <hongji.zhao@ericsson.com> Thu, 25 October 2018 04:06 UTC

Return-Path: <hongji.zhao@ericsson.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 750C0130934 for <pim@ietfa.amsl.com>; Wed, 24 Oct 2018 21:06:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.769
X-Spam-Level:
X-Spam-Status: No, score=-4.769 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=OWvvdlHu; dkim=pass (1024-bit key) header.d=ericsson.com header.b=lcZ1xRnO
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VlhybPun6QFj for <pim@ietfa.amsl.com>; Wed, 24 Oct 2018 21:06:18 -0700 (PDT)
Received: from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9914E130DCD for <pim@ietf.org>; Wed, 24 Oct 2018 21:06:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1540440374; x=1543032374; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GM+5fofaofs51zUsHHwHVRm3jhG0ZLxKm1t7Kli2dDE=; b=OWvvdlHu6NKZHlTrm8hOpTGBYPuV6Ik6zVbZuAiEBqC9s8hEC0XHOsTIsbPildEy 7Y4a601ErLCx0E+P9z+RW4xGgdAEamtqL5/wD7GaN+C+z/xL0vgVzeFt3kFVQdyk dWEkpZJ6mCitfUvD8Kh+zHG7CcBD37HGzoNVexwqMR8=;
X-AuditID: c1b4fb3a-159ff700000012ff-f6-5bd14136b178
Received: from ESESSMB505.ericsson.se (Unknown_Domain [153.88.183.123]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id AE.5F.04863.63141DB5; Thu, 25 Oct 2018 06:06:14 +0200 (CEST)
Received: from ESESBMR503.ericsson.se (153.88.183.135) by ESESSMB505.ericsson.se (153.88.183.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 25 Oct 2018 06:06:14 +0200
Received: from ESESSMB505.ericsson.se (153.88.183.166) by ESESBMR503.ericsson.se (153.88.183.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 25 Oct 2018 06:06:14 +0200
Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB505.ericsson.se (153.88.183.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Thu, 25 Oct 2018 06:06:14 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GM+5fofaofs51zUsHHwHVRm3jhG0ZLxKm1t7Kli2dDE=; b=lcZ1xRnO4lij3wSsw6i+L1ckkXNuMcPVfRn32TU/I+yurJF6xFHaec37SfSyqijh0QImR2Ckj+9OWAEirpfkk72BXwzuKTgf0z+9VkYkgFoj7+9y74jDmddSs/5GQq1ZUVwY2yFqQfStFbloruXQrhZwQIfJkCqzNCJVfrGv2Cw=
Received: from VI1PR07MB4192.eurprd07.prod.outlook.com (20.176.6.29) by VI1PR07MB4048.eurprd07.prod.outlook.com (52.134.20.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.15; Thu, 25 Oct 2018 04:06:13 +0000
Received: from VI1PR07MB4192.eurprd07.prod.outlook.com ([fe80::7d44:9062:8cce:6abf]) by VI1PR07MB4192.eurprd07.prod.outlook.com ([fe80::7d44:9062:8cce:6abf%2]) with mapi id 15.20.1273.019; Thu, 25 Oct 2018 04:06:13 +0000
From: Hongji Zhao <hongji.zhao@ericsson.com>
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
CC: "pim@ietf.org" <pim@ietf.org>, YANG Doctors <yang-doctors@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-05
Thread-Index: AQHUZkNsLOM6Zagayk61DqKTE7CU6qUkWsPAgAECmYCABrc98IABVlMAgAH1oaCAAALOQA==
Date: Thu, 25 Oct 2018 04:06:12 +0000
Message-ID: <VI1PR07MB4192729E2BA140A21B9B006C96F70@VI1PR07MB4192.eurprd07.prod.outlook.com>
References: <B7E291AA-E083-4D86-B9A7-5A8400714179@cisco.com> <VI1PR07MB4192189BF36A749AED4D497396F80@VI1PR07MB4192.eurprd07.prod.outlook.com> <EA46E761-9F3F-4A53-AB96-E8CFCDCE5CCE@cisco.com> <VI1PR07MB4192AF7D59CFECB08B4C3F9996F50@VI1PR07MB4192.eurprd07.prod.outlook.com> <59F2B50B-BEEB-4A41-A9C1-A225D43CEF96@cisco.com> <VI1PR07MB4192DFDCFD30C0C2B737975096F70@VI1PR07MB4192.eurprd07.prod.outlook.com>
In-Reply-To: <VI1PR07MB4192DFDCFD30C0C2B737975096F70@VI1PR07MB4192.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=hongji.zhao@ericsson.com;
x-originating-ip: [106.38.5.8]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR07MB4048; 6:uqFL0K/Bhkc1U5heEFH7riffc8pA1CLvtVani48lmr7J5L9vgGBIBFd9YnCgW9BQzZMbyqckoiEK208JCZnAD//yGdL7GJgVaAXsOrWG18Hu559sm2uNsohEAbbBQ6v81SHMzZpf8Fxvq3DmAeFlFYWi8OwFTvi70b4+Fw96/9EkcDNqs9OyeNQrZMC2XZWrEbiAkCFnHwM9ni/yvH9qJLbDjyg97bwH+Sv5dLkmg6POnUGaN8XYY5Rhk3KXKcKAk9jACtfTVl3Qo0GaSMsl6MaAP+MjKmfUdpXGlihnEhd0sZy+wvmf1r+iYW0F6ECVoiYTmK5XfutzJn/dsGX1fK6MD/bSe0m2q2CbKBjElrpbPbLCgPnpkn/bs7RnWVcULabCjNxphNYbm4aOPkoAekxtvhoBdfK9cnom8q0ZCceaNcwKQoBGTX5glQR5QG44ZysTPDTF2wlVNkQMifw5MA==; 5:mm9C0MbdPCU9WD6on4So3hD4MRedJ5/lku0SratBpGJPDEo1U2CXCFOdmqSUxS/uGzACk/1CO32cdwMAKbWKFmO9W+3iFSAFp/sRaZP6WnxNJVr+kXP7HriTdt2lqWeHbQfwDwEeSCkUhOfTEdMiWJkSU1nRNl7s+tBAU9OutgY=; 7:mHa5T4SkKxXvSissbWjAy3AZhtWzofau2N+A1YequsGgBuojKYNORqrc57W5QbLAbgJCS1KRRnYa8jhQF9I8SdU1QL8n2SNO/nVfZvAC4lPTrLHffwqMPUFyxzUv1g5is3PHoOxMMArKXmG2TeBWyg==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: da6bca0f-4401-4b3a-cf9d-08d63a2f341a
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:VI1PR07MB4048;
x-ms-traffictypediagnostic: VI1PR07MB4048:
x-microsoft-antispam-prvs: <VI1PR07MB4048D539DA658E060057DE0B96F70@VI1PR07MB4048.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(95692535739014)(248295561703944)(37575265505322)(21748063052155)(28532068793085)(190501279198761)(227612066756510);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:VI1PR07MB4048; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB4048;
x-forefront-prvs: 083691450C
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(39860400002)(136003)(396003)(199004)(189003)(2906002)(2940100002)(8936002)(4326008)(81156014)(8676002)(81166006)(99286004)(186003)(14454004)(6436002)(26005)(790700001)(256004)(97736004)(316002)(6916009)(3846002)(93156006)(478600001)(229853002)(6116002)(93886005)(74316002)(25786009)(236005)(105586002)(54896002)(53936002)(6306002)(7736002)(55016002)(54906003)(86362001)(2900100001)(9686003)(2473003)(33656002)(71200400001)(71190400001)(68736007)(76176011)(9326002)(7696005)(102836004)(53546011)(106356001)(5250100002)(5660300001)(6506007)(66066001)(446003)(11346002)(476003)(486006)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR07MB4048; H:VI1PR07MB4192.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: fAGWSo+TI7MWoYN8K0IS8eRRuDT5SO8f7mNe1sjlwvFpAQFIC2Oe5AIBUsXw38v2Z4niEPyyU+WAAVXX/rvripBhrKE94cuUvBDBCQ6aBTVRDIqMuInY68XrZ424poeJWFUpIlIGPXQMvfWcRF2plWTTj+rXN1nrLM2kVldjQvv+Z3kk0QRoD8n8P1Z29BkP0T95xe5ShU3/A4c4EmNAlaQyrshE+IqLqVA4LZkCk1T5YQdw4NXpfZgit0v18gEiXUJXMgdXlBuETQepL/y7wf/CHodZ+Ce5OitIaOCY2uzM3r0YyC4BD5EGJc2njB8DqVdXl2i63D732kOxyoiMH/MieYy6PdprdmKs3/nKgps=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_VI1PR07MB4192729E2BA140A21B9B006C96F70VI1PR07MB4192eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: da6bca0f-4401-4b3a-cf9d-08d63a2f341a
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2018 04:06:12.9908 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB4048
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0iTURjHOXvfba/DxWle9uAtGiRqqSklS8tSiISQAsPCSzn0Tedl2t5l WR/SwFCnYU0h57wki0RtXTA1TcuJK+06PyhqGZa2JAgpNS+pub0r/PZ7/s+P55zncChC9IDr RskVKlqpkGVKeAKy6lT7Zf+QCHP87ommQOnc5CghHW4s5Euvdz5Hh4ioipWH3Ci9folznBMn 2J9CZ8pzaWVgeJIgbXVIR+Ysv0IX7+kHufnopQmVIAcK8B5ovK3dYAElwv0ICqZ1PLZYQDBv +cD9X8yuV9s1PQd02ga+tSBxOQHXPmptw0T4BgfKu+Ws9RnB4Ps20trg4V1QrH5MlCCKcsZB sNwSZkUCH4GxNg+r4YRjoHWx3mY74xMwo6+wcyw8KS6yMYl3wMz6EGFlIU6Ar5ZRPntUNQHq PhPP2nDAiVBats63MsKu8HuwhWNlAothbKqOwy6NQf/0HcGyC8x8WeOyfjwY+gv4bO4F3wwa u+MJQ3Vq2/aAh3mgM+vtkj/MVlbapWiYWzCSLL9AULKQwrIfdE39sucZMD/exWMH1SAwtTTw ylGQdtMFWc4G7U8D0to23QoDVVOk1vZgvnC/M5BVtkOFepLPsg8U6mr4m/N6xG9CLgzNMFmp wcEBtFKezDDZigAFrXqENv5Rb+tKaAfqtUQYEaaQxFHoIzXHi7iyXCYvy4iAIiTOwgnHjUiY Isu7RCuzzyjPZ9KMEblTpEQsjDwrjRPhVJmKzqDpHFr5r8uhHNzyEYPu+lxhFIvjZUm+msjY glCet+zAG/OqZ7TKq2inoWpJs21dc2xLhMl7eDo3xJAqG2kTJhafPBpzeHLf6RCnsLCS2r13 PMpuEQPLr/vWav/44bc3xR3J45+yzenNjr5XkbjbPeHC2ohveo/a1d0iDV9rP2eQf+9pfnaw FFXm/5CQTJosyI9QMrK/Hm+IsEMDAAA=
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/F-QWarrbeHMILXZglXpfaSB5FEQ>
Subject: [pim] FW: Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-05
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Oct 2018 04:06:20 -0000

Hi Reshad,


  1.  I have 2 new identities , 1 for MLD instance and 1 for IGMP snooping. Is it ok?


identity igmp-snooping {
    base rt:control-plane-protocol;
    description
      "IGMP snooping protocol";
  }
augment "/rt:routing/rt:control-plane-protocols/rt:control-plane-protocol" {
    container igmp-snooping-instance {
                  when "derived-from-or-self(../type, 'ims:igmp-snooping')" {
        description
          "This container is only valid for IGMP snooping protocol.";
      }

      leaf name {
        type string;
        description
          "Name of the igmp-snooping-instance";
      }
    …
}



  1.  I have added the prefix “num-” to the statistics
|        +--ro statistics
    |           +--ro received
    |           |  +--ro num-query?                  yang:counter64
    |           |  +--ro num-membership-report-v1?   yang:counter64
    |           |  +--ro num-membership-report-v2?   yang:counter64
    |           |  +--ro num-membership-report-v3?   yang:counter64
    |           |  +--ro num-leave?                  yang:counter64
   |           |  +--ro num-non-member-leave?       yang:counter64
    |           |  +--ro num-pim-hello?              yang:counter64




BR/Hongji
赵宏吉

From: Reshad Rahman (rrahman) <rrahman@cisco.com<mailto:rrahman@cisco.com>>
Sent: Wednesday, October 24, 2018 5:00 AM
To: Hongji Zhao <hongji.zhao@ericsson.com<mailto:hongji.zhao@ericsson.com>>
Cc: pim@ietf.org<mailto:pim@ietf.org>; YANG Doctors <yang-doctors@ietf.org<mailto:yang-doctors@ietf.org>>
Subject: Re: Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-05

Hi Hongji,

Inline.

v2.23.0 | Report a Bug | By Email