[pim] Re: Intdir telechat review of draft-ietf-pim-3228bis-06

Brian Haberman <brian@innovationslab.net> Mon, 05 August 2024 14:26 UTC

Return-Path: <brian@innovationslab.net>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B420DC16941B for <pim@ietfa.amsl.com>; Mon, 5 Aug 2024 07:26:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.904
X-Spam-Level:
X-Spam-Status: No, score=-1.904 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=innovationslab-net.20230601.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r3GpXXz3o9uc for <pim@ietfa.amsl.com>; Mon, 5 Aug 2024 07:25:58 -0700 (PDT)
Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C59C6C151094 for <pim@ietf.org>; Mon, 5 Aug 2024 07:25:58 -0700 (PDT)
Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-68aa9c894c7so29541917b3.1 for <pim@ietf.org>; Mon, 05 Aug 2024 07:25:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=innovationslab-net.20230601.gappssmtp.com; s=20230601; t=1722867958; x=1723472758; darn=ietf.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=BPYxfD4LceDI1Nj6qE+asPAwAOHIQN49PaehDRTvk5s=; b=bmLafn8QxfYMciZDIPKm45H/Nfw+s78k6MoHLgWY5VWfov4KJeFhQnIBoQSfM961Ks SnzKxnSyRuqZjJXT8beeEpbkkhbDHrkx4TrIv2WVlvWpWGwnK9h9+zLHnAB3LZrkfV5M QUGjXvjRX7/Utf8xhpN4ENJLRg5YcJBW7mellGl0ZPQOWHPg7Ipqkv7sAAX2vkTAkVfm bx9pdD9+ydzz+mFTS9kdcrlZFJSo9N8hQDmoUxdez6t9Bjf79KHeRUhVxnpvXqFx698U QFy9JAFMn2qo0sMb1IuVmWydPc52RUg9BY9zlOEl20MDVD1Q2PXvwTKI03EWxjQtEV5O 5m7Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722867958; x=1723472758; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BPYxfD4LceDI1Nj6qE+asPAwAOHIQN49PaehDRTvk5s=; b=UeCnmgUnk66D5BiZ1D948/10q5HwmS/f4YTQMwwc930Wh/+xmccy27Szulplb1+ZA7 zrDaRTxt5IH7FcRUMsoApOzpbcujVeDkZAwuBiFNR0HllpspjwGjKxuwva5gygykNCUZ IX6fMmylM1FgvBd+xZvZMq6Kn3kLeXU4pMp+bXlaPY3QBliPYmcpx8PzdeAZbcoDikjZ 4P4OA4JZ5RFNvlHXWUKIPbBytu5mSHzq3il/jgSElT4AX81C5Uv9G+OGeBihfJPeV5wW XV5dJcpFaxqDbZlGMYLIW9Rl2A40iJlnDswEu8bFSa82Vo71szrkQ4vo0f50c7ZdzS/U 3KKg==
X-Forwarded-Encrypted: i=1; AJvYcCUI4muYrgpAlYEfVFaFGxcWZX+hFH+C2WNQeX8bHI2ajkz+tj9NcN7slJoIUmEdhTaBCNXekdbrcFu0rTg=
X-Gm-Message-State: AOJu0YyjwAW8V2B74+WZMeDROFYGsnVocuwX7rXCfESuB8OZPYkvJ4bB WmzUnZ1SN1OERvy8upFUy504jmwpXCkOJ9O+4v4dWH5zTJhlzEdjq2vMHpSnsUM=
X-Google-Smtp-Source: AGHT+IH4DyQfb+YqM1xYJqN1ZAPu94zzPnWqsrs+BRcY7n/BNx9C6kVS/2g3UnP5/Co3KIaOuZ9NyQ==
X-Received: by 2002:a81:5b06:0:b0:61e:a26:c1b2 with SMTP id 00721157ae682-6896039ae96mr123912287b3.17.1722867957932; Mon, 05 Aug 2024 07:25:57 -0700 (PDT)
Received: from [192.168.1.20] ([172.59.222.82]) by smtp.gmail.com with ESMTPSA id 00721157ae682-68a1074ee0bsm12082227b3.71.2024.08.05.07.25.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Aug 2024 07:25:57 -0700 (PDT)
Message-ID: <ed1492fd-e6ec-4394-a452-3696fe16046c@innovationslab.net>
Date: Mon, 05 Aug 2024 10:25:55 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Dave Thaler <dave.thaler.ietf@gmail.com>, int-dir@ietf.org
References: <172193308730.1062129.15289362548122263012@dt-datatracker-659f84ff76-9wqgv>
Content-Language: en-US
From: Brian Haberman <brian@innovationslab.net>
Autocrypt: addr=brian@innovationslab.net; keydata= xsFNBGFCWtIBEAC2FIgMIrH27l4L1Uu+vxCBakOv0Y1nxsu61+aulA78two2kCl7OCF+myP8 KQHEFMoZSn+ZvR+QDFyhsHe7qDK0CVf1K3n97PptXG5kvbnDJdwVJV0w9zYC17/VDgGAKLqj 0iNDVc9mYg/zCYdPn616UAj7hNpFgc9f982gLokyR/xbMNvtOwOpToysK+7Oc25oOam0xuUx CHcE4BfzJHO2VmUgWHeTvxervtIeMcn5PUlQ4XhzYH88mLlI1Uno7W5Dfx8FjXLNNAq4aNBM 6QND2LRekYi75pSTFXNpYIZvmgVT/VB6SHpsyJ3Hkio4YqGkPiqCEcB6U1lArT2FmXnzsTOt 6ydx6ONClxtcOmoEWrES+8tU+knaCEo1/XOrWtivTFMzn3Mahf726XxQBG55FkhqQ/Mir70e mTtpm8MDf+Qj4o5OsSF01l0MMxwOPiB57pz+XuUoWvLEjLgnb83eY0/YpBJdYESL3zZ3zMBo zA65cUozqSGHwQnlE1ACRDKhsReSYmiPJR5o3pWvNf5z+1M3tyn4qpuPxFFA1X8tEstpoC9t QoX8oextRj9BXlJCcCOwSVbCN8buO7aJMN3PIwSewjYvNLMxLrMph/8jNAHIaZnIt3CRHAq6 RsEAv8VQBWruIyNyyX0N8upnOpvriqx1eI2yS/B/Z2D8fQoFewARAQABzSlCcmlhbiBIYWJl cm1hbiA8YnJpYW5AaW5ub3ZhdGlvbnNsYWIubmV0PsLBlAQTAQgAPhYhBKm74/fFK6tXux1c k5E020tPLWqqBQJhQlrSAhsDBQkHhh8tBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEJE0 20tPLWqq9fAP/1BO1H3SxphcXPbIsuJ+LoBCoKhrIftwGrLZzyiHYyLSFJ/HWLH2Kv79XJP4 6GkpTCk3VfJp6LEjw9FItwXUn0BEf0LyEy1L7w81YXPq+e4kwTPaQI8CgnbpSS9HBkcUj2r9 bwCjf+QZMqfgbz4d2MkVdVrIM2XPLYQND+Xtu1tyTTnrvFndLQFkDdqHAM9HqoikoNqWqz5j JPaxpJfxqmWr86vNThI7sD0rgMX5TWj7Flngzv2G9/uGEz4rHOIwK6KKiXNKk79kTqjUCQ9j tXl8BC2LQj8xsnWeGISTMR3xbiBPeTX94686O6KcLl7QIVKVS+nqs2l2j2gaXo1AjhBXO7gP GFN+rZzPOUZnPQUek3FeQoZCkfC/ljWBPooCpBe2euv5uZ4NbfKHAr9nmmhg4Uh1IceMxMQ/ /kB2wXTbuoprWLkK02r/y9LyGI5zLqLNl0NG17erJ0NCke76xYJkKBYezgBj1pZmYQDC1Sox fKlsaFCWkBrcKuGWc49qbEtWVM8h/mw+0w5pFyKX733xa6A+S8TOPYng/qFYgauotV9unjjt b7Npn7XyYzypk7QqKo4zipBqpHKeQ96Y/FKXSHPuTVj7dGK3Dn4b0q9Dgti7ogCc8F3tJcZI E0R8Q+4TRcQ192dLvyyTrv4h9BY6q5aB56Z6dsn11TAx7YCAzsFNBGFCWtIBEACqN6OFHSNq jiPy8s05QTC2fCqi0G5CcbRFXcqmHDEKdwqHk5VuOEL8CcWKNzOEMCt6EJvNL4ivfeHs1e7f rfm08+0Da0xAFiab92B9lOTLfv/NkKZ3jakQs06rtSzX7tYDbnmDeX206Uqff1mDjsiXHoAJ fdW7CjNLdWp42B3fkSjUR8mUgeNPqO4Jhgd7d3tTN2ov7M0rS7kUoE6Gd01LmNoPUQ024g8G ecMXVBldgg78aKmehs5pSWLmoBfczymGmNT/++9B6btmy7ruU+febVXRaQJY7aqpkTL7oy4H 3LMRSy/0BXHm1WgO7201Aj7PuaXM424hAhzmAJhO5AvlT9PuS9eSaIP0sqgP7ZTX7UezVj1H Tv5VJtgHI1fiNfhd/KFqDQDGaKdlM0iysyPanSCscjsWqAG0Od2TPdSuURqvgt8suBZrAAfK d55Ovguy+8uCi047sQxShUonw7TxGl3FMAe04PBIOgMCB/uys4yDUjYrawrlNigvx60Nec+T ExE+qszoO57If3/rG78J2ntGjog+yTDNffkbzljcy3YDe3k/r+T2FKOcWxJTlwSWAs1aVLZ7 DWx73lpYrSNJxiU7PrPihfS/Doy3VfmfF/RbH/xmkuPvsyrVfd16pEEtHGi5hBk2KQyjVqi1 IWwXV9ZVOQFBE9nJ7i6A7Aw3EwARAQABwsF8BBgBCAAmFiEEqbvj98Urq1e7HVyTkTTbS08t aqoFAmFCWtICGwwFCQeGHy0ACgkQkTTbS08taqrpIBAAjc6GdUjCyVsZLYwV8bMM4loltFrx z/mroCIFW4PZ0u4zENaloQbHuhDx7Ii6mR9jRiVNbXP4XvuyhjlUO+pt6hGrPbzsmV9vGvN0 2nkGYmSpxQNEzHQf/CJyLhPWY5qTJlDEr4zHbloG2KRPQ6dv9mdRIyAwDxNDSq2tVlrJC+b4 hG9vYp9msCZspqVDRTzvRTZQoWAvGJUaUgZd/FLPTfFePAmX+enXkUKl332i82xNU/nTix73 WajK7WhWC2GugrEbi42fJgUKRtYWhY36QyxucB1VWUacn7iKt/eLfPrCVVsHP2j4vqjlL/HJ 38TvbqfI4WbXyXF630U7IOlMT8//vpo3Y8hjWw0p5dm22fyPcjfnqxDdDefKCJpN215JgvDi Ww42J+VDTsd+5FJYCSUqg3jXmJl1z6FewF5hjuUGf/VdKCrhFocfh1b8VFgne2M1vyNcPoS8 23lJOMpcVAmzFhmVl5y/az/kgPJzbQggSByv3pZZUlJttLKf9BSGwmKcoGEgNo8p/DUyMkQV kVCJdmnamJzYEa/s3XRasTZhoWzNSjIEfeJaLd8dVXTzByMzgYuj/raFP1UF33GQ8W+zr23b VLVc8pEjMQlWeRGfJRyvG4ZOYpFk0c7jw8LpERCd/1SGHL3RQ3CwOqouQgKV+0BjMbY6A6Vj CuWio7k=
In-Reply-To: <172193308730.1062129.15289362548122263012@dt-datatracker-659f84ff76-9wqgv>
Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="------------lC2EXZBvkl2HX820ppTkWag0"
Message-ID-Hash: XXJYOSP2WG5X5D6JXI4IUOTKCBQXIFKV
X-Message-ID-Hash: XXJYOSP2WG5X5D6JXI4IUOTKCBQXIFKV
X-MailFrom: brian@innovationslab.net
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-pim.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-pim-3228bis.all@ietf.org, last-call@ietf.org, pim@ietf.org
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [pim] Re: Intdir telechat review of draft-ietf-pim-3228bis-06
List-Id: Protocol Independent Multicast <pim.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/FE_kclAJ1049ASh09kXOpcOI3gE>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Owner: <mailto:pim-owner@ietf.org>
List-Post: <mailto:pim@ietf.org>
List-Subscribe: <mailto:pim-join@ietf.org>
List-Unsubscribe: <mailto:pim-leave@ietf.org>

Thanks, Dave. These all seem like good updates.

Regards,
Brian

On 7/25/24 2:44 PM, Dave Thaler via Datatracker wrote:
> Reviewer: Dave Thaler
> Review result: Ready with Nits
> 
> A PDF with my comments marked up inline can be found at
> https://1drv.ms/b/s!Aqj-Bj9PNivcn_tvdayAlL9xJZJgKQ?e=K42XOF
> 
> Overall the document is well written, and easy to follow.
> That said, I have several specific suggestions:
> 
> Section 2.1.2 (MLD): The registry itself is labeled as policy “IETF Review” but
> the words “IETF Review” per se never appear in RFC 4443.  I’d recommend
> explicitly saying IETF Review here.
> 
> Section 2.2 (Resv Bit): This column heading is confusing. In RFC 9279, the
> “Resv” field is only 3 bits wide, whereas in RFC 3810 and 3376 it is 4 bits
> wide.  And in both 3810bis and 3376bis it is called “Flags”, never “Resv”.  I'd
> recommend "Flags Bit" for consistency with 3810bis and 3376bis.
> 
> Section 2.2 (values in the Resv Bit column): These values may be hard to
> understand. I’d recommend explicitly saying this is the value of the column
> header in the packet format diagrams in 3810bis section 5.1 and R376bis section
> 4.1.
> 
> Section 2.3 (values in the Flags Bit column): Likewise I would add a sentence
> explaining the bit number corresponds to the column label in the packet format
> tables in 3810bis section 5.2 and 3376bis section 4.2.
> 
> Section 4 (Contributors): currently says "RFC 3228 ... forms a portion of the
> content contained herein".  I recommend changing "forms" to "provided".
> 
> Section 5 (Acknowledgements): This is an empty section.  Remove it or fill it
> in.
> 
> Section 6.2 (Informative References): I think 3376bis and 3810bis are both used
> normatively, not informatively.
> 
> 
>