Re: [pim] Éric Vyncke's No Objection on draft-ietf-pim-igmp-mld-snooping-yang-17: (with COMMENT)

"Eric Vyncke (evyncke)" <evyncke@cisco.com> Wed, 19 August 2020 09:25 UTC

Return-Path: <evyncke@cisco.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C7BAC3A16BB; Wed, 19 Aug 2020 02:25:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.598
X-Spam-Level:
X-Spam-Status: No, score=-9.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=NKfRwMpp; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=FeikLyGE
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xPmYqHADTyJ6; Wed, 19 Aug 2020 02:25:01 -0700 (PDT)
Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C2ED53A16B8; Wed, 19 Aug 2020 02:25:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5588; q=dns/txt; s=iport; t=1597829100; x=1599038700; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=zvbGdzvWnwoPwAINpDVcftGuvUfIwdnp+5q728Bihgg=; b=NKfRwMppxyJ7MEdzFA8cvjnuA5DJQdQDE8TH/b2KfjzTAa36Plx03AMT eTynOnrzE5OIGFsdCzvA/IyQPk4Xh7tFwKBlKfjVc8GxeeTzaQLhzho8m pZlTYqMomPix6AGSgjz3FKqqeT3PwOFJgg+HzhOgHsBJ9W5A7c6hZ67A/ w=;
IronPort-PHdr: =?us-ascii?q?9a23=3A/kVeBROJzYx5U96/qssl6mtXPHoupqn0MwgJ65?= =?us-ascii?q?Eul7NJdOG58o//OFDEvK813lLTXI7A8PVCzeHRtvOoVW8B5MOHt3YPONxJWg?= =?us-ascii?q?QegMob1wonHIaeCEL9IfKrCk5yHMlLWFJ/uX3uN09TFZXzfVzZuWa163gZHR?= =?us-ascii?q?CsfQZwL/7+T4jVicn/3uuu+prVNgNPgjf1Yb57IBis6wvLscxDiop5IaF3wR?= =?us-ascii?q?zM8XY=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DqBQAV7zxf/5FdJa1fHAEBAQEBAQc?= =?us-ascii?q?BARIBAQQEAQFAgUqBUlEHgUgvLIQ3g0YDjVuKCo5iglMDVQsBAQEMAQEtAgQ?= =?us-ascii?q?BAYRMAheCGAIkOBMCAwEBCwEBBQEBAQIBBgRthVwMhXEBAQEEEhERDAEBKQ4?= =?us-ascii?q?BCwQCAQYCEQMBAQEDAiYCAgIfERUFAwgCBAENBSKDBIJMAy4BlVKQaAKBOYh?= =?us-ascii?q?hdoEygwEBAQWFSg0Lgg4JgQ4qgnGDYoIjG4QOG4FBP4ERJxyCTT6CGoIjgxc?= =?us-ascii?q?zgi2PWEWCLDyiKjdRCoJilSIEhHwDHoMBiV6RIIIohDiOB40skhgCBAIEBQI?= =?us-ascii?q?OAQEFgWojgVdwFTsqAYI+UBcCDY4fN4M6ilZ0NwIGAQkBAQMJAXuPZgEB?=
X-IronPort-AV: E=Sophos;i="5.76,330,1592870400"; d="scan'208";a="544741849"
Received: from rcdn-core-9.cisco.com ([173.37.93.145]) by alln-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 19 Aug 2020 09:24:59 +0000
Received: from XCH-ALN-005.cisco.com (xch-aln-005.cisco.com [173.36.7.15]) by rcdn-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id 07J9Ox7I004824 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 19 Aug 2020 09:24:59 GMT
Received: from xhs-rcd-003.cisco.com (173.37.227.248) by XCH-ALN-005.cisco.com (173.36.7.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Aug 2020 04:24:58 -0500
Received: from xhs-aln-003.cisco.com (173.37.135.120) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Aug 2020 04:24:58 -0500
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-003.cisco.com (173.37.135.120) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 19 Aug 2020 04:24:58 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fDbahq1GFyr4hpgj5/7haKiYED/d9Nx3pWiI3yjNcnykc7Z1hzp++E1NSQNikf9UoHS9YLq0dtJx7JFu3ubK3yipVcpYexUZqZtBi58oKPtU3mXcRDfocqbVBg0wUxkliyGPkzKaF3dXRygMaa6/l1zvEat3IjcUh1zOJ0l8fQLEbWUNWtcU5X/JsrsyM27vaWKtxpUSk7Q2P14YJkMzsuHVQlWvOcfpq5NZb45nHWDibubCjbbu7opu2Q1R2IqM7M1qDgKhrtwwvFn6hVoUhLuR690vnbxh9bqauiuj4noZHKKD+tBH2jgdEfxcSMZicw5pRr/wNm2XnP309Juhhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zvbGdzvWnwoPwAINpDVcftGuvUfIwdnp+5q728Bihgg=; b=E1tTI0J7G/+kImvfthp02U/MvEfTkPwGlMDTXJF/dWYCKBJQPVwpzbAG2rfMjRVP7xdsAOGTvZbqyWZuoLmPs2KrMnytaZqYmlR+GtlEtUYcDooHSXoxY3ZcG7i2ou8RZm/ErGefGmbyTIuk53wFrf85HHsArXzHg1AwYm1ZUYsu7efC8GvNCKiVABfGyo+uQqrT5h+HmlvSQoz35JcwHfbtfKVq32Z9NsvGYJzy2aB2dmLkPcxSUk5bp2FfdlzU++m2xhg4Mfll43X3W+DRCX3zmnm3cd/1Z66FeDNznL3QS0ugi7h5IjSlATnXy0ASnsvf2tscOycz5lEh+kbOtw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zvbGdzvWnwoPwAINpDVcftGuvUfIwdnp+5q728Bihgg=; b=FeikLyGEPsR3ygLxeC6WkQ3891nPzL782GcmTkl7BurMJDNI1eg3TKPiRgRnWuUk8k7NKef38xCzxaqKzhwNTfNiYihLSYrqhzv694iRauclPU0NYPvILZ1HUxH9znQvqy2F1R+NlLioEKL4uj0xVwlsIDkt7HH4Yiwu92CcOic=
Received: from BN6PR11MB1844.namprd11.prod.outlook.com (2603:10b6:404:103::20) by BN8PR11MB3732.namprd11.prod.outlook.com (2603:10b6:408:83::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.16; Wed, 19 Aug 2020 09:24:57 +0000
Received: from BN6PR11MB1844.namprd11.prod.outlook.com ([fe80::a149:e156:9fa7:7fc4]) by BN6PR11MB1844.namprd11.prod.outlook.com ([fe80::a149:e156:9fa7:7fc4%4]) with mapi id 15.20.3283.027; Wed, 19 Aug 2020 09:24:57 +0000
From: "Eric Vyncke (evyncke)" <evyncke@cisco.com>
To: Hongji Zhao <hongji.zhao@ericsson.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-pim-igmp-mld-snooping-yang@ietf.org" <draft-ietf-pim-igmp-mld-snooping-yang@ietf.org>, "pim-chairs@ietf.org" <pim-chairs@ietf.org>, "pim@ietf.org" <pim@ietf.org>, Stig Venaas <stig@venaas.com>, "Rob Wilton (rwilton)" <rwilton@cisco.com>
Thread-Topic: =?utf-8?B?w4lyaWMgVnluY2tlJ3MgTm8gT2JqZWN0aW9uIG9uIGRyYWZ0LWlldGYtcGlt?= =?utf-8?Q?-igmp-mld-snooping-yang-17:_(with_COMMENT)?=
Thread-Index: AQHWVb9unxrC4nFF0k+N64t3JQlaKak0C7mAgAt/gwA=
Date: Wed, 19 Aug 2020 09:24:57 +0000
Message-ID: <909FC47F-AD0F-40C2-8F42-1D5A1E013755@cisco.com>
References: <159427834725.21252.8658233194269644768@ietfa.amsl.com> <HE1PR0701MB24927B22AF2C5419E328A9A096420@HE1PR0701MB2492.eurprd07.prod.outlook.com>
In-Reply-To: <HE1PR0701MB24927B22AF2C5419E328A9A096420@HE1PR0701MB2492.eurprd07.prod.outlook.com>
Accept-Language: fr-BE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.40.20081000
authentication-results: ericsson.com; dkim=none (message not signed) header.d=none;ericsson.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [2001:420:c0c1:36:b03f:39ea:f283:dae0]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 38802f5e-26a6-4e70-bf71-08d84421bd85
x-ms-traffictypediagnostic: BN8PR11MB3732:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN8PR11MB3732A3D948B358C16EB18E10A95D0@BN8PR11MB3732.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: c4IatFvryndlXKS2JfBi0FJC8XqUHxOiLl2/Wllp1Oo0bpBr9HZX/V0rBloEbFSk2IkehHCq0130m4V/Gv8HBhf3szhM7BpLmIPZWcBtAhhCtfe0vSL/bMFwtQOSUA+ikJMH7hne9b5dYK2Ns3SXuXIIgvSLzUro7frUZvQm4+mfjuRkS2gG7q3ReDWYQN46oFkW7iIf+WqWIm53HczGfUH5Df1VuePngydu3hYl7A9/XvV+/cY32CN7mlRw79yiNu4+zLr43BbXhcFFEtYwUkqcktVZm4ySKBXwH5P/wjQpZlMSM+93overPLKjaDSlcF/9bZL+zPouop7rwvHsfA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1844.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(376002)(366004)(346002)(53546011)(91956017)(478600001)(66556008)(2616005)(66446008)(4326008)(224303003)(8936002)(66476007)(76116006)(66946007)(186003)(64756008)(6506007)(33656002)(6486002)(83380400001)(110136005)(86362001)(107886003)(2906002)(54906003)(36756003)(5660300002)(71200400001)(6512007)(316002)(66574015); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: LQdYtC+Qy2IfrGU8aRkjo+2wYGUlJ8ntwBYETAYKeljWSMmR+zV3NUim+zObPA5FxvWvvJ3QWBokhp6U1dcIw7qN+43QWUAXTQtkaQG+X21ZtZaN/EkHQJweeFFN/jNcwXONSsWLLnz9SOoFT9ZAoDVcH5QLigD6mEXBDChdHtoDhKUacrgPboItnNAvEtSXO5BHg16eNPGkprUOHF6nXUJv0Bf9bqlT2i10U5U/s8HeJShXnjqgQPBexMIAlG3CtUtAWzh4uK8ZqEUefIYnN5sL4Ntwr0i8yWaBBoS8f03fuo2fSYr1bQqL+126Cq/ghHS5TU0NciIbWljMk2yzSE+RmMGzk7Q2uRezaTqhNWoDFTLT0SXOIi109DWoEVrbI7nenPF8iuqMzWFarW1Wvf00unNAgiKj0ciwzuSiFickzZOcnwkIYMhzpMfbO15ETo2Mz+5SRDad4MOaGGAIQ2BU5dds4fBHoYKV47ZstL8htWTbYWe5c/DHhp8tA1fHuyBqJNx7VOJkzKXOlSN9BpT95fyKwW+hYxeV5SQmDZzTS77Ox28IvemtEUaSqPl5m1nbXoNi9slDA9FiuZbx1I+tC2livtJ/G6JqpWhBwciKwpPUjmseep0u/g+jswhYNrLOruh7aqzmAC/yUqHfV92POitUBsWP0XuNW8KjjC8y//ZQAN2zWOHYPGaOqHAvJK18wNn8vVlXgZT8oEfNJw==
Content-Type: text/plain; charset="utf-8"
Content-ID: <EA54F52EC33F1C47AAE864FE6C8E7367@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1844.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38802f5e-26a6-4e70-bf71-08d84421bd85
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Aug 2020 09:24:57.5294 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: djgRYffwBUNqWOrpxnp8xM+cUlEodnIuch5v18l/4oKp3OxL9kneYwgvfTaZMgR7KHMQrFgmfol3jPABMS37SQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3732
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.15, xch-aln-005.cisco.com
X-Outbound-Node: rcdn-core-9.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/GIOaYsRKQpwS19yOn1RpduXNeXU>
Subject: Re: [pim] =?utf-8?q?=C3=89ric_Vyncke=27s_No_Objection_on_draft-ietf-?= =?utf-8?q?pim-igmp-mld-snooping-yang-17=3A_=28with_COMMENT=29?=
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Aug 2020 09:25:03 -0000

Hongji,

First sorry for belated reply but I was on holidays until now...

As already mentioned all my COMMENT points are non-blocking; so, I appreciate the time taken to reply to me.

I agree with some comments of yours but I am still unhappy (but again non-blocking) with:
- strict adherence to the old RFC 4541 and ignoring that most vendors have introduced extensions. If all those vendors end up in doing their own YANG augmented model, then I am afraid that this will not help the network operators at all.
- I am not sure that repeating a mac-address leaf for an IPv6 mcast group is a good idea (as they are linked together), I am probably a data science purist but this redundancy does not make things more reliable, it only introduces a risk of lack of integrity 

Thank you anyway for the model as well as for your reply

-éric


-----Original Message-----
From: Hongji Zhao <hongji.zhao@ericsson.com>
Date: Wednesday, 12 August 2020 at 05:58
To: Eric Vyncke <evyncke@cisco.com>om>, The IESG <iesg@ietf.org>
Cc: "draft-ietf-pim-igmp-mld-snooping-yang@ietf.org" <draft-ietf-pim-igmp-mld-snooping-yang@ietf.org>rg>, "pim-chairs@ietf.org" <pim-chairs@ietf.org>rg>, "pim@ietf.org" <pim@ietf.org>rg>, Stig Venaas <stig@venaas.com>om>, "aretana.ietf@gmail.com" <aretana.ietf@gmail.com>
Subject: RE: Éric Vyncke's No Objection on draft-ietf-pim-igmp-mld-snooping-yang-17: (with COMMENT)

    Hi Éric,

    Thanks a lot for your comments. Please check inline.

    BR/Hongji
    赵宏吉

    -----Original Message-----
    From: Éric Vyncke via Datatracker <noreply@ietf.org> 
    Sent: Thursday, July 9, 2020 3:06 PM
    To: The IESG <iesg@ietf.org>
    Cc: draft-ietf-pim-igmp-mld-snooping-yang@ietf.org; pim-chairs@ietf.org; pim@ietf.org; Stig Venaas <stig@venaas.com>om>; aretana.ietf@gmail.com; stig@venaas.com
    Subject: Éric Vyncke's No Objection on draft-ietf-pim-igmp-mld-snooping-yang-17: (with COMMENT)

    Éric Vyncke has entered the following ballot position for
    draft-ietf-pim-igmp-mld-snooping-yang-17: No Objection



    == COMMENTS ==
    I am not a big expert in MLD or WiFi, but, it seems to me that this YANG module covers only the important use case of switches. But, if not mistaken, some WiFi access points also do a similar job and translates L2 mcast addresses into a series of L2 unicast addresses. Was it considered in this model ?
    [Authors] This YANG module is used to configure IGMP & MLD Snooping devices, and doesn't care the device type. The IGMP & MLD Snooping details are described in RFC 4541.

    -- Section 1.1 --
    English is not my native language, but, I have hard time to parse "mrouter:
    multicast router, which means nodes attached to a switch have multicast routing enabled" is a switch or a router ?
    [Authors] Would you think that the following rewording is ok?
    "mrouter: multicast router, which is a router that has multicast routing enabled"

    -- Section 2.3 --
    No need to reply on this one, but, I really do not like separating the IPv4 and
    IPv6 branches of the trees. It looks to me like doubling the operational cost but not sharing common properties; hence, diminishing the usefulness of this document. I made the same comment for RFC 8652 and there is really no need to repeat what I consider as mistakes.

    -- Section 4 --
    The description parts of the YANG module are quite short so I may have overlooked some parts of it... so bear with my two COMMENTs below:

    1) for a MLD group, why having the mac-address leaf ? AFAIK, the mac-address is derived from the group IPv6 mcast address. Storing related information twice in a model looks bad to me (I am a big fan of the SQL normal forms...)
    [Authors] This makes it more reliable.

    2) some switches does not snoop MLD for link-local groups (sollicited node mcast for example). Is this feature listed in the list of features ?
    [Authors] We don't support this feature, because it is not mentioned in RFC 4541. For now we leave it to the vendor augmentation.