Re: [pim] Mirja Kühlewind's No Objection on draft-ietf-pim-igmp-mld-yang-13: (with COMMENT)

Xufeng Liu <xufeng.liu.ietf@gmail.com> Tue, 28 May 2019 14:04 UTC

Return-Path: <xufeng.liu.ietf@gmail.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 65FA512004B; Tue, 28 May 2019 07:04:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TDwxlkuy_5-C; Tue, 28 May 2019 07:04:31 -0700 (PDT)
Received: from mail-it1-x12d.google.com (mail-it1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 872A9120158; Tue, 28 May 2019 07:04:31 -0700 (PDT)
Received: by mail-it1-x12d.google.com with SMTP id 9so4058978itf.4; Tue, 28 May 2019 07:04:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qaP/VGF+SLZQA58UeCSu6RbpHOIv05+q+7S4H2oZ+w0=; b=kVCQLYSZhcYJjkofeQz3uRe7AEiBN2BsVryFqlGnDAcHOoCHzZ6RbfQqy2v/Xo6iJj lQpW50om1QfG8lIBczR2rU+QKC8QbMgW68WMnsYpYAIB/fpkymzdAwEZ6ivfoyC9zIaJ TQfh7pn3yuCXy42h1D48KbjbPx7rsLxUC2SpymZ8HlCWLcuuPY+os8q2dAwDV5KL267D OTX4Sa3rC+mVrRZ/Rh9/StvApXjwfPajCPsp2LZpSUzFUX3G06Xr+vaqilFU13Hk/l9U xp/nfY47ZmgJtxkQ0q0eFQ7PIZPj5Krs9Sj9yLfhAcE0vZCO2hR1OLdUxhl8tHekAwPd l2Zg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qaP/VGF+SLZQA58UeCSu6RbpHOIv05+q+7S4H2oZ+w0=; b=jF2EKi4tBh9/VkloALO+OKckjDTB1Df4RU2MW4G/+Z0ZVgo7D+LG8TPfC10Q7S9pO1 8QU3G+eYM7hSVxFW1E6b+957yaoPRhhcigjqT8Of+LOcC8BRgpC7l0F+KH0R91eWeiEF 9ScwiOerAi2HWsIs3FptU7idLtbPtZmvsvvO30wyxeEm99kO4qTGnSbywaU9U2M6mH9N tU/7j0yZ/InKDV+DkFVpOTbBSwQZ1gtxDrRhN6YGgCf7M4+XaZ3APIZudd/aIpXpkZLb 0bbyqdyjt/g+tTr3hSvLOa24C0o3xBLG443Q9ZkzKJuC24PeOGJDFDjtqauzkIhsyoSS woVQ==
X-Gm-Message-State: APjAAAWsHu65M0ZNRb1dkAPSN5Jy9AgV9OnFl2pQ48J5g/r/Zy4lJ/jQ KLix5EntqlHAnSeGXv5L9g+QWDCp4btV5OxeuPg=
X-Google-Smtp-Source: APXvYqwqAWIRwet+UOzz7DQEeNXxaXZWibtcFT8UfVLgqWmrqs2b8jilH/2dvOcvRbLlxY1yV3AhcJbog/7nAtlB8iE=
X-Received: by 2002:a24:a004:: with SMTP id o4mr3125506ite.167.1559052270746; Tue, 28 May 2019 07:04:30 -0700 (PDT)
MIME-Version: 1.0
References: <155871943771.12273.17148916156796470545.idtracker@ietfa.amsl.com>
In-Reply-To: <155871943771.12273.17148916156796470545.idtracker@ietfa.amsl.com>
From: Xufeng Liu <xufeng.liu.ietf@gmail.com>
Date: Tue, 28 May 2019 10:04:19 -0400
Message-ID: <CAEz6PPR+UVdSA3zZk2HjV1fHA2QSLB5aReaRgQkNf6vd+PZEPw@mail.gmail.com>
To: Mirja Kühlewind <ietf@kuehlewind.net>
Cc: The IESG <iesg@ietf.org>, draft-ietf-pim-igmp-mld-yang@ietf.org, Stig Venaas <stig@venaas.com>, Alvaro Retana <aretana.ietf@gmail.com>, pim-chairs@ietf.org, pim@ietf.org
Content-Type: multipart/alternative; boundary="000000000000c8c1b80589f324bb"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/Khy_rwfT6Z5GMSHZs61Jqw7hqng>
Subject: Re: [pim] Mirja Kühlewind's No Objection on draft-ietf-pim-igmp-mld-yang-13: (with COMMENT)
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 May 2019 14:04:35 -0000

Hi Mirja,

Thanks for the review. We have proposed the changes in details below.
Regards,
- Xufeng

On Fri, May 24, 2019 at 1:37 PM Mirja Kühlewind via Datatracker <
noreply@ietf.org> wrote:

> Mirja Kühlewind has entered the following ballot position for
> draft-ietf-pim-igmp-mld-yang-13: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-pim-igmp-mld-yang/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Two quick questions:
>
> 1) Not sure about the current practice about YANG models but shouldn’t this
> document eventually update RFC8349?
>
[Xufeng]:  The current practice is not to update RFC8349, but to reference
it.


>
> 2) Also maybe it would make sense to discuss the sensitivity of
> explicit-tracking separately in the security consideration section?
>
[Xufeng]: Since RFC6636 does not describe the security risks in details, we
can add the following to this this document.

[OLD]:5. Security Considerations
  igmp-mold:interfaces/interface

     This subtree specifies the configuration for the IGMP attributes
     at the interface level on an IGMP instance.  Modifying the
     configuration can cause IGMP membership deleted or reconstructed
     on a specific interface of an IGMP instance.[NEW]:5. Security
Considerations
  igmp-mold:interfaces/interface

     This subtree specifies the configuration for the IGMP attributes
     at the interface level on an IGMP instance.  Modifying the
     configuration can cause IGMP membership deleted or reconstructed
     on a specific interface of an IGMP instance.The explicit-tracking
leaf enables the explicit membership tracking function on this
multicast router. Enabling this function will cause the router to
record more multicast membership information including all hosts that
receive multicast messages.
[OLD]:      /rt:routing/rt:control-plane-protocols
   /rt:control-plane-protocol/igmmp-mld:igmp

   /rt:routing/rt:control-plane-protocols
   /rt:control-plane-protocol/igmp-mld:mld

   Unauthorized access to any data node of the above subtree can
   disclose the operational state information of IGMP or MLD on this
   device.[NEW]:      /rt:routing/rt:control-plane-protocols
   /rt:control-plane-protocol/igmmp-mld:igmp

   /rt:routing/rt:control-plane-protocols
   /rt:control-plane-protocol/igmp-mld:mld

   Unauthorized access to any data node of the above subtree can
   disclose the operational state information of IGMP or MLD on this
   device.Under /rt:routing/rt:control-plane-protocols
/rt:control-plane-protocol/igmp-mld:igmp,
and /rt:routing/rt:control-plane-protocols
/rt:control-plane-protocol/igmp-mld:mld,
igmp-mLd:interfaces/interfaceThe explicit-tracking leaf shows whether
the explicit membership tracking function is enabled on this multicast
router. When this function is enabled, the sub-tree group/source/host
contains the membership information of all the hosts that receive
multicast messages. Unauthorized access to this sub-tree may disclose
such information.
In addition, we will RFC6636 to the reference list, and add a
“reference” statement to the description of the leaf
“explicit-tracking” in the model.


Is it ok to make such changes?

Thanks,

- Xufeng