Re: [pim] Paul Wouters' No Objection on draft-ietf-pim-assert-packing-10: (with COMMENT)

Toerless Eckert <tte@cs.fau.de> Wed, 15 March 2023 05:25 UTC

Return-Path: <eckert@i4.informatik.uni-erlangen.de>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 65849C14CE27; Tue, 14 Mar 2023 22:25:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.647
X-Spam-Level:
X-Spam-Status: No, score=-6.647 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DZy-DieRqJ0G; Tue, 14 Mar 2023 22:25:31 -0700 (PDT)
Received: from faui40.informatik.uni-erlangen.de (faui40.informatik.uni-erlangen.de [131.188.34.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C9A21C14CE55; Tue, 14 Mar 2023 22:25:26 -0700 (PDT)
Received: from faui48e.informatik.uni-erlangen.de (faui48e.informatik.uni-erlangen.de [131.188.34.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by faui40.informatik.uni-erlangen.de (Postfix) with ESMTPS id 4PbzPF1T2SznkdT; Wed, 15 Mar 2023 06:25:21 +0100 (CET)
Received: by faui48e.informatik.uni-erlangen.de (Postfix, from userid 10463) id 4PbzPF0r0RzkvKD; Wed, 15 Mar 2023 06:25:21 +0100 (CET)
Date: Wed, 15 Mar 2023 06:25:21 +0100
From: Toerless Eckert <tte@cs.fau.de>
To: Paul Wouters <paul.wouters@aiven.io>
Cc: The IESG <iesg@ietf.org>, draft-ietf-pim-assert-packing@ietf.org, pim-chairs@ietf.org, pim@ietf.org, stig@venaas.com, aretana.ietf@gmail.com
Message-ID: <ZBFWwd/IQTjSB5ba@faui48e.informatik.uni-erlangen.de>
References: <167884459389.25625.8459361908215997016@ietfa.amsl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <167884459389.25625.8459361908215997016@ietfa.amsl.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/MZNoDqnBqhBmy-Knk2Z4-Pp4lV0>
Subject: Re: [pim] Paul Wouters' No Objection on draft-ietf-pim-assert-packing-10: (with COMMENT)
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Mar 2023 05:25:35 -0000

Thanks, Paul

reply Q/answers inline

On Tue, Mar 14, 2023 at 06:43:13PM -0700, Paul Wouters via Datatracker wrote:
> Paul Wouters has entered the following ballot position for
> draft-ietf-pim-assert-packing-10: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
> for more information about how to handle DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-pim-assert-packing/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
>         M: The number of Assert Records in the message. Derived from the length
>         of the packet carrying the message.
> 
> I find it a bit odd that this section describes packet fields, and then lists a
> "field" that is not a real field but a derivation. Can this not be written
> without the "M:" classifier and outside of the list describing the packet
> fields? This occurs a number of times in the document.

I am not sure i correctly parse your concern, maybe rephrase unless the
following rewrite:

From:

 *  M: The number of Assert Records in the message.  Derived from the
      length of the packet carrying the message.

   The format of each Assert Record is the same as the PIM assert
   message body as specified in Section 4.9.6 of [RFC7761].

To:
 *  Assert Record: formatted according to Figure 4, wich is the same
    as the PIM assert message body as specified in Section 4.9.6 of [RFC7761].
    The number M of Assert Records is determined from the packet size.


> Like Robert Sparks, I am interested his question from the secdir review:
> 
>    There's discussion of not using packing unless all PIM
>    routers in the same subnet have announced the Assert Packing Hello Option.
>    What happens in a running environment that is busy using packing when a new
>    PIM router is added? If traffic from that PIM router is seen that is not yet
>    the needed Hello Option, should all senders stop packing until the needed
>    Hello Option arrives, and maybe resend recently packed asserts as unpacked?

Reply to Robert in:
  https://mailarchive.ietf.org/arch/msg/pim/6W54T7Cpj_tp_4JqytKnRmiNU6Q

Pls let me know if you see insufficiencies in that answer that would
cause a need for draft text enhancements in your opinion (such as what
i wrote to Robert).

Cheers
    Toerless