Re: [pim] [Last-Call] Last Call: <draft-ietf-pim-msdp-yang-08.txt> (A YANG DataModel for Multicast Source Discovery Protocol (MSDP)) to Proposed Standard

tom petch <daedulus@btconnect.com> Tue, 28 January 2020 11:30 UTC

Return-Path: <daedulus@btconnect.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 97CAE120018; Tue, 28 Jan 2020 03:30:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9rkETcHka3vz; Tue, 28 Jan 2020 03:30:39 -0800 (PST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0701.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::701]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B718D120013; Tue, 28 Jan 2020 03:30:38 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oare1tBehPaP8BrfVZuBt4145WgsVaZa6pT1rre8++03Uw9R3WUPHoVmdV4lWK3Jb8cBE/zQC7IATQcjdFnKl1wns0K4Hw5fcj0dQWw9w5b4ewR1z03vL3RDadwbIwxWLLdxIMC1Ttpmb2SKQ4X3BCFbEKHR9KCz6U78dWSXkog8lPBeTYXQJ52dMmaEX0VMxG6c7tQxtWnzoWzeQtz6X7NMhcdcPG0+ZPocstGrTV46P0D1lsBTCwY7FvGe9LLIqex9Y9aekVCXPIS9ppc6BtG0u2X8HmosmN2DnvV/fddnD9VXoqwCEPmWtlOSisFUO+3BNl812x6z9ZQvbMEdbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sC5tA/QN50ZipvFzxnqeFeDeqpOqv9UYu1fHFv8YOGs=; b=LFXT5yL3X8LhgrRc6OmL+UKAp/6p94HwIwZKCXhDtGVmTuMlJuSJpn/iiWrZQxyK+S8QEsNcDEX/SyB5akv2joTIahS5QCThiez82xgn6q/80tg0aPR1MKzrJyAJz6PU3xS28p5p0vwbFTQ7hy7m8WH1slv7YWmNQyqylr6FVTBZzWg+mei3k0uGMHhqirabg+5AjTCAPEvq5c6vFe7GV1Q8nvyYhYnOiU8Yp2soC2Skfakg4pkgT+fsCypnzOwMkXGVW5aU6jaQ2kL31vPwEdGPbFQe85xUW1CqixtGrgKzH9NJjoqm+qie1lR3kZd2EHKdAHT3VD1E6mRS3oeSkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sC5tA/QN50ZipvFzxnqeFeDeqpOqv9UYu1fHFv8YOGs=; b=NzMK/N4cghulx5mwsMAmK0E9+MaxyytjBwUxR9rfFCYn5IzBWiaqlODGi4cjUCIfV9x+ALrueAo4nLIuET8T143Q3SqTsM1IoHvYUH/me5qKR4rwm7ISkhdXIjo6VduVzE2vJS/KIeI4o5sQF45RUZ2TgnDoLgE8Q3txQQJMEDw=
Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=daedulus@btconnect.com;
Received: from VI1PR07MB3502.eurprd07.prod.outlook.com (10.170.237.22) by VI1PR07MB5949.eurprd07.prod.outlook.com (20.178.14.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.15; Tue, 28 Jan 2020 11:19:22 +0000
Received: from VI1PR07MB3502.eurprd07.prod.outlook.com ([fe80::894f:56de:4611:2212]) by VI1PR07MB3502.eurprd07.prod.outlook.com ([fe80::894f:56de:4611:2212%7]) with mapi id 15.20.2686.019; Tue, 28 Jan 2020 11:19:22 +0000
To: zhang.zheng@zte.com.cn
References: <202001240927274896282@zte.com.cn>
Cc: last-call@ietf.org, pim-chairs@ietf.org, pim@ietf.org, draft-ietf-pim-msdp-yang@ietf.org
From: tom petch <daedulus@btconnect.com>
Message-ID: <5E3018B2.1080105@btconnect.com>
Date: Tue, 28 Jan 2020 11:19:14 +0000
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
In-Reply-To: <202001240927274896282@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P123CA0037.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::25) To VI1PR07MB3502.eurprd07.prod.outlook.com (2603:10a6:802:1a::22)
MIME-Version: 1.0
Received: from [192.168.1.65] (86.139.211.103) by LO2P123CA0037.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2665.20 via Frontend Transport; Tue, 28 Jan 2020 11:19:21 +0000
X-Originating-IP: [86.139.211.103]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: adf3ba18-2166-4a59-5ba1-08d7a3e3ec89
X-MS-TrafficTypeDiagnostic: VI1PR07MB5949:
X-Microsoft-Antispam-PRVS: <VI1PR07MB59495E29E979D7ED9D254FD6C60A0@VI1PR07MB5949.eurprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-Forefront-PRVS: 029651C7A1
X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(136003)(39860400002)(376002)(346002)(396003)(366004)(189003)(199004)(53546011)(8936002)(956004)(81166006)(8676002)(81156014)(52116002)(2616005)(66476007)(6916009)(36756003)(66556008)(16526019)(26005)(186003)(316002)(66946007)(6666004)(5660300002)(16576012)(87266011)(33656002)(478600001)(86362001)(966005)(2906002)(4326008)(6486002); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR07MB5949; H:VI1PR07MB3502.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:0;
Received-SPF: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: PAYam9skvqQezX11D2KdLMvrMJHX/rQZKceFqEM7+pIgTCiXzZiBboi44CJnR5sJ8KO1BF/CVqST03dPQgiY/SD7GqmWW3Iu0fnslLWgcwMu54hJJjH1ntBl/uVbVElZ5wvaEywTJHX3PBQCUoKo35jAM/UWGmFMV3NH4zCw+a28c9xat3iQlElf3eQ4JLFGQMnjnnTJs6KiChcOjl7XUl8K/7xOsN9IzqWwphbaiFp5QRhbpfheoToqJjaLqD95sIGIf+BDDZJFzmXZE2ik07PfeAH+T41wz8EcbfIqGJnry6u5pS6P1nwAogvv4VUtNCENp191KE5xO2sWWDMAAbatMGkWKUS1vORnS2u5xcHaK+4IqeEa6aYbAL62p8LBQSTeSXX9xNlVpNm1mx09Ajy4WmGiArv7hpnsxePf0b9K/sQbBParNiZrIPbIxkNDx2Zq3+xm4VFh3qFn+h/cEpG16UQTe0AU9HsznWESwgrsx/scfut+QVMqkt2DDnH1Utw4hJBMzbZALZL11Dw8ig==
X-MS-Exchange-AntiSpam-MessageData: nNu3jXRFarh6vp7jFC8FkSPsV6ICXNnOW15TxWs638Mdxx5a/CMOx5Efx37yEBlsAfcD/mGBTyuMgaPRNLxv9o5H/etRtX01irOotpafrgrNILr5TGzjzYYRtKdKb9Ti0DXrznPzaea8bDvNNrQzEQ==
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: adf3ba18-2166-4a59-5ba1-08d7a3e3ec89
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2020 11:19:21.9521 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T62/HSv2gbVs1Bt56djblO4szucS+KZf8iVG3DXmLAcn3TATkKWcB2u/v38LqOuDjHOWOe3RX5QS9SmZIYiQKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB5949
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/MZgONFEhZmE3_sZ17yUyafOJTVw>
Subject: Re: [pim] [Last-Call] Last Call: <draft-ietf-pim-msdp-yang-08.txt> (A YANG DataModel for Multicast Source Discovery Protocol (MSDP)) to Proposed Standard
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jan 2020 11:30:44 -0000

On 24/01/2020 01:27, zhang.zheng@zte.com.cn wrote:
> Hi Tom,
>
> Thank you very much for your review!
>
> Please review the newest 12 version.

You do not seem to have responded to some of my comments.

Yes, the augment is now in the right place but ..
the description says that it is only valid MSDP but there is no 'when' 
statement to enforce this.

On the other hand, identity now appears but is conditional; this would 
seem to me to make it of limited value - I do not see that conditional 
in other YANG modules.

Features need YANG reference clauses IMHO and I like a list in the body 
of the I-D as well

The RFC number is not something you insert.  The RFC Editor allocates 
and inserts it.  Although it is the convention to use XXXX as a 
placeholder, I think it helpful to include a note up front asking them 
to replace XXXX with the assigned number (many I-Ds have references to 
more than one I-D so it is helpful to be explicit about what is XXXX and 
what is YYYY although that is not an issue here)

tcp-connection-source is still testing for IPv4 configured, not as the 
description says enabled

I note too that you have six authors; the limit is normally five unless 
this has been agreed by the AD.


Tom Petch


>
> Thank you very much! :-)
>
>
>
>
>
>
> Best regards,
>
>
> Sandy
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> 原始邮件
>
>
>
> 发件人:tompetch <ietfid@btconnect.com>
> 收件人:IETF-Announce <ietf-announce@ietf.org>;last-call@ietf.org <last-call@ietf.org>rg>;
> 抄送人:pim-chairs@ietf.org <pim-chairs@ietf.org>;pim@ietf.org <pim@ietf.org>;draft-ietf-pim-msdp-yang@ietf.org <draft-ietf-pim-msdp-yang@ietf.org>rg>;
> 日 期 :2020年01月23日 00:21
> 主 题 :Re: [pim] Last Call: <draft-ietf-pim-msdp-yang-08.txt> (A YANG DataModel for Multicast Source Discovery Protocol (MSDP)) to Proposed Standard
>
>
>
>
> RFC8349 says that a new identity MUST be defined for a new control plane protocol - I see no such definition here
>
> RFC8349 says that augments should be to control-plane-protocols/control-plane-protocol as is seen in the OSPF and the other LSR YANG modules; here I see an augment to control-plane-protocols which seems wrong to me
>
> many features but no idea where to look them up - I think every YANG feature needs a YANG reference to an I-D/RFC
>
> I find a list of features and references in the body of an I-D valuable
>
> YANG modules must be plain text; [3618] in the module description does not look like plain text. Other references e.g. RFC8177 look ok although some have a space in them and some do not
>
> leaf tcp-connection-source says that ipv4 must be enabled but the when statement does not test for enabled, just for configured
>
> rpc clear peer clears everything if there is no address - this is fail danger, a specific value for clear all would IMHO be better engineering
>
> XXXX is likely to mean this I-D/RFC but I always like to see a specific direction to the RFC Editor to that effect, just the once, somewhere near the front.
>
> In the same vein, a direction to replace the dates with date of publication  would not go amiss
>
> Tom Petch
> ________________________________________
> From: IETF-Announce <ietf-announce-bounces@ietf.org> on behalf of The IESG <iesg-secretary@ietf.org>
> Sent: 15 January 2020 20:29
> To: IETF-Announce
> Cc: draft-ietf-pim-msdp-yang@ietf.org; pim-chairs@ietf.org; pim@ietf.org
> Subject: Last Call: <draft-ietf-pim-msdp-yang-08.txt> (A YANG Data Model for Multicast Source Discovery Protocol (MSDP)) to Proposed Standard
>
>
> The IESG has received a request from the Protocols for IP Multicast WG (pim)
> to consider the following document: - 'A YANG Data Model for Multicast Source
> Discovery Protocol (MSDP)'
>    <draft-ietf-pim-msdp-yang-08.txt> as Proposed Standard
>
> The IESG plans to make a decision in the next few weeks, and solicits final
> comments on this action. Please send substantive comments to the
> last-call@ietf.org mailing lists by 2020-01-30. Exceptionally, comments may
> be sent to iesg@ietf.org instead. In either case, please retain the beginning
> of the Subject line to allow automated sorting.
>
> Abstract
>
>
>     This document defines a YANG data model for the configuration and
>     management of Multicast Source Discovery Protocol (MSDP) Protocol.
>
>
>
>
> The file can be obtained via
> https://datatracker.ietf.org/doc/draft-ietf-pim-msdp-yang/
>
> IESG discussion can be tracked via
> https://datatracker.ietf.org/doc/draft-ietf-pim-msdp-yang/ballot/
>
>
> No IPR declarations have been submitted directly on this I-D.
>
>
>
>
> _______________________________________________
> IETF-Announce mailing list
> IETF-Announce@ietf.org
> https://www.ietf.org/mailman/listinfo/ietf-announce
>
> _______________________________________________
> pim mailing list
> pim@ietf.org
> https://www.ietf.org/mailman/listinfo/pim
>
>
>