Re: [pim] Éric Vyncke's No Objection on draft-ietf-pim-igmp-mld-snooping-yang-17: (with COMMENT)

Hongji Zhao <hongji.zhao@ericsson.com> Wed, 12 August 2020 03:58 UTC

Return-Path: <hongji.zhao@ericsson.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF3C83A0EEA; Tue, 11 Aug 2020 20:58:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.102
X-Spam-Level:
X-Spam-Status: No, score=-2.102 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ywu3iexYhZua; Tue, 11 Aug 2020 20:58:40 -0700 (PDT)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30045.outbound.protection.outlook.com [40.107.3.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4DF2D3A0EEB; Tue, 11 Aug 2020 20:58:40 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=elDn8eWRngIGjiPIO7rMm/WAqy2am7CLhoM3V3AHsxQtUqvC/Jik8MN+bmskvfaqK/fY1oRKEWFuR5JXkrAw4gNvsqjkYL1TofbBxuhopUfpu4mM/lL+NaT+S/Zq0veYzVj4StUCwoOxhXHBKab7CbEEWYfKFuNkRkS22tws0UO6ZPBDaUNHUX8IkIUOvAs5Sft/LVtEmOrOsu/uVNgJJ6+RAPeAP4aicqRc4Eh3wR7oAGuO0glf1INh06DmbeTSUMlFyIr7XubLpZ8VZPU4nk3Sxh+Pu80QPRaz/SlVQtgS7HqwtewM+osZcgKCgUnm/G8GNilFu0TjS3uHJvNpkA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ENNeMePGz5iORgTDNkZn10FKOrzWWjr97gRrja5xK4c=; b=UIMSuT9bCfzI1Et/PhmMUB51GJ/9ZUd91MhYNGUpehskmCAQ84els0SnINtOSTsSx+3BsYjXAtDMsCuxgDCBUr0+L1ag0a05TpnXELNrc40bF22S0vFB6dfc1jY94V7GUrH3kGyxYgA1YCKpJpkmFod5BtrmHY6LLGi3JKqP68FVgPhxkEz7pYbdIezIcGBfw+4Vl6AcSbX1BVNM46gMaczn6bQe/IVSRvzegtwWsstzwAQb1OXM2Y0OjkJUvDV7tMYu9YWn3alwKEoep3U+KRiUVgCeBRcujlb70/r5NmaYvpOElk8XbQu9ocgMd2sFoQ04Oammr9gSTW7gmHj6Dg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ENNeMePGz5iORgTDNkZn10FKOrzWWjr97gRrja5xK4c=; b=qPha5Y2+K/WjVkw0l5bTY3WooO16apmQ4zmfplIToK0bMKplLPB2+whUEdmOG/uWH4WJDwZe6hquBfzDAUnE+BtuFbFQaM481sautIKt2LC5ygMC/pfUaZpwlNRd39QGSh0fA6i8EgDLNNgcBIcVr2dRsbB+3okrbh3C4L2grAg=
Received: from HE1PR0701MB2492.eurprd07.prod.outlook.com (2603:10a6:3:71::22) by HE1PR0702MB3753.eurprd07.prod.outlook.com (2603:10a6:7:84::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.14; Wed, 12 Aug 2020 03:58:33 +0000
Received: from HE1PR0701MB2492.eurprd07.prod.outlook.com ([fe80::ec82:bf39:2810:fbb0]) by HE1PR0701MB2492.eurprd07.prod.outlook.com ([fe80::ec82:bf39:2810:fbb0%7]) with mapi id 15.20.3283.014; Wed, 12 Aug 2020 03:58:33 +0000
From: Hongji Zhao <hongji.zhao@ericsson.com>
To: =?utf-8?B?w4lyaWMgVnluY2tl?= <evyncke@cisco.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-pim-igmp-mld-snooping-yang@ietf.org" <draft-ietf-pim-igmp-mld-snooping-yang@ietf.org>, "pim-chairs@ietf.org" <pim-chairs@ietf.org>, "pim@ietf.org" <pim@ietf.org>, Stig Venaas <stig@venaas.com>, "aretana.ietf@gmail.com" <aretana.ietf@gmail.com>
Thread-Topic: =?utf-8?B?w4lyaWMgVnluY2tlJ3MgTm8gT2JqZWN0aW9uIG9uIGRyYWZ0LWlldGYtcGlt?= =?utf-8?Q?-igmp-mld-snooping-yang-17:_(with_COMMENT)?=
Thread-Index: AQHWVb9unxrC4nFF0k+N64t3JQlaKak0C7mA
Date: Wed, 12 Aug 2020 03:58:33 +0000
Message-ID: <HE1PR0701MB24927B22AF2C5419E328A9A096420@HE1PR0701MB2492.eurprd07.prod.outlook.com>
References: <159427834725.21252.8658233194269644768@ietfa.amsl.com>
In-Reply-To: <159427834725.21252.8658233194269644768@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: cisco.com; dkim=none (message not signed) header.d=none;cisco.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [120.244.60.16]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b6c57461-8666-4564-622e-08d83e73fbbf
x-ms-traffictypediagnostic: HE1PR0702MB3753:
x-microsoft-antispam-prvs: <HE1PR0702MB3753EE270F1A14E0E1DCABBA96420@HE1PR0702MB3753.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Izds9CbWR1mIL9ToMHWtV8snZxvkG5NMhoAozncnMLgiPP/Shkifv0CHbkPxG3bQXLYCFvvfosq0MUR3S2RbRIf761vfDgBhtTK4+i6R4H2elKxXAAH3nw7E0d2+6MxvelXKWeA/uEoDAUWsSokVS5365v4e69Xo23o0Ek7EjJhF3NNUmrm/Wt9VYeUFOzxBlLlLlCjrYKGa0eFHEX/LsTmLWgAEGgHKQv19/rq8SgVdUB9SNbwJClj2T/YV2HL98hsXIoai4xagY2p2aB+fYxXAsCLpSyBlrTtCp5NYsqkEb1rko3ECBzFp16+Vf+U5rdwMaeMG6LTC+rdhF1cp/Q==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0701MB2492.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(26005)(186003)(44832011)(52536014)(66574015)(76116006)(66476007)(64756008)(66946007)(83380400001)(66556008)(66446008)(5660300002)(6506007)(7696005)(55016002)(478600001)(33656002)(53546011)(316002)(86362001)(8936002)(9686003)(71200400001)(110136005)(224303003)(4326008)(2906002)(54906003); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: ZDwar/Wxn6mmNkE/vTbVeaeZz8PJX2k7P73j0qm0yJPbysQMK8O9oX5CC7jug7fYG6J/pRIeBTd7CC4+YhzcNQbgqAoYUlQU5i+HAUQhQ6q5Hh7FYyaiRGhBlF1FSl6Wnxwjzdyc+WhewMDBVmuAdXJcQIRNL+WDEaevX4HKKiqMcvjXLfyD/XmUMWq4q9FMPEKkxdNpyzWw8PdgMbFnA58dF/1BuN38IIReMlh1p6G2/QsdjKtz3lZ6vPF4nIPrgN8Q3wpAfIsjzHd3+iFhIHy8o2GbBDi4Ls1QEgg1bpZSBRmv4Qtn33asF8JhUvxF0jK7CNQqIUs1+DjoFw1IROuRdckqb7NsmNWCXltjW6m8NipWePL9TM5BhHBSqL7YTjh5sjRhuTzRRjOfI7WSkMOb1V1BhY4jWrdsiniLoeKdPiKaemkewm3uuDCiDEIURWH5sWtdWNUvC1+YO97iVf+K4sKT9+rTq8TfltplB2ZZfoTIQQGsnWHQnaubg/3BUnJ6QNtyzp2Ul/JzwFvdVYmZH7idlqCfP37uloH2Kfqnh5C47eaTT9cDq8g+KHf9H2j/fPLzjY5WHtkHRBPdUjP4ePbuFazYk/qBJxG5pKtp1gomB7AT9PD9EfZejKriXeGku96oglYdO7RlTnMwYA==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0701MB2492.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6c57461-8666-4564-622e-08d83e73fbbf
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2020 03:58:33.7190 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: G14DLTlyL0qb4RvtltPoL4IxK5MgVhx3w1p6pcIXMPn42l/lhBCKdH7AtlDI+F4JTOosl7wKUxJLmGsQuICFwOSRrEwuj8DPkECI8iH9Qmk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0702MB3753
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/z2FMthkIfbKjouKjdUHzvCmjHB0>
Subject: Re: [pim] =?utf-8?q?=C3=89ric_Vyncke=27s_No_Objection_on_draft-ietf-?= =?utf-8?q?pim-igmp-mld-snooping-yang-17=3A_=28with_COMMENT=29?=
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Aug 2020 03:58:42 -0000

Hi Éric,

Thanks a lot for your comments. Please check inline.

BR/Hongji
赵宏吉

-----Original Message-----
From: Éric Vyncke via Datatracker <noreply@ietf.org> 
Sent: Thursday, July 9, 2020 3:06 PM
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-pim-igmp-mld-snooping-yang@ietf.org; pim-chairs@ietf.org; pim@ietf.org; Stig Venaas <stig@venaas.com>om>; aretana.ietf@gmail.com; stig@venaas.com
Subject: Éric Vyncke's No Objection on draft-ietf-pim-igmp-mld-snooping-yang-17: (with COMMENT)

Éric Vyncke has entered the following ballot position for
draft-ietf-pim-igmp-mld-snooping-yang-17: No Objection



== COMMENTS ==
I am not a big expert in MLD or WiFi, but, it seems to me that this YANG module covers only the important use case of switches. But, if not mistaken, some WiFi access points also do a similar job and translates L2 mcast addresses into a series of L2 unicast addresses. Was it considered in this model ?
[Authors] This YANG module is used to configure IGMP & MLD Snooping devices, and doesn't care the device type. The IGMP & MLD Snooping details are described in RFC 4541.

-- Section 1.1 --
English is not my native language, but, I have hard time to parse "mrouter:
multicast router, which means nodes attached to a switch have multicast routing enabled" is a switch or a router ?
[Authors] Would you think that the following rewording is ok?
"mrouter: multicast router, which is a router that has multicast routing enabled"

-- Section 2.3 --
No need to reply on this one, but, I really do not like separating the IPv4 and
IPv6 branches of the trees. It looks to me like doubling the operational cost but not sharing common properties; hence, diminishing the usefulness of this document. I made the same comment for RFC 8652 and there is really no need to repeat what I consider as mistakes.

-- Section 4 --
The description parts of the YANG module are quite short so I may have overlooked some parts of it... so bear with my two COMMENTs below:

1) for a MLD group, why having the mac-address leaf ? AFAIK, the mac-address is derived from the group IPv6 mcast address. Storing related information twice in a model looks bad to me (I am a big fan of the SQL normal forms...)
[Authors] This makes it more reliable.

2) some switches does not snoop MLD for link-local groups (sollicited node mcast for example). Is this feature listed in the list of features ?
[Authors] We don't support this feature, because it is not mentioned in RFC 4541. For now we leave it to the vendor augmentation.