[pim] Murray Kucherawy's No Objection on draft-ietf-pim-msdp-yang-17: (with COMMENT)

Murray Kucherawy via Datatracker <noreply@ietf.org> Mon, 13 April 2020 01:19 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: pim@ietf.org
Delivered-To: pim@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 23E2C3A0798; Sun, 12 Apr 2020 18:19:17 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Murray Kucherawy via Datatracker <noreply@ietf.org>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-pim-msdp-yang@ietf.org, pim-chairs@ietf.org, pim@ietf.org, Stig Venaas <stig@venaas.com>, aretana.ietf@gmail.com
X-Test-IDTracker: no
X-IETF-IDTracker: 6.126.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Murray Kucherawy <superuser@gmail.com>
Message-ID: <158674075710.15492.9360951677308376087@ietfa.amsl.com>
Date: Sun, 12 Apr 2020 18:19:17 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/WJB375h1vuFxq_H59zDLKumkO0o>
Subject: [pim] Murray Kucherawy's No Objection on draft-ietf-pim-msdp-yang-17: (with COMMENT)
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Apr 2020 01:19:17 -0000

Murray Kucherawy has entered the following ballot position for
draft-ietf-pim-msdp-yang-17: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-pim-msdp-yang/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

[ballot position under construction]

I'm assuming the sponsoring AD approved the presence of six authors on the
document, exceeding our normal limit of five.

I'm a YANG newbie so for the moment I'm going to defer to those more expert at
evaluating the syntax and semantics of the model described in Sections 3 and 4
while I go learn more about YANG in general.

Thus, the only feedback I have is editorial stuff in Section 5:
* "Modifying the configuration can cause MSDP default peers to be deleted or
the connection to be rebuilt, and the SA's unexpected filtering." -- does that
last clause mean "unexpected filtering by the SA"? * "The key misoperation will
broke the existed MSDP connection ... " -- s/broke the existed/break the
existing/, right? * "These are the subtrees and data nodes and their
sensitivity/vulnerability:" followed by a list of one subtree/node.  Maybe just
turn that into prose and name the singular subtree? * "... may lead to forged
connection attack, ..." -- s/to/to a/ * "... the ACL nodes uncorrected
modification may lead to the filter errors." -- "nodes" should be "node's" or
"nodes'" * "The unauthorized reading function ..." -- perhaps "Unauthorized
reads"? * "... allow the unexpected peer connection rebuilding." -- maybe
"allow the unexpected rebuilding of connection peers"? * "Authentication
configuration is supported ..." -- feels like this should start a new paragraph