[pim] Tsvart last call review of draft-ietf-pim-drlb-13

Michael Scharf via Datatracker <noreply@ietf.org> Tue, 29 October 2019 17:47 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: pim@ietf.org
Delivered-To: pim@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id D577B1200FE; Tue, 29 Oct 2019 10:47:52 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Michael Scharf via Datatracker <noreply@ietf.org>
To: <tsv-art@ietf.org>
Cc: last-call@ietf.org, pim@ietf.org, draft-ietf-pim-drlb.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.108.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Michael Scharf <michael.scharf@hs-esslingen.de>
Message-ID: <157237127276.10862.9478907136177386826@ietfa.amsl.com>
Date: Tue, 29 Oct 2019 10:47:52 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/WXmFFK6WUMPAk5k8x_KAnrBXzSM>
Subject: [pim] Tsvart last call review of draft-ietf-pim-drlb-13
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 17:47:53 -0000

Reviewer: Michael Scharf
Review result: Ready

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

As far as I can see there are no fundamental transport-related issues in this
document. All in all, the impact of selecting a Group Designated Router may be
quite similar to the existing PIM-SM selection of a Designated Router.

A little bit of wordsmithing: In Section 6, it could be useful to replace the
term "enough total capacity" by another term, such as "enough available
capacity" or "enough spare capacity". The router links can obviously also carry
other, non-PIM traffic. Then there must be enough available bandwidth left for
the PIM traffic on top of non-PIM traffic. The term "total capacity" is a bit
vague; it could possibly refer to the physical link capacity (e.g., 1 Gbit/s
for Gigabit Ethernet). Only considering the physical link capacity would not be
correct. Actually, one could write more about the traffic engineering aspects
of GDR selection, e.g., whether it is realistic that traffic distribution is
really equal. Yet, given that there seems to be only one implementation
according to the shepherd write-up, just changing the term may be sufficient.