[pim] Secdir last call review of draft-ietf-pim-msdp-yang-12
Vincent Roca via Datatracker <noreply@ietf.org> Wed, 29 January 2020 08:18 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: pim@ietf.org
Delivered-To: pim@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 64EFA12022D; Wed, 29 Jan 2020 00:18:11 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Vincent Roca via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
Cc: last-call@ietf.org, draft-ietf-pim-msdp-yang.all@ietf.org, pim@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.116.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Vincent Roca <vincent.roca@inria.fr>
Message-ID: <158028589133.2819.6239221909447380902@ietfa.amsl.com>
Date: Wed, 29 Jan 2020 00:18:11 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/XsC-BCl_ia4sm3U3xj1XQz8OQ8o>
Subject: [pim] Secdir last call review of draft-ietf-pim-msdp-yang-12
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jan 2020 08:18:11 -0000
Reviewer: Vincent Roca Review result: Has Nits Hello, I have reviewed this document as part of the security directorate’s ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors. Document editors and WG chairs should treat these comments just like any other last call comments. Summary: Ready with nits The security considerations section is globally well writen and addresses important topics. I don't have major comments. Details: - it is said that "(i.e., config true, which is the default)". I've searched in the YANG model and only found "config false" entries which seems to contradict what is said in section 5. - Section 2.1 says: "This model can be used to configure and manage MSDP protocols." (with a final "s") which suggests there could be several MSDP protocols. I think it's a mistake. Cheers, Vincent
- [pim] Secdir last call review of draft-ietf-pim-m… Vincent Roca via Datatracker
- Re: [pim] [secdir] Secdir last call review of dra… Benjamin Kaduk
- Re: [pim] [secdir] Secdir last call review ofdraf… zhang.zheng
- Re: [pim] [secdir] Secdir last call review ofdraf… Benjamin Kaduk