Re: [pim] [secdir] Secdir last call review of draft-ietf-pim-msdp-yang-12

Benjamin Kaduk <kaduk@mit.edu> Sun, 02 February 2020 16:08 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1B31712004D; Sun, 2 Feb 2020 08:08:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jRJcBaVFb2wi; Sun, 2 Feb 2020 08:08:22 -0800 (PST)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D8335120125; Sun, 2 Feb 2020 08:08:21 -0800 (PST)
Received: from kduck.mit.edu ([24.16.140.251]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 012G8HNY019565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 2 Feb 2020 11:08:19 -0500
Date: Sun, 2 Feb 2020 08:08:16 -0800
From: Benjamin Kaduk <kaduk@mit.edu>
To: Vincent Roca <vincent.roca@inria.fr>
Cc: secdir@ietf.org, last-call@ietf.org, draft-ietf-pim-msdp-yang.all@ietf.org, pim@ietf.org
Message-ID: <20200202160816.GK91553@kduck.mit.edu>
References: <158028589133.2819.6239221909447380902@ietfa.amsl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <158028589133.2819.6239221909447380902@ietfa.amsl.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/Yvm4WHqIhuDoW6EPuls2wG59l7Q>
Subject: Re: [pim] [secdir] Secdir last call review of draft-ietf-pim-msdp-yang-12
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Feb 2020 16:08:24 -0000

Hi Vincent,

Thanks for doing the review!

On Wed, Jan 29, 2020 at 12:18:11AM -0800, Vincent Roca via Datatracker wrote:
> Reviewer: Vincent Roca
> Review result: Has Nits
> 
> Hello,
> 
> I have reviewed this document as part of the security directorate’s ongoing
> effort to review all IETF documents being processed by the IESG. These
> comments were written primarily for the benefit of the security area
> directors.  Document editors and WG chairs should treat these comments just
> like any other last call comments.
> 
> Summary: Ready with nits
> 
> The security considerations section is globally well writen and addresses
> important topics. I don't have major comments.
> 
> Details:
> - it is said that "(i.e., config true, which is the default)".
>   I've searched in the YANG model and only found "config false" entries which
>   seems to contradict what is said in section 5.

I think the idea is that you never actually say "config true", and rather
just omit any 'config' statement to get the default (writeable) behavior.
So I think there are still writeable leaves in this module.

-Ben

> - Section 2.1 says: "This model can be used to configure and manage MSDP
> protocols." (with a final "s") which suggests there could be several MSDP
> protocols. I think it's a mistake.
> 
> Cheers,    Vincent
> 
> _______________________________________________
> secdir mailing list
> secdir@ietf.org
> https://www.ietf.org/mailman/listinfo/secdir
> wiki: http://tools.ietf.org/area/sec/trac/wiki/SecDirReview