Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC
"Holland, Jake" <jholland@akamai.com> Fri, 18 December 2020 02:11 UTC
Return-Path: <jholland@akamai.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 37EC03A0E04 for <pim@ietfa.amsl.com>; Thu, 17 Dec 2020 18:11:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=akamai.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w9DYmMxTGXs4 for <pim@ietfa.amsl.com>; Thu, 17 Dec 2020 18:11:04 -0800 (PST)
Received: from mx0a-00190b01.pphosted.com (mx0a-00190b01.pphosted.com [IPv6:2620:100:9001:583::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 47B223A0E29 for <pim@ietf.org>; Thu, 17 Dec 2020 18:11:01 -0800 (PST)
Received: from pps.filterd (m0122333.ppops.net [127.0.0.1]) by mx0a-00190b01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BI242bi001215; Fri, 18 Dec 2020 02:10:57 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=from : to : subject : date : message-id : content-type : content-id : content-transfer-encoding : mime-version; s=jan2016.eng; bh=IEppUAH6TGXGELjgcLryYD0Zs7KndzA5idSJu449xSM=; b=jPWBBTZS3pSYd1NNuEFhef5LjfdZMtV4iCM2Us7oOCeM8wdXXgQ+Ldvn2eajlFcc58Sa rAwei+UdQd8HewBHcJeb1mO1Bzi91xpa41vZzKFs3pL3iV2cqlp1hL8LMiwW15AuShlG BYP4ch31ZdM/GuU1vzruVeSVsP0bWemmH03uMv3bWdB+cCbevKpcSTNRQXA19U2+8Q+I Mi3vjL2OhGzI8GxE01Q+aqIXovjLnm2326hiiIErmKyMmNWYyD6GhO2fdcUGy7xUZWrN g0duh87G7YBh30mDzuVPmhnzwFAyZOMGxQRB9ncd+TNi/SvgDDL97QbvsvyvgMyRHe6c wg==
Received: from prod-mail-ppoint3 (a72-247-45-31.deploy.static.akamaitechnologies.com [72.247.45.31] (may be forged)) by mx0a-00190b01.pphosted.com with ESMTP id 35dfsmd3fj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Dec 2020 02:10:57 +0000
Received: from pps.filterd (prod-mail-ppoint3.akamai.com [127.0.0.1]) by prod-mail-ppoint3.akamai.com (8.16.0.42/8.16.0.42) with SMTP id 0BI258ML001458; Thu, 17 Dec 2020 21:10:56 -0500
Received: from email.msg.corp.akamai.com ([172.27.165.115]) by prod-mail-ppoint3.akamai.com with ESMTP id 35ct33k3kg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 17 Dec 2020 21:10:56 -0500
Received: from USTX2EX-DAG1MB4.msg.corp.akamai.com (172.27.165.122) by ustx2ex-dag1mb4.msg.corp.akamai.com (172.27.165.122) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 17 Dec 2020 20:10:55 -0600
Received: from USTX2EX-DAG1MB4.msg.corp.akamai.com ([172.27.165.122]) by ustx2ex-dag1mb4.msg.corp.akamai.com ([172.27.165.122]) with mapi id 15.00.1497.010; Thu, 17 Dec 2020 20:10:55 -0600
From: "Holland, Jake" <jholland@akamai.com>
To: Michael McBride <michael.mcbride@futurewei.com>, "pim@ietf.org" <pim@ietf.org>
Thread-Topic: [pim] draft-ietf-pim-igmp-mld-extension WGLC
Thread-Index: AQHW1OME4gZ07lhpQVe0ISlVhcHfug==
Date: Fri, 18 Dec 2020 02:10:54 +0000
Message-ID: <1345A202-ECA1-47F0-BADD-D85E96BA9C30@akamai.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.44.20121301
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [172.27.164.43]
Content-Type: text/plain; charset="utf-8"
Content-ID: <CE5FC17F37AADB4B91DBB87E8C668094@akamai.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-17_17:2020-12-17, 2020-12-17 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012180012
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-17_17:2020-12-17, 2020-12-17 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1011 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012180012
X-Agari-Authentication-Results: mx.akamai.com; spf=${SPFResult} (sender IP is 72.247.45.31) smtp.mailfrom=jholland@akamai.com smtp.helo=prod-mail-ppoint3
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/hxVLJ9H73-SUKKaCA63bcFXdRgc>
Subject: Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Dec 2020 02:11:12 -0000
Hi PIM wg, I have a few minor comments on this draft. I believe they’re readily resolvable, but I think some go beyond nits. Overall the draft seems helpful to bier and possibly could support a few more things (e.g. population count in igmp/mld proxying might be useful if this gets any uptake). So I support moving it forward as soon as the issues can be resolved. 1. As with Jeffrey’s comments, my main technical comment regards the possibility of additional extra data beyond this extension, from the last paragraph in section 3. I think this possibility is confusing to handle, since if there are 2 separate uses the ordering is not clear, so if we imagine another bit indicating another kind of additional data, it would strictly have to be aware of this draft to ensure its data came afterward. I think using some of the reserved bits as a magic number might be a good call here, especially if we think there are existing implementations doing something with this space. But just disallowing any other data when the E bit is set seems like also a fine choice that clears up confusion. 2. I think the doc should specify the reaction if the length fields don't match up, or if anything exceeds the size of the packet or the extra space. (Do all the TLVs get ignored, or do the apparently-good TLVs get handled an then the rest get ignored?) 3. I think this draft's security considerations section is a bit light for the complexity it introduces. It might be worth checking how they handled this in the UDP options draft, I think the first and third paragraphs might have some useful language to copy: https://tools.ietf.org/html/draft-ietf-tsvwg-udp-options-09#section-17 4. The length fields described in section 3 should specify the units (that the lengths are given in octets). I also saw a few nits: 5. In the 2nd paragraph of section 1, I don't know what "resp." means here, and it's not defined. (From context it seems to be indicating that MLD and IGMP get the same language with different references?): The extension will be part of additional data as mentioned in [RFC3810] Section 5.1.12 (resp. [RFC3376] Section 4.1.10) for query messages and [RFC3810] Section 5.2.12 (resp. [RFC3376] Section 4.2.11) for report messages. 6. 2nd to last paragraph of section 4, singular "host" should be plural: the behavior of host and routers supporting the new types, consider 7. Last paragraph of section 4 has confusing phrasing with a couple of plurality mismatche ("mechanism do not" and "nodes may send older message"), and I think it's not quite right to say that a mechanism supports a protocol, rather than that the document defines a mechanism only for certain protocol versions. You could just fix the plurality, but I'll suggest some different text that sounds more correct to me, but please feel free to use it or not: OLD: The extension mechanism do not support IGMPv1, IGMPv2 and MLDv1. As nodes may send older version message, they would also not be able to send messages using this extension. Suggested: This document defines an extension mechanism only for IGMPv3 and MLDv2. No E bit or extension mechanism is defined here for IGMPv1, IGMPv2, or MLDv1. Best regards, Jake From: Michael McBride <michael.mcbride@futurewei.com> Date: Monday, December 7, 2020 at 4:23 PM To: "pim@ietf.org" <pim@ietf.org> Subject: [pim] draft-ietf-pim-igmp-mld-extension WGLC Hello all, Today begins a two week wglc for https://urldefense.com/v3/__https:/tools.ietf.org/html/draft-ietf-pim-igmp-mld-extension-02__;!!GjvTz_vk!EKc8vPWuhUwwzwkh8HXSN0mQ88VZX4J9iug9ei03YduV64M2tP9qW4Om3ngQn08$ Please review (it’s a quick read) and let us know your opinion on it’s readiness to progress to the iesg. Thanks, mike
- [pim] draft-ietf-pim-igmp-mld-extension WGLC Michael McBride
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Stig Venaas
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC zhang.zheng
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Hitoshi Asaeda
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Leonard Giuliano
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Jeffrey (Zhaohui) Zhang
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Hitoshi Asaeda
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Xiejingrong (Jingrong)
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Duncan, Ian
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Gyan Mishra
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Stig Venaas
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Holland, Jake
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Stig Venaas
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Stig Venaas
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Holland, Jake
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Stig Venaas
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Holland, Jake
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Stig Venaas
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Holland, Jake
- Re: [pim] draft-ietf-pim-igmp-mld-extension WGLC Michael McBride