Re: [pim] Last Call: <draft-ietf-pim-msdp-yang-08.txt> (A YANG DataModel for Multicast Source Discovery Protocol (MSDP)) to Proposed Standard

<zhang.zheng@zte.com.cn> Fri, 24 January 2020 01:27 UTC

Return-Path: <zhang.zheng@zte.com.cn>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1BCB1120019; Thu, 23 Jan 2020 17:27:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.198
X-Spam-Level:
X-Spam-Status: No, score=-4.198 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B9bwOzeb1ZT6; Thu, 23 Jan 2020 17:27:45 -0800 (PST)
Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.217.80.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7096612001A; Thu, 23 Jan 2020 17:27:45 -0800 (PST)
Received: from mxct.zte.com.cn (unknown [192.168.164.217]) by Forcepoint Email with ESMTPS id EA1B2801C7C097E6BD74; Fri, 24 Jan 2020 09:27:42 +0800 (CST)
Received: from mse-fl2.zte.com.cn (unknown [10.30.14.239]) by Forcepoint Email with ESMTPS id A2983B27B595FB90579D; Fri, 24 Jan 2020 09:27:42 +0800 (CST)
Received: from njxapp05.zte.com.cn ([10.41.132.204]) by mse-fl2.zte.com.cn with SMTP id 00O1RR9D022825; Fri, 24 Jan 2020 09:27:27 +0800 (GMT-8) (envelope-from zhang.zheng@zte.com.cn)
Received: from mapi (njxapp04[null]) by mapi (Zmail) with MAPI id mid203; Fri, 24 Jan 2020 09:27:27 +0800 (CST)
Date: Fri, 24 Jan 2020 09:27:27 +0800 (CST)
X-Zmail-TransId: 2afc5e2a47ffc8de69c7
X-Mailer: Zmail v1.0
Message-ID: <202001240927274896282@zte.com.cn>
In-Reply-To: <DB7PR07MB5466A46CA66CBBAB96872F16CE0C0@DB7PR07MB5466.eurprd07.prod.outlook.com>
References: 157912016355.29394.13259478860940160505.idtracker@ietfa.amsl.com, DB7PR07MB5466A46CA66CBBAB96872F16CE0C0@DB7PR07MB5466.eurprd07.prod.outlook.com
Mime-Version: 1.0
From: <zhang.zheng@zte.com.cn>
To: <ietfid@btconnect.com>
Cc: <ietf-announce@ietf.org>, <last-call@ietf.org>, <pim-chairs@ietf.org>, <pim@ietf.org>, <draft-ietf-pim-msdp-yang@ietf.org>
Content-Type: multipart/mixed; boundary="=====_001_next====="
X-MAIL: mse-fl2.zte.com.cn 00O1RR9D022825
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/pfqDktjVEof3tnjytrxfSTA39g0>
Subject: Re: [pim] =?utf-8?q?Last_Call=3A_=3Cdraft-ietf-pim-msdp-yang-08=2Etx?= =?utf-8?q?t=3E_=28A_YANG_DataModel_for_Multicast_Source_Discovery_Protoco?= =?utf-8?q?l_=28MSDP=29=29_to_Proposed_Standard?=
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jan 2020 01:27:49 -0000

Hi Tom,






Thank you very much for your review!


Please review the newest 12 version.


Thank you very much! :-)






Best regards,


Sandy














原始邮件



发件人:tompetch <ietfid@btconnect.com>
收件人:IETF-Announce <ietf-announce@ietf.org>;last-call@ietf.org <last-call@ietf.org>rg>;
抄送人:pim-chairs@ietf.org <pim-chairs@ietf.org>;pim@ietf.org <pim@ietf.org>;draft-ietf-pim-msdp-yang@ietf.org <draft-ietf-pim-msdp-yang@ietf.org>rg>;
日 期 :2020年01月23日 00:21
主 题 :Re: [pim] Last Call: <draft-ietf-pim-msdp-yang-08.txt> (A YANG DataModel for Multicast Source Discovery Protocol (MSDP)) to Proposed Standard




RFC8349 says that a new identity MUST be defined for a new control plane protocol - I see no such definition here

RFC8349 says that augments should be to control-plane-protocols/control-plane-protocol as is seen in the OSPF and the other LSR YANG modules; here I see an augment to control-plane-protocols which seems wrong to me

many features but no idea where to look them up - I think every YANG feature needs a YANG reference to an I-D/RFC

I find a list of features and references in the body of an I-D valuable

YANG modules must be plain text; [3618] in the module description does not look like plain text. Other references e.g. RFC8177 look ok although some have a space in them and some do not

leaf tcp-connection-source says that ipv4 must be enabled but the when statement does not test for enabled, just for configured

rpc clear peer clears everything if there is no address - this is fail danger, a specific value for clear all would IMHO be better engineering

XXXX is likely to mean this I-D/RFC but I always like to see a specific direction to the RFC Editor to that effect, just the once, somewhere near the front.

In the same vein, a direction to replace the dates with date of publication  would not go amiss

Tom Petch
________________________________________
From: IETF-Announce <ietf-announce-bounces@ietf.org> on behalf of The IESG <iesg-secretary@ietf.org>
Sent: 15 January 2020 20:29
To: IETF-Announce
Cc: draft-ietf-pim-msdp-yang@ietf.org; pim-chairs@ietf.org; pim@ietf.org
Subject: Last Call: <draft-ietf-pim-msdp-yang-08.txt> (A YANG Data Model for Multicast Source Discovery Protocol (MSDP)) to Proposed Standard


The IESG has received a request from the Protocols for IP Multicast WG (pim)
to consider the following document: - 'A YANG Data Model for Multicast Source
Discovery Protocol (MSDP)'
  <draft-ietf-pim-msdp-yang-08.txt> as Proposed Standard

The IESG plans to make a decision in the next few weeks, and solicits final
comments on this action. Please send substantive comments to the
last-call@ietf.org mailing lists by 2020-01-30. Exceptionally, comments may
be sent to iesg@ietf.org instead. In either case, please retain the beginning
of the Subject line to allow automated sorting.

Abstract


   This document defines a YANG data model for the configuration and
   management of Multicast Source Discovery Protocol (MSDP) Protocol.




The file can be obtained via
https://datatracker.ietf.org/doc/draft-ietf-pim-msdp-yang/

IESG discussion can be tracked via
https://datatracker.ietf.org/doc/draft-ietf-pim-msdp-yang/ballot/


No IPR declarations have been submitted directly on this I-D.




_______________________________________________
IETF-Announce mailing list
IETF-Announce@ietf.org
https://www.ietf.org/mailman/listinfo/ietf-announce

_______________________________________________
pim mailing list
pim@ietf.org
https://www.ietf.org/mailman/listinfo/pim