IETF Logo Mail Archive

[pim] Hi Reshad, the issues about igmp snooping model are addressed. Thanks a lot! Re: [yang-doctors] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-03

Hongji Zhao <hongji.zhao@ericsson.com> Tue, 07 August 2018 03:35 UTC

Return-Path: <hongji.zhao@ericsson.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 12F66130E06 for <pim@ietfa.amsl.com>; Mon, 6 Aug 2018 20:35:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.309
X-Spam-Level:
X-Spam-Status: No, score=-4.309 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=bMpL0yql; dkim=pass (1024-bit key) header.d=ericsson.com header.b=k8phAhsk
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hGFqxHzc0kpG for <pim@ietfa.amsl.com>; Mon, 6 Aug 2018 20:35:08 -0700 (PDT)
Received: from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 342B212F1AB for <pim@ietf.org>; Mon, 6 Aug 2018 20:35:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1533612905; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=frttpF8dkmXJqd1adfmuQrChHRBB/lSJSvtU75cc+XU=; b=bMpL0yqlgjmVcX7CFlGl8RXAUQqIikfjZL2S1zkiOA05n88/95o5RcT4dnJHpZBr xuGKEZv57GoALnpKApABJymqUs2BbJfNSh4fDxFutBvNBgLThmzWWu2jxDcNRokO zRmN0zWHZNaaCgFANkX86BXtfYFBPyAUiCWkzVMsvG4=;
X-AuditID: c1b4fb3a-864269c00000145f-da-5b691369c84b
Received: from ESESSMB502.ericsson.se (Unknown_Domain [153.88.183.120]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id FE.9B.05215.963196B5; Tue, 7 Aug 2018 05:35:05 +0200 (CEST)
Received: from ESESBMB505.ericsson.se (153.88.183.172) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Tue, 7 Aug 2018 05:34:55 +0200
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Tue, 7 Aug 2018 05:34:55 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=frttpF8dkmXJqd1adfmuQrChHRBB/lSJSvtU75cc+XU=; b=k8phAhskL1hgH/miMmgoOBqZdsREd5Af5NnjHTb3mnvuTDg5yQ94qhN2+8ZgzDfkwO1Djz5DHkl8nOE7mYq0tFhyA/ZnwZU0m/3jilcEokhM306mJINjcoXbWjqqCUyfvfYUqTSWzzpysBEsWZzx9ErB4gVQVRtWolLgH9fHNFw=
Received: from VI1PR07MB4192.eurprd07.prod.outlook.com (20.176.6.29) by VI1PR07MB4784.eurprd07.prod.outlook.com (20.177.57.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.13; Tue, 7 Aug 2018 03:34:55 +0000
Received: from VI1PR07MB4192.eurprd07.prod.outlook.com ([fe80::91f1:1722:b6a4:105]) by VI1PR07MB4192.eurprd07.prod.outlook.com ([fe80::91f1:1722:b6a4:105%2]) with mapi id 15.20.1038.019; Tue, 7 Aug 2018 03:34:55 +0000
From: Hongji Zhao <hongji.zhao@ericsson.com>
To: Reshad Rahman <rrahman@cisco.com>
CC: "draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org" <draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org>, "pim@ietf.org" <pim@ietf.org>
Thread-Topic: Hi Reshad, the issues about igmp snooping model are addressed. Thanks a lot! Re: [yang-doctors] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-03
Thread-Index: AdQt/4cDjJnliXlxSjmMbcshMv9t1w==
Date: Tue, 07 Aug 2018 03:34:55 +0000
Message-ID: <VI1PR07MB41921D54D3B708744DFFE21796270@VI1PR07MB4192.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=hongji.zhao@ericsson.com;
x-originating-ip: [106.38.5.8]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR07MB4784; 6:ZCa9YfKZLiuh90HKZCQwiAWFWGY7laG7pu29lan1c0ulrwc6dE+5cZPKkwgVBKrwpdqe8XlB0pSFdIj+b+kjVUhVr03zUxxsEeNzcQsmJdj3u7z55UKjVYH36L0j46G3FXN04fRCfcuDqFr31mA2E3KYg5jzpH367Q0q7Ltl5kBEiMgQLCFNni/PMLzIkQpi8mqo/FODt1iEvMNbLv96WTGlC5g553PsKfnHRPmRXxVKCu/JerV8xczRHjC9B1mZ+n8sUmPoA1eyqQ536IJgkjAvridQOLnaWkidTfZ3kZq6XsEO1lLqOcYFVGFo5CF5rMaFhYAeFCyuz/V71jCH7AmmVmMllWfCekcudk5Ihe7QvdwPT7nDeBVKfCOjiDWrRbT89LCQ4dKBIh/nQCwhbHgSEdpgFT4+KknpjykA7CCqO/2n7yMGP4/29qrbcKbW2dynCdHKbhOWjKiQ3cNFWg==; 5:FbphslDJa+/EMIpBgIaJYv05sdcQitQmoXUkzCmLeCArqZhZxM+dOTTjl8PSRzCXzeaZ1Ss00xDUvglsiCvmLdf+TK0278XwqE/RpFQhS4VpmP4Sm/wZsCnWCisc7dByHXf9Y42Hg9bDKgXvCD9ogQ9V2IlC1M2W5VAbFVbmLzk=; 7:dBzX0gjxgOyOkB92K3tOW6zEhcSFqdOPjcVvsbr5yqn5LOQoLtRtEgrZ+Ix1QHLcetQVxE745RhQlEBZ8ye17lSiEbgm0oJBCUp3+xwBQqmXfea8g/Tt3nnXU6Yvw5N8UQ2jnbrgNNh+dPZp25MggT1Y1GZZIk4HzaDs1+VDPwSisRFMJho5pBYLe8R75mxni6VEG4D9goBA/wqPkKatsgOvLXow0ZaNDh0yky7Iu0SIDXZpV3u8wTyIgQ2gx220
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 0a3df2c4-1363-405d-d3bf-08d5fc16be26
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:VI1PR07MB4784;
x-ms-traffictypediagnostic: VI1PR07MB4784:
x-microsoft-antispam-prvs: <VI1PR07MB4784DCE6F446A73C374153FC96270@VI1PR07MB4784.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(28532068793085)(120809045254105)(21748063052155);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:VI1PR07MB4784; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB4784;
x-forefront-prvs: 0757EEBDCA
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(396003)(366004)(199004)(189003)(69234005)(6916009)(478600001)(44832011)(5660300001)(486006)(19609705001)(966005)(66066001)(25786009)(606006)(14454004)(224903001)(68736007)(222413001)(7736002)(316002)(476003)(790700001)(6116002)(3846002)(256004)(7696005)(2900100001)(9326002)(86362001)(5250100002)(4326008)(8676002)(74316002)(6506007)(26005)(8936002)(55016002)(81156014)(54896002)(6306002)(54906003)(99286004)(81166006)(102836004)(33656002)(97736004)(6436002)(106356001)(105586002)(236005)(9686003)(186003)(2906002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR07MB4784; H:VI1PR07MB4192.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: i2z1cmsY1pd6MoS+Vg+SWZdUx1xo6N7J7zidTJozd9dkho8AMu4cdK7SRJAc9vjCrGlQc358buZ38LnZMKFo9/z+jyaM2gwaBgTu+1LEqYqZOR2Mmg+U9wJaoRIuhiww5ipTRHr8DqJzT3SzLag7cVDwYSNxTJrOM9A6Hn6OqoGkeRgb0q7X1ExmlOGNfiLgUvgPV4ZbY70VLHCEeK0Ch2R/uuIxxU0bGzMYN+mwGcymTseNl/Wlpqj9cMWvl8jJQD2QPxnL30ej6eTG+eKnwNVuG1VM5O8y0DUjOCWwQvZY5sk9awG8FTCARyTE377lN62W9s1Iz2YtQBvhagMs7fE+TR7kvA+WVxqpDCSRNzI=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_VI1PR07MB41921D54D3B708744DFFE21796270VI1PR07MB4192eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a3df2c4-1363-405d-d3bf-08d5fc16be26
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2018 03:34:55.0877 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB4784
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRjuO+e4HUeLz6n5oia4FLzkLAkaUWEXUggrgkRclMud5vLKzhS1 P5oo6DQmubyWkvthZsvU4QUnORPtooaUoURiClkomailK2k7Z4L/nvd5nvfywEuTknY3X1qT oWO0Gco0qUBE1SZ050ZoPDWKw5+N/vJ+/axAvjY3TcqnWoqF0WRslf2FW6zJtElcJhJFJ1RM miaH0UaeShKlLIzNoCzT+dy7o2ZBAWo5V4bcacBHwbLaS5UhES3BwwjaVyqRU5DgdQSdW4G8 0EyAYcZCOAsKG0iY/Dcl4BUDAQv6j4gvZhEsdj0hnP0CfAhK9RbSib1wMLzb/sEtIbEBQWlH DTfLE3cheDXezRVeuBfBr4lKId8iA2t1G4cpHAQPxl9yY8X4GnyxN3AnIrwffr9p43gS+8DM QiPBZ8Jg6p8geewN3+e33Xi/AszDhUKeD4BF832X5wBMNuq5DIAHhLAxPuoaFAErRqPLFAdL rUYBbxpB8LZpGfFCGHTO2Ckep0JPU7sD0w6sgGetl3aWtVbMUa4FJFQ1Tbuu8IfymlHKgGR1 u0LUOdpJnAkVT+PquMwe8Lp2geLpUHjeF8m7A6FKPyfkcQgUNzwU7uabkLAVebMMy6aro6Jk jFaTzLKZGbIMRteBHH802GU/3oMGv522IUwj6V6xjtIoJG7KHDYv3YaAJqVeYrEmRSERq5R5 +Yw284Y2O41hbciPpqQ+4jO35IkSrFbqmFSGyWK0OypBu/sWoAqV2hppvD5wJ9y0lGCfI9gh m6QmoHzNtnHvWMuaaiTWPna7fH74Svxfqd++kA9j74ONP5nmgLatgiBrZnxMSH91yYrHycJK 9o/lkzp8s+FxtvlrTOgF+aPo9QlbUv6eeZ/68CGpquSiZ7216GrE2b6D6/KbRfGr5t7lMm8m OVRKsSnKI2GkllX+B0YFLo1DAwAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/qiTkt6F9sWPTnRbIHbNFPMaomUg>
Subject: [pim] Hi Reshad, the issues about igmp snooping model are addressed. Thanks a lot! Re: [yang-doctors] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-03
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Aug 2018 03:35:10 -0000

Hi Reshad,

I have updated the draft-ietf-pim-igmp-mld-snooping-yang according to your comments and upload the latest version.

In the new version I augmented the l2vpn-instance (from draft-ietf-bess-l2vpn-yang) and ieee802-dot1q-bridge module instead of the old reference style. I also addressed your other comments.

Could you please review it again? Thanks a lot!



https://datatracker.ietf.org/doc/draft-ietf-pim-igmp-mld-snooping-yang/


BR/Hongji

赵宏吉



FYI, easier to read https://datatracker.ietf.org/doc/review-ietf-pim-igmp-mld-snooping-yang-03-yangdoctors-early-rahman-2018-06-28/ than the email below.



On 2018-06-28, 5:42 PM, "yang-doctors on behalf of Reshad Rahman" <yang-doctors-bounces@ietf.org on behalf of rrahman=40cisco.com@dmarc.ietf.org<mailto:yang-doctors-bounces@ietf.org%20on%20behalf%20of%20rrahman=40cisco.com@dmarc.ietf.org>> wrote:



    Reviewer: Reshad Rahman

    Review result: On the Right Track



    YANG Doctor review of draft-ietf-pim-igmp-mld-snooping-yang-03 (by Reshad

    Rahman)

1)      The YANG model has a new container+list for bridges and

    “l2vpn-instances”.  Why not augment l2vpn-instance (from

    draft-ietf-bess-l2vpn-yang)? …



    I will have to re-review once the issues are addressed.

v2.23.0 | Report a Bug | By Email