IETF Logo Mail Archive

Re: [pim] AD Review of draft-ietf-pim-igmp-mld-snooping-yang-09

Hongji Zhao <hongji.zhao@ericsson.com> Sat, 02 May 2020 12:39 UTC

Return-Path: <hongji.zhao@ericsson.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 74A013A1115; Sat, 2 May 2020 05:39:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.919
X-Spam-Level:
X-Spam-Status: No, score=-2.919 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.82, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D0_IcCLFcFlt; Sat, 2 May 2020 05:39:50 -0700 (PDT)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80082.outbound.protection.outlook.com [40.107.8.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3CFE13A1113; Sat, 2 May 2020 05:39:49 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gSZzVNcsETEcUfD2FZdsvtUHPD9LXEB4Ev5hj/vJTR/BkegTVBjhlfRjDoAYZ4G6yP60+x2hwOyQWDb2zPnge6dX5lJ9TtfLPFbvbP6n5mgqJVlRcwzREnkcNFsbEwE0gyeJeEMatU9g6AE1dphwteu0otqSE20Iq73LsM+Yvw+jihSk+TfNcNonV3qFQUfzBPAx5orX2Zg6ZwbuHG/n6ulCIrOMW7oM/KeBUCm2KKgtCXeBs7fAZcFTNzfHY0yXTSLzzKmAjDDUEtDU69CjRwYfBQNuKK2FhvJYKEufjddXXvZmVtuzGUrXhJ89CbTMv7E5D2NgiKsD+7fFkX+M5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OYMrBHdX85Urv0tUfzD47arf67W1khqWuVSlUgF1f/k=; b=bYlkKDpWLNtg+UdwTcl1kQW/DXNtIa1vPekiGBFVYGPBD91F0ndwj40HpzameWSSZqAmDzBsAPjoadxti9xU36MF2nz5gNe79N9jQPcC77D94vHd6UHyGaqkrF7AtG6i15f+ZbZDDU13hIkqHM1kHm7a2c36VNGe05QjVssr2fKCYHvOVdpPp9LcXP4/0eT+VczNZAyOdmSc3DvbqKvf8mOplpqVNVGDcWqNwCFrDHIA3SmhRDdLRcvFUJGMKHXdJE8qYx5o7XKPPAsfsC6q4mm+gWWPIRDLRcf9xToY66E1taqJl/dLyC1ToimyWDqVx63xGAXukhMDIFSpxOJgcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OYMrBHdX85Urv0tUfzD47arf67W1khqWuVSlUgF1f/k=; b=BJiNhbW1gcAkesPRWq3+mOYBh6ZA4FCwIa1KtN3XlFDw4i6jb57XS5SjpfKQ1fdGCuadn4BO5yDXCQFClmOQjKFgjRYj/1dcOD+RZyO3+2bZaeiianMPbPxJjf7ncqDbd6oWATJ/GXvIR3r07UTZh1bXC7OST9riVHdDh3cMi9U=
Received: from HE1PR07MB3148.eurprd07.prod.outlook.com (2603:10a6:7:2d::15) by HE1PR07MB4412.eurprd07.prod.outlook.com (2603:10a6:7:96::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.14; Sat, 2 May 2020 12:39:47 +0000
Received: from HE1PR07MB3148.eurprd07.prod.outlook.com ([fe80::6582:9acd:2e52:a8b5]) by HE1PR07MB3148.eurprd07.prod.outlook.com ([fe80::6582:9acd:2e52:a8b5%5]) with mapi id 15.20.2958.020; Sat, 2 May 2020 12:39:47 +0000
From: Hongji Zhao <hongji.zhao@ericsson.com>
To: Alvaro Retana <aretana.ietf@gmail.com>
CC: "pim@ietf.org" <pim@ietf.org>, Stig Venaas <stig@venaas.com>, "pim-chairs@ietf.org" <pim-chairs@ietf.org>
Thread-Topic: AD Review of draft-ietf-pim-igmp-mld-snooping-yang-09
Thread-Index: AQHVzYeKaXJzNYyt5k+R4mTeZys2XKfxTt9wgJkOjoCAAONp8IAAq3eAgAlyaJA=
Date: Sat, 02 May 2020 12:39:46 +0000
Message-ID: <HE1PR07MB31484BB0781DC5EB19D822DA96A80@HE1PR07MB3148.eurprd07.prod.outlook.com>
References: <CAMMESsz-MvVF-2o2_Gso6yKocUKhRFrJTp0jsUwFpcznfj5qXw@mail.gmail.com> <HE1PR07MB3148BBF5316C9EC1FAC7742A96330@HE1PR07MB3148.eurprd07.prod.outlook.com> <CAMMESsztgWZr397ca6zVCc=9=Fq5B7ib64YmePXN7KNefA5zng@mail.gmail.com> <HE1PR07MB3148318D959984C817EC11E796AE0@HE1PR07MB3148.eurprd07.prod.outlook.com> <CAMMESszGOfmsWNuBWncAms4t5jMeVXvP_nQ1c4a-qxZNYUmQaA@mail.gmail.com>
In-Reply-To: <CAMMESszGOfmsWNuBWncAms4t5jMeVXvP_nQ1c4a-qxZNYUmQaA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [120.244.62.165]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: da4a0c22-6b43-44f3-6a1c-08d7ee95e5eb
x-ms-traffictypediagnostic: HE1PR07MB4412:
x-microsoft-antispam-prvs: <HE1PR07MB44123EA3F01CF120A6E1D14B96A80@HE1PR07MB4412.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 039178EF4A
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: MSQVzqYFJknEOv1picuwa79qZXHT/6o/HY/uIuaztaee3Booa1z3YTkIdTa5EzPuHKGYkKBpLpd5gEd/ILK9R+gHHNzHPww5mia0866lcpxXZ9bcRnVvfBAhWLcFjKQEg0xbJCey2zagzwp1bsADlytIJcOBTlQ3/r5Xn4u63vsTuAb0bRTqXtyNqeyPeTDUrRoSsKQajDhnk1XJSBtLgy7tgLZHT9vZbiNvNQeGS01tiq/pnQGKVfDO+z3QJbTpVUrumCjiWnm7J+U4zMy/5R3jsuWYOdUJgfr9Jdop/uJAcOUfo9bu8kRnKVQ1Mj5/wqx2HOoSx/+gqg7RYjxboTic1vpt0okTWYQCVJSJiSP4HP5IZojwi2hwgsffnInG6BjYVU703pABFWafw5VPZX7l/Nf8vCfHzyIf3I8cthlELIk4Yl9AxG41vrM7gPck
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR07MB3148.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(376002)(346002)(136003)(396003)(39860400002)(86362001)(2906002)(76116006)(478600001)(5660300002)(9686003)(8936002)(52536014)(8676002)(54906003)(71200400001)(55016002)(316002)(7696005)(9326002)(44832011)(26005)(33656002)(6916009)(64756008)(66446008)(66556008)(66476007)(66946007)(186003)(53546011)(4326008)(6506007); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: Fxj0QalKl3hkzoMt+YqdfQ8k8iCpijdujnXwmFCYdaREb3xD78kz+o7iR4FgeUmiaWQo92BTJvOvZxzRYmlDR7Vz2+lD7T1+FTKoel4Wj5i2VOdKP/xdV6d9lDZNCVttMHPPsPmUCJ1ju6fi02apxbgFr9Kgrdq9DZ5eVc0cz8d0MvbLK5O4HF+lGYAc8wfijg8vakHYemWsbjWM3oEJjoNQtEuUmodgDAQ/wFfy+vQHhAlYr4b0Oo7GthmD+I2dclKlNtKWbBAYvntVbQfgNWnILx791iP+h7QKM3KAdC1hn+60dcVdNkF9ZRHJAhA3hwPp8dLZWtK0s4ON8dOH7QpJx5livUpI9kRQOqlKgzJYHVBAftREy51S/5R6zP3PqXd7dgDQseKSnoet8sybifXIji0WtS0cAx5G4UuC+4b3d0Lt1MohKVc13D2LHn+Qm9ypYdV6a614cw508ldyidSkwx0oSQ6ofFM5tp4OR2hOJD8FQWl4X8UiLo43MfGGqoJFRzvvcQPfFmTJn+IyPojKM0tm8A1zsWy/REfF+fncw/GHFS9z4adilJjvxbAewpTUz3Kw81tIel+aSjhj+unCJlE/dJnbm3W6Jkw/CtuYQEEYDU4Oxq5j8D0xtlBh9YOD8Q4UCoc4xd8Ea1RzQokJiQL0ft7l2SLzyU7Ji5Sv8H8h/PWgLWm6W6xfVJCsFRGnwqsA2juFEZmmjQ4wCARgrtvEeNpVzC6OF1fpOTL8PpIsar1ec1vI8tK5xZXOS9r8Gzp15n5WOZkN7l0s6JckkKaTfNTLNz3GAdtFAG8=
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_HE1PR07MB31484BB0781DC5EB19D822DA96A80HE1PR07MB3148eurp_"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da4a0c22-6b43-44f3-6a1c-08d7ee95e5eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2020 12:39:47.0129 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i96+O48QoILKqgRi1qus7BxCha/VY7EHpIIpA//qJ15GrXU7m/a+VpxNq6Rex4aQO0lbWIvJKUjnoHhXreFmC3AYW8Q4mHADtloXio9NT4I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB4412
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/1H5OXHhkanhJ6A_oYWf9RlkGY48>
Subject: Re: [pim] AD Review of draft-ietf-pim-igmp-mld-snooping-yang-09
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 02 May 2020 12:39:53 -0000

Hi Alvaro,

We have already addressed all your comments and uploaded the latest version as draft-ietf-pim-igmp-mld-snooping-yang-10.
Below are the answers to your questions in your comments. Please check inline.

1)
175           augment /rt:routing/rt:control-plane-protocols/rt:control-plane-protocol:
176             +--rw igmp-snooping-instance {feature-igmp-snooping}?
177             |  +--rw scenario?                            snooping-scenario-type
178             |  +--rw enable?                              boolean
179             |  +--rw forwarding-mode?                     enumeration
180             |  +--rw explicit-tracking?                   boolean
{explicit-tracking}?
181             |  +--rw exclude-lite?                        boolean {exclude-lite}?
182             |  +--rw send-query?                          boolean
183             |  +--rw immediate-leave?                     empty {immediate-leave}?
184             |  +--rw last-member-query-interval?          uint16
185             |  +--rw query-interval?                      uint16
186             |  +--rw query-max-response-time?             uint16

[minor] Why are timer-value-* (rfc8294) not used?  Please consider using them for the variables above and others...
   [Authors] Regarding last-member-query-interval or query-interval, it should not be set infinity or not-set. So timer-value-* is not fit for it.

2)
    leaf igmp-version {
      type uint8 {
        range "1..3";
      }
      default 2;
      description "IGMP version.";
    }
[major] If the previous guess is correct...  What does this version mean?  Given that the default is 2, does it mean that only IGMPv2 packets should be snooped?  I would assume that deployments already supporting IGMPv3 are common...
  [Authors] The version here refers to the igmp version.  By default is 2, it means only IGMPv2 packets could be snooped. In rfc8652, igmp default version is also 2.   If IGMPv3 packets need to be snooped, it should be set 3. So does the MLD.

BR/Hongji

From: Alvaro Retana <aretana.ietf@gmail.com>
Sent: Sunday, April 26, 2020 8:11 PM
To: Hongji Zhao <hongji.zhao@ericsson.com>
Cc: pim@ietf.org; Stig Venaas <stig@venaas.com>; pim-chairs@ietf.org
Subject: RE: AD Review of draft-ietf-pim-igmp-mld-snooping-yang-09

Hi!

Yes, as long as there is a plan and progress is being made. :-)

Thanks!

Alvaro.


On April 25, 2020 at 10:06:03 PM, Hongji Zhao (hongji.zhao@ericsson.com<mailto:hongji.zhao@ericsson.com>) wrote:
We will finish addressing the comments by the end of May. Is it ok?

v2.23.0 | Report a Bug | By Email