Re: [pim] Murray Kucherawy's No Objection on draft-ietf-pim-igmp-mld-snooping-yang-16: (with COMMENT)

Hongji Zhao <hongji.zhao@ericsson.com> Wed, 08 July 2020 11:57 UTC

Return-Path: <hongji.zhao@ericsson.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E22783A08CA; Wed, 8 Jul 2020 04:57:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.102
X-Spam-Level:
X-Spam-Status: No, score=-2.102 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XHwJQVtuHIzl; Wed, 8 Jul 2020 04:57:53 -0700 (PDT)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40050.outbound.protection.outlook.com [40.107.4.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F12E23A08C7; Wed, 8 Jul 2020 04:57:52 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oI+YJnT/sedYkRqfn1gefjKMgaMj4KEQx4CXPFYTGHF59JBC4L/+mf5BPgkwE03VZdppghLoSKcBGygE0CeZXP/qXCsXmOx/4/kTY1cWiSIGDvK5jRbgURRt9/PTugkomlnobGSZx476cWdKLatrmdc35s+Ym+8gCi4b4HQaRSHfUYy+yvLo4ODWUluWcPtUKQT3UiNXJw0Dwk9wfDOoc54GuW2y8orzGbIto4UqSor2gCHH//qbaQzwhP+2nLgQIAqZbP4+yvq4x/uhzaXDTFvQ9Gm5JxnFURMokwI9eCvRCyxO64y6pzaHVqIlQ/vXbOVFN0YtcuiZhq5tvXD9cQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oc2PZAsjpMWE1zTiTRAHvrCXTOMPwNz/yxbJpJmhYsA=; b=TOGxh2Qg0vfkcq47iR+TUow/iWaLURd2BWPyRojElTlqGBEgykZybbgtv6aMBiMkdr0tky+wxdA2YPya2EzIakxcEK86GT9JvU5KcpxrPSSacTdNZzcy4TO7drqWK+P9K/jliNR5RyXruWlsGUcslkWATVfKW3NlKNQnWVjUR1+2L8Bc52MWGHuLP01cqK9jnC5gWPDm5ZnxUJhcTYCiFjOdEsuusX7jAwIRfCKGeTSY+Y6GqSk5Sxr4xGo+QlIq9GrgPw5s/ymGam+teI5gOsc3jBXrnAuFJ7n9fdS4w9iSpd8qCjw7/h57xK2oKxfFl8cjjtLPUpAjgXDFUGEh8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oc2PZAsjpMWE1zTiTRAHvrCXTOMPwNz/yxbJpJmhYsA=; b=KStuDOcOjmn0A61s1vGchrj/irBH8PrXcFIiGnwpte1fgYL4Z/hLFcHVBVx5EqF0141toEv/fJBpHrCsjs/yQ7gnfxmu79RrKiTabA2OqqBtrDCofrejLJMAvnIx68lUoFg3c+bnFMVbYCr6LPqRRYyR8GpgSG/Q3nokr1/7/ag=
Received: from HE1PR0701MB2492.eurprd07.prod.outlook.com (2603:10a6:3:71::22) by HE1PR0701MB3034.eurprd07.prod.outlook.com (2603:10a6:3:4c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.13; Wed, 8 Jul 2020 11:57:50 +0000
Received: from HE1PR0701MB2492.eurprd07.prod.outlook.com ([fe80::ec82:bf39:2810:fbb0]) by HE1PR0701MB2492.eurprd07.prod.outlook.com ([fe80::ec82:bf39:2810:fbb0%7]) with mapi id 15.20.3174.020; Wed, 8 Jul 2020 11:57:50 +0000
From: Hongji Zhao <hongji.zhao@ericsson.com>
To: Murray Kucherawy <superuser@gmail.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-pim-igmp-mld-snooping-yang@ietf.org" <draft-ietf-pim-igmp-mld-snooping-yang@ietf.org>, "pim-chairs@ietf.org" <pim-chairs@ietf.org>, "pim@ietf.org" <pim@ietf.org>, Stig Venaas <stig@venaas.com>, "aretana.ietf@gmail.com" <aretana.ietf@gmail.com>
Thread-Topic: Murray Kucherawy's No Objection on draft-ietf-pim-igmp-mld-snooping-yang-16: (with COMMENT)
Thread-Index: AQHWVP+Hg6IxClcytUyHrJEuOpnwYaj9kt3g
Date: Wed, 8 Jul 2020 11:57:50 +0000
Message-ID: <HE1PR0701MB249231247FBECF820813389196670@HE1PR0701MB2492.eurprd07.prod.outlook.com>
References: <159419594277.5069.9537319405115430156@ietfa.amsl.com>
In-Reply-To: <159419594277.5069.9537319405115430156@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [120.244.62.236]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 55ccca04-fe85-42fb-d6dc-08d82336238d
x-ms-traffictypediagnostic: HE1PR0701MB3034:
x-microsoft-antispam-prvs: <HE1PR0701MB30349BA7BCC5FF823415A98296670@HE1PR0701MB3034.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 5OCr/bW6Ay7UHVDVxDtEsZpi1G9ZZ/SO7OV1XGJCML+tKthHV9mu2JjBGolAdvePPfIJfQulOJbEsuxzWPtdFdzMHdpszt/J/VkZlP4axhHAbZ55MUjQc8Gnb/JS+Uephe0n0Yb/gODc5YI7I/aIU+ht14175yBV9/zq1WzOD8d41Lv7u9weqtmvk16NGXrE9MYlRSOsbXZA5ixjgyZ/uMv1WRfykCw/BEZW6ROkS7JP7KSKzvkIESGkcTKGYbekx2TSBLkdIOeFPC4935NzlC8BQawmE3+J3bksyFXw2F1cJa3Mx54EzEIZl1hSo1RksJ05Kioa9o+RakVPu/oCv3Xv1rYk6o4omshIvuVKm4s=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0701MB2492.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(346002)(39860400002)(376002)(396003)(5660300002)(4326008)(316002)(71200400001)(54906003)(86362001)(8676002)(110136005)(44832011)(52536014)(83380400001)(8936002)(478600001)(2906002)(966005)(53546011)(6506007)(26005)(9686003)(33656002)(66946007)(76116006)(66556008)(66446008)(64756008)(186003)(66476007)(55016002)(7696005); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: RKDNoMuXSeVsuBA/5tPys3YD6j+u7ihasUfgRQM//g4D0fssymfxj170pD6+n92U1ibNn8MpbSqOX3CQCuzAmMrAaWtNCQFKGIcYCD3mS9nyuJaJADfPhAqJB83DsE2J18rcgGjZ9AVzfoOuoTZ+zH+JbASub27nqcycxGYIToN1bz5qXBQ/ghynoE5lnMMSHasyKXSL0j1n6O2E9Q/EH4ePAgnNJTxG3fhLunuNjW080K/j/hA4IyFruyxU+nS4dFRtbiwmUNDp7apjL0zL+Rvc9+XnoM1BCzziIt/Qef5Pixg/Q5dHG0/AVgbQtM1UEQ3erZ2ChNxA6bIFCJvAZCJjFIRQNH9sO7v4Pok2ha8F/nGrE8st8SA9MfyCjHVyJTCxgcLzZZ5ggX5K4v83oEV5TdUsro05tjs+dgbVOuFMtqHzS3h8gD0mDxpuHWlZy1tr7V1JtF42eJcjUsC4xLd72uVWph1vAinatrIZPE+DaZXaJ36I6/t2G0fwCiPE
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0701MB2492.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55ccca04-fe85-42fb-d6dc-08d82336238d
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2020 11:57:50.2970 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jduPhEkD7YooN7bqN0fuk2ODdZaK9kTM8R6ZWOLF/D+THAcGhSkfVq0Gv8YDLtZ+FWdO+4biuxsWMVuegt4IABZs+h64sieoUnlyMTnu+Uo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB3034
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/BJXm1YLG52yuxYjCW6czb-OVnE0>
Subject: Re: [pim] Murray Kucherawy's No Objection on draft-ietf-pim-igmp-mld-snooping-yang-16: (with COMMENT)
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2020 11:57:55 -0000

Hi Murray,

The issues founded in early YANG doctor review have been addressed. YANG doctor also confirmed it in the second round review on version 12 almost a month ago.
Regarding other comments,  we will post a new version ASAP to address them.

Thanks a lot!

BR/Hongji

-----Original Message-----
From: Murray Kucherawy via Datatracker <noreply@ietf.org> 
Sent: Wednesday, July 8, 2020 4:12 PM
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-pim-igmp-mld-snooping-yang@ietf.org; pim-chairs@ietf.org; pim@ietf.org; Stig Venaas <stig@venaas.com>om>; aretana.ietf@gmail.com
Subject: Murray Kucherawy's No Objection on draft-ietf-pim-igmp-mld-snooping-yang-16: (with COMMENT)

Murray Kucherawy has entered the following ballot position for
draft-ietf-pim-igmp-mld-snooping-yang-16: No Objection

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-pim-igmp-mld-snooping-yang/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

I'm almost hitting the "DISCUSS" button here over the fact that the shepherd writeup warned in several places that the YANG in this document had issues. 
Were these resolved?

> There was an early YANG doctor review that found some issues. I 
> believe the
should be resolved. There are some errors compiling the model though.

> Early YANG doctor review was done. It would be good to get another 
> check to
see if everything is fine now.

> There are some minor nits as found by the tool, and YANG validation 
> has a few
issues.

> The early YANG doctor review only found minor issues, which should be
addressed in version 08.  [We're at -16 now; was this never updated?]

Section 3:

* "The YANG data model defined in this document conforms to the Network Management Datastore Architecture (NMDA) [RFC8342]." -- This text also appears in Section 2.

Section 5:

* I concur with Roman's suggestion to refer here to RFC 4541.

Section 6:

* I suggest this be split into two subsections, which in my experience is more conventional (but not required).

Other:

There's a bug in whatever rendering engine was used here.  The footer for page
1 says the document expires January 2021, but all others say 2020.