Re: [ppsp] I-D Action: draft-ietf-ppsp-base-tracker-protocol-07.txt

"Songhaibin (A)" <haibin.song@huawei.com> Wed, 31 December 2014 08:29 UTC

Return-Path: <haibin.song@huawei.com>
X-Original-To: ppsp@ietfa.amsl.com
Delivered-To: ppsp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3060C1A8AA6 for <ppsp@ietfa.amsl.com>; Wed, 31 Dec 2014 00:29:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.911
X-Spam-Level:
X-Spam-Status: No, score=-1.911 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, MANGLED_LOAN=2.3, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QnTArgsIi2TJ for <ppsp@ietfa.amsl.com>; Wed, 31 Dec 2014 00:29:39 -0800 (PST)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 40AAD1A8AA0 for <ppsp@ietf.org>; Wed, 31 Dec 2014 00:29:39 -0800 (PST)
Received: from 172.18.7.190 (EHLO lhreml406-hub.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BQT05107; Wed, 31 Dec 2014 08:29:37 +0000 (GMT)
Received: from nkgeml409-hub.china.huawei.com (10.98.56.40) by lhreml406-hub.china.huawei.com (10.201.5.243) with Microsoft SMTP Server (TLS) id 14.3.158.1; Wed, 31 Dec 2014 08:29:36 +0000
Received: from NKGEML501-MBS.china.huawei.com ([169.254.2.169]) by nkgeml409-hub.china.huawei.com ([10.98.56.40]) with mapi id 14.03.0158.001; Wed, 31 Dec 2014 16:29:29 +0800
From: "Songhaibin (A)" <haibin.song@huawei.com>
To: "ppsp@ietf.org" <ppsp@ietf.org>
Thread-Topic: [ppsp] I-D Action: draft-ietf-ppsp-base-tracker-protocol-07.txt
Thread-Index: AQHQFb3lcWmGDc1J5kOf388Unpmu05ypdPpA
Date: Wed, 31 Dec 2014 08:29:28 +0000
Message-ID: <E33E01DFD5BEA24B9F3F18671078951F651FA7A2@nkgeml501-mbs.china.huawei.com>
References: <20141212013256.7873.77833.idtracker@ietfa.amsl.com>
In-Reply-To: <20141212013256.7873.77833.idtracker@ietfa.amsl.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.138.41.49]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: http://mailarchive.ietf.org/arch/msg/ppsp/-ipUU-ZS9sWhfVaKMCjNS_hb-rQ
Subject: Re: [ppsp] I-D Action: draft-ietf-ppsp-base-tracker-protocol-07.txt
X-BeenThere: ppsp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: discussing to draw up peer to peer streaming protocol <ppsp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ppsp>, <mailto:ppsp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ppsp/>
List-Post: <mailto:ppsp@ietf.org>
List-Help: <mailto:ppsp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ppsp>, <mailto:ppsp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Dec 2014 08:29:41 -0000

Thanks to the authors for the update. And here are some proposed changes to the json text after a glance at the draft.


1.  "struct" should be changed to object. For example, change:     

 struct { 
              s1  e1; 
              s2  e2;
              ...
              sn  en;
      } type_name;

to

object {
              s1  e1; 
              s2  e2;
              ...
              sn  en;
 } type_name;

2.	Do not use "enum" type, and change to others instead, due to there's no enum type in JSON language.
3.	the version of "ppsp_tp_version_t" should be registered in IANA?

4. You might change:
Object {
              ppsp_tp_stat_type_t  type;
              union {
                     Object {
                             ppsp_tp_string_t  swarm_id;
                             ppsp_tp_integer_t  uploaded_bytes;
                             ppsp_tp_integer_t  downloaded_bytes;
                             ppsp_tp_integer_t  available_bandwidth;
                         } stream_stats;
              } stat_data;
	      } ppsp_tp_stat_t;

to:

         Object {
                  ppsp_tp_string_t  swarm_id;
                  ppsp_tp_integer_t  uploaded_bytes;
                  ppsp_tp_integer_t  downloaded_bytes;
                  ppsp_tp_integer_t  available_bandwidth;
                } stream_stats;

         Object {
                  ppsp_tp_stat_type_t  type;
                  stream_stats str_stats_value;
              } stat_data;


5.	suggest to change media type "application/ppsp+json" to "application/ppsptracker+json"
6.	The examples in Section 6 seems inconsistent with the data structures in Section 4. They should be fixed.

Best Regards!
-Haibin


> -----Original Message-----
> From: ppsp [mailto:ppsp-bounces@ietf.org] On Behalf Of
> internet-drafts@ietf.org
> Sent: Friday, December 12, 2014 9:33 AM
> To: i-d-announce@ietf.org
> Cc: ppsp@ietf.org
> Subject: [ppsp] I-D Action: draft-ietf-ppsp-base-tracker-protocol-07.txt
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
>  This draft is a work item of the Peer to Peer Streaming Protocol Working
> Group of the IETF.
> 
>         Title           : PPSP Tracker Protocol-Base Protocol (PPSP-TP/1.0)
>         Authors         : Rui Santos Cruz
>                           Mario Serafim Nunes
>                           Gu Yingjie
>                           Jinwei Xia
>                           Rachel Huang
>                           Joao P. Taveira
>                           Deng Lingli
> 	Filename        : draft-ietf-ppsp-base-tracker-protocol-07.txt
> 	Pages           : 56
> 	Date            : 2014-12-11
> 
> Abstract:
>    This document specifies the base Peer-to-Peer Streaming Protocol-
>    Tracker Protocol (PPSP-TP/1.0), an application-layer control
>    (signaling) protocol for the exchange of meta information between
>    trackers and peers.  The specification outlines the architecture of
>    the protocol and its functionality, and describes message flows,
>    message processing instructions, message formats, formal syntax and
>    semantics.  The PPSP Tracker Protocol enables cooperating peers to
>    form content streaming overlay networks to support near real-time
>    Structured Media content delivery (audio, video, associated timed
>    text and metadata), such as adaptive multi-rate, layered (scalable)
>    and multi-view (3D) videos, in live, time-shifted and on-demand
>    modes.
> 
> 
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-ppsp-base-tracker-protocol/
> 
> There's also a htmlized version available at:
> http://tools.ietf.org/html/draft-ietf-ppsp-base-tracker-protocol-07
> 
> A diff from the previous version is available at:
> http://www.ietf.org/rfcdiff?url2=draft-ietf-ppsp-base-tracker-protocol-07
> 
> 
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
> 
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
> 
> _______________________________________________
> ppsp mailing list
> ppsp@ietf.org
> https://www.ietf.org/mailman/listinfo/ppsp