[ppsp] Reivew of the base tracker protocol

"yunfei" <hishigh@sina.com> Fri, 24 October 2014 02:14 UTC

Return-Path: <hishigh@sina.com>
X-Original-To: ppsp@ietfa.amsl.com
Delivered-To: ppsp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C3A591A87B2 for <ppsp@ietfa.amsl.com>; Thu, 23 Oct 2014 19:14:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.8
X-Spam-Level:
X-Spam-Status: No, score=0.8 tagged_above=-999 required=5 tests=[BAYES_50=0.8, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7TXd5IInJZgC for <ppsp@ietfa.amsl.com>; Thu, 23 Oct 2014 19:14:18 -0700 (PDT)
Received: from smtp2911-211.mail.sina.com.cn (mail2-190.sinamail.sina.com.cn [60.28.2.190]) by ietfa.amsl.com (Postfix) with SMTP id 0CEB41A87D0 for <ppsp@ietf.org>; Thu, 23 Oct 2014 19:14:17 -0700 (PDT)
Received: from unknown( HELO webmail.sinamail.sina.com.cn)([172.16.201.22]) by sina.com with SMTP 24 Oct 2014 10:14:16 +0800 (CST)
X-Sender: hishigh@sina.com
X-SMAIL-MID: 4008539062017
Received: by webmail.sinamail.sina.com.cn (Postfix, from userid 80) id 84CC9405C0; Fri, 24 Oct 2014 10:14:15 +0800 (CST)
Date: Fri, 24 Oct 2014 10:14:15 +0800
Received: from hishigh@sina.com([114.253.93.160]) by m0.mail.sina.com.cn via HTTP; Fri, 24 Oct 2014 10:14:15 +0800 (CST)
From: yunfei <hishigh@sina.com>
To: draft-ietf-ppsp-base-tracker-pro <draft-ietf-ppsp-base-tracker-protocol@tools.ietf.org>, ppsp <ppsp@ietf.org>
MIME-Version: 1.0
X-Priority: 3
X-MessageID: 5449b5f7204f2c
X-Originating-IP: [60.28.2.135]
X-Mailer: Sina WebMail 4.0
Content-Type: multipart/alternative; boundary="=-sinamail_alt_c9c679a43c3fea03afa6f8284bf5d81d"
Message-Id: <20141024021415.84CC9405C0@webmail.sinamail.sina.com.cn>
Archived-At: http://mailarchive.ietf.org/arch/msg/ppsp/74oaFkrTtxUMeIW-2kdJAkfc7fY
X-Mailman-Approved-At: Thu, 23 Oct 2014 19:16:02 -0700
Subject: [ppsp] Reivew of the base tracker protocol
X-BeenThere: ppsp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: hishigh@sina.com
List-Id: discussing to draw up peer to peer streaming protocol <ppsp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ppsp>, <mailto:ppsp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ppsp/>
List-Post: <mailto:ppsp@ietf.org>
List-Help: <mailto:ppsp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ppsp>, <mailto:ppsp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Oct 2014 02:14:24 -0000

Hi,
   (Speaking individually) I have reviewed the latest three versions of the base tracker protocol and have the following comments. Wish it helpful for today's online discussion.
 
General: I do like the idea in the latest two versions that the new section (section 3 and the corresponding update in section 4) has been added to address to accomodate different encodings in unified data type.
 
Comments:
1) Section 4.1:
typedef struct {  
                     CONCRETE_PROTO_SPEC_DEPENDENT    address;  
                     // string, addr_in4,  
                     // addr_in6, addr_storage  
                     CONCRETE_PROTO_SPEC_DEPENDENT    port;  
                     // string (IANA service port),  
                     // or uint16 (service port) 

Is the definition of the type of address and port missing? I didn't find them before.
 
2) In the end of section 5.1 and 5.2, there is an IMPLEMENTATION NOTE saying: If no PeerNum attributes are present in the request the tracker MAY return a random sample from the peer population. 
It's suggested to set a DEFAULT value for the return number if no explict request of number.
 
 
BR
Yunfei




typedef struct {





CONCRETE_PROTO_SPEC_DEPENDENT address;





// string, addr_in4,





// addr_in6, addr_storage





CONCRETE_PROTO_SPEC_DEPENDENT port;





// string (IANA service port),





// or uint16 (service port)




CONCRETE_PROTO_SPEC_DEPENDENT address;





// string, addr_in4,





// addr_in6, addr_storage





CONCRETE_PROTO_SPEC_DEPENDENT port;





// string (IANA service port),





// or uint16 (service port)




CONCRETE_PROTO_SPEC_DEPENDENT address;





// string, addr_in4,





// addr_in6, addr_storage





CONCRETE_PROTO_SPEC_DEPENDENT port;





// string (IANA service port),





// or uint16 (service port)