Re: [ppsp] Reivew of the base tracker protocol
"Huangyihong (Rachel)" <rachel.huang@huawei.com> Fri, 24 October 2014 03:06 UTC
Return-Path: <rachel.huang@huawei.com>
X-Original-To: ppsp@ietfa.amsl.com
Delivered-To: ppsp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 432781AD063 for <ppsp@ietfa.amsl.com>; Thu, 23 Oct 2014 20:06:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.21
X-Spam-Level:
X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EkXQS_vkcu6z for <ppsp@ietfa.amsl.com>; Thu, 23 Oct 2014 20:06:26 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BE0AC1ACFC5 for <ppsp@ietf.org>; Thu, 23 Oct 2014 20:06:24 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml404-hub.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BKW56920; Fri, 24 Oct 2014 03:06:23 +0000 (GMT)
Received: from nkgeml409-hub.china.huawei.com (10.98.56.40) by lhreml404-hub.china.huawei.com (10.201.5.218) with Microsoft SMTP Server (TLS) id 14.3.158.1; Fri, 24 Oct 2014 04:06:22 +0100
Received: from NKGEML501-MBS.china.huawei.com ([169.254.2.21]) by nkgeml409-hub.china.huawei.com ([10.98.56.40]) with mapi id 14.03.0158.001; Fri, 24 Oct 2014 11:06:19 +0800
From: "Huangyihong (Rachel)" <rachel.huang@huawei.com>
To: "hishigh@sina.com" <hishigh@sina.com>, draft-ietf-ppsp-base-tracker-pro <draft-ietf-ppsp-base-tracker-protocol@tools.ietf.org>, ppsp <ppsp@ietf.org>
Thread-Topic: [ppsp] Reivew of the base tracker protocol
Thread-Index: AQHP7zB8wkizZtXH2UKe//j4ZQGajJw+iiQg
Date: Fri, 24 Oct 2014 03:06:18 +0000
Message-ID: <51E6A56BD6A85142B9D172C87FC3ABBB8624B861@nkgeml501-mbs.china.huawei.com>
References: <20141024021415.84CC9405C0@webmail.sinamail.sina.com.cn>
In-Reply-To: <20141024021415.84CC9405C0@webmail.sinamail.sina.com.cn>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.138.41.144]
Content-Type: multipart/alternative; boundary="_000_51E6A56BD6A85142B9D172C87FC3ABBB8624B861nkgeml501mbschi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: http://mailarchive.ietf.org/arch/msg/ppsp/Fb0FsjyuyD-frgUVy27h1kPuxq4
Subject: Re: [ppsp] Reivew of the base tracker protocol
X-BeenThere: ppsp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: discussing to draw up peer to peer streaming protocol <ppsp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ppsp>, <mailto:ppsp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ppsp/>
List-Post: <mailto:ppsp@ietf.org>
List-Help: <mailto:ppsp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ppsp>, <mailto:ppsp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Oct 2014 03:06:29 -0000
Hi Yunfei, Please see inline. BR, Rachel From: ppsp [mailto:ppsp-bounces@ietf.org] On Behalf Of yunfei Sent: Friday, October 24, 2014 10:14 AM To: draft-ietf-ppsp-base-tracker-pro; ppsp Subject: [ppsp] Reivew of the base tracker protocol Hi, (Speaking individually) I have reviewed the latest three versions of the base tracker protocol and have the following comments. Wish it helpful for today's online discussion. General: I do like the idea in the latest two versions that the new section (section 3 and the corresponding update in section 4) has been added to address to accomodate different encodings in unified data type. Comments: 1) Section 4.1: typedef struct { CONCRETE_PROTO_SPEC_DEPENDENT address; // string, addr_in4, // addr_in6, addr_storage CONCRETE_PROTO_SPEC_DEPENDENT port; // string (IANA service port), // or uint16 (service port) Is the definition of the type of address and port missing? I didn't find them before. [Rachel]: Yes. Comparing to previous xml format, the address type is missing. 2) In the end of section 5.1 and 5.2, there is an IMPLEMENTATION NOTE saying: If no PeerNum attributes are present in the request the tracker MAY return a random sample from the peer population. It's suggested to set a DEFAULT value for the return number if no explict request of number. [Rachel]: Agree. The tracker should set a DEFAULT value. And I think this should also apply in the case of peer_count= 0. BR Yunfei typedef struct { CONCRETE_PROTO_SPEC_DEPENDENT address; // string, addr_in4, // addr_in6, addr_storage CONCRETE_PROTO_SPEC_DEPENDENT port; // string (IANA service port), // or uint16 (service port) CONCRETE_PROTO_SPEC_DEPENDENT address; // string, addr_in4, // addr_in6, addr_storage CONCRETE_PROTO_SPEC_DEPENDENT port; // string (IANA service port), // or uint16 (service port) CONCRETE_PROTO_SPEC_DEPENDENT address; // string, addr_in4, // addr_in6, addr_storage CONCRETE_PROTO_SPEC_DEPENDENT port; // string (IANA service port), // or uint16 (service port)
- [ppsp] Reivew of the base tracker protocol yunfei
- Re: [ppsp] Reivew of the base tracker protocol Huangyihong (Rachel)