Re: [ppsp] I-D Action: draft-ietf-ppsp-peer-protocol-02.txt

Arno Bakker <arno@cs.vu.nl> Wed, 25 July 2012 11:39 UTC

Return-Path: <a.bakker@vu.nl>
X-Original-To: ppsp@ietfa.amsl.com
Delivered-To: ppsp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 406F021F85CC for <ppsp@ietfa.amsl.com>; Wed, 25 Jul 2012 04:39:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.522
X-Spam-Level:
X-Spam-Status: No, score=-1.522 tagged_above=-999 required=5 tests=[AWL=-0.018, BAYES_00=-2.599, HELO_EQ_NL=0.55, HOST_EQ_NL=1.545, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K+5pIoFQpngv for <ppsp@ietfa.amsl.com>; Wed, 25 Jul 2012 04:39:40 -0700 (PDT)
Received: from mailin.vu.nl (mailin.vu.nl [130.37.164.18]) by ietfa.amsl.com (Postfix) with ESMTP id 2539621F8559 for <ppsp@ietf.org>; Wed, 25 Jul 2012 04:39:39 -0700 (PDT)
Received: from PEXHB012B.vu.local (130.37.236.67) by mailin.vu.nl (130.37.164.18) with Microsoft SMTP Server (TLS) id 14.2.298.4; Wed, 25 Jul 2012 13:39:36 +0200
Received: from [130.161.211.249] (130.37.238.20) by mails.vu.nl (130.37.236.67) with Microsoft SMTP Server (TLS) id 14.2.298.4; Wed, 25 Jul 2012 13:39:37 +0200
Message-ID: <500FDAFF.7000402@cs.vu.nl>
Date: Wed, 25 Jul 2012 13:39:43 +0200
From: Arno Bakker <arno@cs.vu.nl>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: Karl Knutsson <karl.knutsson@bredband.net>
References: <20120722185419.GA69574@pad.knet>
In-Reply-To: <20120722185419.GA69574@pad.knet>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [130.37.238.20]
Cc: ppsp@ietf.org
Subject: Re: [ppsp] I-D Action: draft-ietf-ppsp-peer-protocol-02.txt
X-BeenThere: ppsp@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: arno@cs.vu.nl
List-Id: discussing to draw up peer to peer streaming protocol <ppsp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ppsp>, <mailto:ppsp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ppsp>
List-Post: <mailto:ppsp@ietf.org>
List-Help: <mailto:ppsp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ppsp>, <mailto:ppsp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Jul 2012 11:39:41 -0000

Hi Karl

thanks for the thorough read.

On 22/07/2012 20:54, Karl Knutsson wrote:
>
> 1) Section 8.
>   I think it would be a good idea to add an End Option similar to rfc2132 to
>   make it easier to tell where the Handshake message ends and new messages
>   start.
>

Yes, will be added in -03.


> 2) Section 9.1.4
>   The text and the on the wire formats include the Version message from -01.
>   At to moment how Handshake options are sent isn't described anywhere in the
>   document.

You are right, I wanted to wait for people's feedback before adjusting 
the binary notation.


> 3) On the wire format for "MAY explicit close..." should start with
>   receiver's channel id.
>

Yes. Will be fixed in -03.


> 4) Section 9.1.6
>   Text mention a 64-bit microsecond time stamp but on wire format only
>   shows a 32 bit time stamp value.

Well spotted. We are currently looking at the latest LEDBAT spec and 
where and what size timers are needed.

CU,
     Arno