[ppsp] Review of draft-huang-ppsp-extended-tracker-protocol-07

"Roni Even" <ron.even.tlv@gmail.com> Thu, 04 December 2014 15:15 UTC

Return-Path: <ron.even.tlv@gmail.com>
X-Original-To: ppsp@ietfa.amsl.com
Delivered-To: ppsp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com []) by ietfa.amsl.com (Postfix) with ESMTP id 7762E1A8968 for <ppsp@ietfa.amsl.com>; Thu, 4 Dec 2014 07:15:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.1
X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 tests=[BAYES_20=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id gsx9LF1TodCb for <ppsp@ietfa.amsl.com>; Thu, 4 Dec 2014 07:15:13 -0800 (PST)
Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com [IPv6:2a00:1450:400c:c05::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3E5321A0183 for <ppsp@ietf.org>; Thu, 4 Dec 2014 07:15:13 -0800 (PST)
Received: by mail-wi0-f169.google.com with SMTP id r20so36531047wiv.2 for <ppsp@ietf.org>; Thu, 04 Dec 2014 07:15:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type :thread-index:content-language; bh=3KzuGrMbg7oyB9+AcufAZGKr6e/9RahV8JgCH/KCo5E=; b=P1WBiyK5e17KRbD9MIL06NsRXCrqXAqOGXVU6kdDlwMOmjEHppxPJvLKOTk2OVqDlg fDjYCzSdtCyAD4oyoAQLZ8cCpwh8S+7D+SMLelQ0+saP+/SAFYAeTtOiSL/DQ22/dINC 0tEN2ADzrth4uC8hNL+b68D2HlLbtu99j5Gw4FTHDNrvYwTf530WyE+N3SGjRQms5LB4 ZkRAko/JvyOi9RHAZY4Tg66vbpym8NoidDYYs45XKXLr+7mcaZGsDlRd60LR6Pk3ilp1 9vHEc4i1/VTwvW7+8ZAnioPkBTHGQGUgh4Ad98fxQ+Qxmq0fP4Pl2QjtsoRof9mLOAWC k1+Q==
X-Received: by with SMTP id x11mr16686738wju.131.1417706112032; Thu, 04 Dec 2014 07:15:12 -0800 (PST)
Received: from RoniE (bzq-79-180-141-8.red.bezeqint.net. []) by mx.google.com with ESMTPSA id bj7sm40890067wjc.33.2014. for <ppsp@ietf.org> (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 04 Dec 2014 07:15:11 -0800 (PST)
From: Roni Even <ron.even.tlv@gmail.com>
To: ppsp@ietf.org
Date: Thu, 04 Dec 2014 17:15:08 +0200
Message-ID: <079601d00fd5$18ba2f10$4a2e8d30$@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_0797_01D00FE5.DC439B50"
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AdAP1CIibKYMgCkuTdaU6dvHwtMKPg==
Content-Language: en-us
Archived-At: http://mailarchive.ietf.org/arch/msg/ppsp/w8V1pf7faRAj8PG0qmip7JCdxi0
Subject: [ppsp] Review of draft-huang-ppsp-extended-tracker-protocol-07
X-BeenThere: ppsp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: discussing to draw up peer to peer streaming protocol <ppsp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ppsp>, <mailto:ppsp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ppsp/>
List-Post: <mailto:ppsp@ietf.org>
List-Help: <mailto:ppsp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ppsp>, <mailto:ppsp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Dec 2014 15:15:17 -0000


I reviewed the draft and in general it looks OK, some comments


1.       In section 5.3 in the first case it says that the peer will now if
the tracker supports the extension based on the error response why cannot
the peer know it based on the ppsp_tp_versions value

2.       In section 5.4 why not say that if a tracker support version 01 it
MUST support the same chunk addressing method as the peers. This will be in
line with section 4 of peer protocol that says "All peers in a swarm MUST
use the same chunk addressing method."



Roni Even