Re: [PWE3] Danny McPherson's Rtg-Dir review of draft-ietf-pwe3-p2mp-pw-requirements

"Andrew G. Malis" <agmalis@gmail.com> Tue, 01 April 2014 11:37 UTC

Return-Path: <agmalis@gmail.com>
X-Original-To: pwe3@ietfa.amsl.com
Delivered-To: pwe3@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B72A81A7006; Tue, 1 Apr 2014 04:37:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.7
X-Spam-Level:
X-Spam-Status: No, score=-1.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, MIME_8BIT_HEADER=0.3, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yOcOzCIZ6i39; Tue, 1 Apr 2014 04:36:58 -0700 (PDT)
Received: from mail-qa0-x22e.google.com (mail-qa0-x22e.google.com [IPv6:2607:f8b0:400d:c00::22e]) by ietfa.amsl.com (Postfix) with ESMTP id 799441A6FF0; Tue, 1 Apr 2014 04:36:58 -0700 (PDT)
Received: by mail-qa0-f46.google.com with SMTP id i13so9272550qae.19 for <multiple recipients>; Tue, 01 Apr 2014 04:36:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=U8oChl3DTrBZyBBp0qZ5pq1PiOftWiE2KlWxdm0qWV4=; b=ZzfOlSQA/KQixJpBKcKJKfbIGj3bI3jrCdvADT3JqjU2E1yWY1xuEA949AjfDKstsM A1qkYQvB9JMMkq8d+FBRTLZ4c0HrYh610pTwWPHU3Mxcr9VraeOlj7tkO/b0rzceh/no uMRb2rHoCqTKnILXFXDqYM/RduasMYpSth9MX7e8G6LWjwzMGFvP41kCYyhqtUX475wY mHgARW+qmicbsGKmxkUjFnGq6ezrYw8sWDOkYj0RRouFu4EdKVzGcAfFWhkQB5hyEVXm y+HjW4mYs2YFT/9e1rE+SvzByypFMuWLV1Ngpq58mxPjjaXZYRhqnVH9rcR+azVhyexT JqNA==
X-Received: by 10.140.20.36 with SMTP id 33mr15040874qgi.37.1396352214863; Tue, 01 Apr 2014 04:36:54 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.229.205.69 with HTTP; Tue, 1 Apr 2014 04:36:34 -0700 (PDT)
In-Reply-To: <78046FD1C8FE0345AFBC11640A8DF6E201864A00807C@CHCROCHC051.orange.ch>
References: <022001cf4cfe$25fd5fc0$71f81f40$@olddog.co.uk> <78046FD1C8FE0345AFBC11640A8DF6E201864A00807C@CHCROCHC051.orange.ch>
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Tue, 1 Apr 2014 07:36:34 -0400
Message-ID: <CAA=duU189JszHdPBAnpYU0fxLs7B5G1SSxO0g2d__9hkGte=bw@mail.gmail.com>
To: =?ISO-8859-1?Q?Jounay_Fr=E9d=E9ric?= <Frederic.Jounay@orange.ch>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Archived-At: http://mailarchive.ietf.org/arch/msg/pwe3/j6j3wVw1Dy8xETTHRCjKG4UYqfQ
Cc: "pwe3@ietf.org" <pwe3@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-pwe3-p2mp-pw-requirements.all@tools.ietf.org" <draft-ietf-pwe3-p2mp-pw-requirements.all@tools.ietf.org>, Danny McPherson <danny@tcb.net>
Subject: Re: [PWE3] Danny McPherson's Rtg-Dir review of draft-ietf-pwe3-p2mp-pw-requirements
X-BeenThere: pwe3@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Pseudowire Emulation Edge to Edge <pwe3.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pwe3>, <mailto:pwe3-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/pwe3/>
List-Post: <mailto:pwe3@ietf.org>
List-Help: <mailto:pwe3-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pwe3>, <mailto:pwe3-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Apr 2014 11:37:01 -0000

Fred,

Thanks! Also don't forget to address Adrian's comments from March 13,
and Brian Carpenter's comments from March 18.

Cheers,
Andy


On Tue, Apr 1, 2014 at 4:12 AM, Jounay Frédéric
<Frederic.Jounay@orange.ch> wrote:
> Hi Adrian, Danny, All,
>
> Thank you for this new review.
> Please find below [FJ] how we intend to address the comments in a new version
> If all co-authors agree, we will update with Yuji the new version
>
> BR,
> Fred
>
> -----Original Message-----
> From: pwe3 [mailto:pwe3-bounces@ietf.org] On Behalf Of Adrian Farrel
> Sent: Monday, 31 March 2014 18:28
> To: draft-ietf-pwe3-p2mp-pw-requirements.all@tools.ietf.org
> Cc: rtg-dir@ietf.org; pwe3@ietf.org
> Subject: [PWE3] Danny McPherson's Rtg-Dir review of draft-ietf-pwe3-p2mp-pw-requirements
>
> draft-ietf-pwe3-p2mp-pw-requirements
>
> Hello,
> I have been selected as the Routing Directorate reviewer for this draft.
>
> The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request.  The purpose of the review is to provide assistance to the Routing ADs.
> For more information about the Routing Directorate, please see
>
> http://www.ietf.org/iesg/directorate/routing.html
>
> Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other comments that you receive, and strive to resolve them through discussion or by updating the draft as appropriate.
>
> Document: http://tools.ietf.org/html/draft-ietf-pwe3-p2mp-pw-requirements-07
>
> Reviewer: Danny McPherson
> Review Date: March 31, 2014
> Intended Status: Informational
>
> Document Overview: This document presents a set of requirements and a framework for providing a P2MP PWs over MPLS PSNs.  A P2MP PW is a mechanism that emulates the essential attributes of a P2MP telecommunications service such as a P2MP ATM VC over a PSN.  The I-D describes the general architecture for P2MP PWs with a reference model, discusses data encapsulation, and outlines specific requirements for setup and maintenance of P2MP PWs, with a focus only on Single-Segment PWs.  This version was lasted updated in February of 2014, although it has existed as a PWE3 WG document since March 2009, and as an individual contribution (draft-jounay-pwe3-p2mp-pw-requirements) since February of 2007.  Among other applications, it provides primitives that can be employed for Virtual Private LAN and Virtual Private Multicast services, such as those specified in the L2VPN WG.
>
>
> I have no substantial concerns with this document.  There are several comments and nits below.
>
> 1. I am not sure if from an IPR perspective the claims regarding IPR that apparently no longer apply to this version of the document need to be explicitly acknowledged as such by the relevant co-authors?
>
>
> Nits
> ===
>
> General:
>
> 1. Only single-segment PWs are addressed, not multi-segment PWs.  I understand why this is the case currently although I wonder if the requirement akin to "a single NMS" such as provided in S.4 should be conveyed forward?  I suppose it should simply be out of scope.
> [FJ] Indeed this section was meaningful when MS-PW was considered. I don't see the added value of this chapter in the case SS-PW. I'd suggest to remove the section 4 "Manageability considerations"
>
> 2. In order to align with descriptive text in S3.1 it might be useful if the Reference Model in Figure 1 depicted where root and leaf PEs reside in the topology, and perhaps also that multiple CEs could be downstream from a single leaf PE (the latter point Farrel made in his AD review as well, IIRC).
> [FJ] I agree with the proposal to show 2  CEs behinf one Leaf PE, as described in http://tools.ietf.org/html/draft-ietf-pwe3-p2mp-pw-requirements-00 .
> I'd suggest we add ROOT and LEAF, as follows
>                                      |<-----------P2MP PW -------------->|
>                       Native  |                                                                    |  Native
>       ROOT   Service  |    |<----P2MP PSN tunnel --->|     |  Service        LEAF
>          V            (AC)    V    V                                                    V    V   (AC)               V
>
>
>
> ---
> S 3.2:
>
> -
> A single P2MP PSN tunnel MUST be able to serve more than one P2MP PW traffic in an aggregated way, i.e., multiplexing
>
> -
> "not destined to Leaf PE at the service layer." reads a bit odd and ambiguous, might use a bit of expansion.
> [FJ] we might rephrase it.
> "but using this P2MP LSP would imply non-Leaf PEs (i.e. not part of the P2MP PW) to
>    receive unwanted traffic"
>
> ---
> S 3.4.6:
>
> -
> "In the example depicted below, a standby P2MP PW is used to protect the active P2MP."  -- might consider adding a "PW" after the last P2MP in this sentence.
> [FJ] agreed
> "In the example depicted below, a standby P2MP PW is used to protect the active P2MP PW."
>
> -
> It might be useful to identify the "leaf" and "root" layer in Figure 3 & 4 as well.
> [FJ] agreed to add ROOT at the top and LEAF at the bottom of the figures. (I'd prefer this solution than adding new acronyms in the Terminology section.
>
> _______________________________________________
> pwe3 mailing list
> pwe3@ietf.org
> https://www.ietf.org/mailman/listinfo/pwe3